From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7221105623410147328 X-Received: by 2002:a17:906:284f:b0:94f:8ec3:5076 with SMTP id s15-20020a170906284f00b0094f8ec35076mr1048046ejc.5.1681740612017; Mon, 17 Apr 2023 07:10:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:a10a:b0:94f:b78b:774e with SMTP id t10-20020a170906a10a00b0094fb78b774els546538ejy.6.-pod-prod-gmail; Mon, 17 Apr 2023 07:10:10 -0700 (PDT) X-Google-Smtp-Source: AKy350Y8hr7CqyTbaxWOWAcaGnw7xe6KMycfDkLnUb03be1GmxHIynkqnEs80YsVUN47bMoYGPae X-Received: by 2002:a17:906:3ce9:b0:94a:826c:df57 with SMTP id d9-20020a1709063ce900b0094a826cdf57mr8932935ejh.39.1681740610336; Mon, 17 Apr 2023 07:10:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1681740610; cv=pass; d=google.com; s=arc-20160816; b=Vn8mL7mB+teYmxE5UfHETrEtWSJOMyAC/bN9ajgbLpM4HYPuy3K6gXVl1BFhjtGKDb 4yRpHE/6X1c2j4sYIPa142dkSg29wrPpZvYKJMTf+I4zq9O2g7t5xwTY6YNSf/fVsH9S rDWK8Klt5M94wdmbtZ+J+YWZJcZFZUENclfV7StAHoLDBN54CNsVMlJvWuasOOOCmvG3 niDx+UA9g5H3VquShtIWaqZW5feny93tCQeYWyQ7tt0SOIySJRPp3eWTx/+mXF+xZlg4 xB6f7cUScpy4hNTVadyFUbcH2StruGHzbSjxJonU2lhxjvaNuu47oGgirvx6stz8s7Y6 Zeiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=K9eiUqCUgsYT5FTLzJC9Z+fo0pAYfzJDjor0ShMfqN8=; b=htX7WK54rwYFHWhR6UQRylZGZjexP7/qJPUwu3mLxxHYfMo4Q9Da9dcGdhLYcEvIfS BKs2WmY8jKcmCbO4YsjEz+eutFzenPrfPuQly7ZGt/NoVwsMF1sV4+rGdDSROvzbLQky BMX5O/RqIMlZiKBjoJXKl0heYed+1RK600Di4LTSo9N2/WVUuE3L1LWpIy4uTSSoorgF T8u0y8LGt6oVk7D8uAGWx9ByJyjkXf+nYjEuSljlk814YXmtulb2wq8LbZvtEFN0zxd1 XsJhDhgVrOKCBhQ02Dmdr/2pKr7cJDvMQvbQdJUjusRHboDKq6Cnrg5JtXyuEnCxub9m G4Dw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=b+0DQlQP; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe02::625 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0625.outbound.protection.outlook.com. [2a01:111:f400:fe02::625]) by gmr-mx.google.com with ESMTPS id d10-20020a056402400a00b00504adbbf1a6si719568eda.1.2023.04.17.07.10.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Apr 2023 07:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe02::625 as permitted sender) client-ip=2a01:111:f400:fe02::625; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=b+0DQlQP; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe02::625 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwJtB7sSlrX49xJCOesT5CCuwDcQoPfj/W36YD24WZioBw37BTykfUOuIEnE77oYXghbymqTaTU0SNgOUGor/ys7pbUMNTJ2wrU53LDL5LWcE0TCQN2NJTqkd+Q08zHMaS6dC85241qAaQ/9tmNIwjv85lENhec76d4q5y8XQ8JEn5xPZIFYnmUhn2v0ydQQZ/eDl4o8Q1gPb5goAY3W/oN3j/jTHHu0IEv7gM51raRzF846FR08u4vYuVKkqBoLue4D1pa2pPMd73sdVVxpXLT/3FafmqjA2pQ5/8hQWwmBFm4C5pVfdaTs16/4ZR6ILUSPmbNPsOBkoPVBsjLXuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9eiUqCUgsYT5FTLzJC9Z+fo0pAYfzJDjor0ShMfqN8=; b=e/q5IIUDTE3zVKJrTuP15jj5LjswRZ/LAdfoeMxdW6o1vCVpy4yZLyDpnKnfoGVHHuS+g+60IgAxJ+WIn5Qfc9Ysoj1Qzc4eAkp4/DKNm5Yfa0OsQP1oBw8hY3HTUAsrGD0WZMozvCHVbFe3w27+fNx0J6y1qHqc8IM2DzsO15BHhLMksHLRtClytrhk4BNsMCvY4DGMbXswSn/Xo+8hXIwH58/HVuwmufu6bpwgHAH2NhXUY0mRFeeHCyqvgVu3Jp9gxe/bW+onCHJCXmJRrZq/QI5MySPsbN50WJCxwiFMtIoVrvu7ucoBxMFnnV3mQLkNeJWypYKbKPkt3Y/f4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9eiUqCUgsYT5FTLzJC9Z+fo0pAYfzJDjor0ShMfqN8=; b=b+0DQlQPPdtFv23FsFkTAPtmP8TDjTLDuw4gOLHT6i81MTv0+INGMwL/umVPLHRrjjgP7xxxVisHDC6md2HC2zSKrMyUAg+Zc8CkXjcLgfAkNBsVez3avH32H1tQ7uW7ZUJaV9IBa9G4Ekicz2aPL2+SEVN5karwfQVDM/sO2a7pxDK5imTXBFrzhUQiIZDr9fDhB+XBvizdtLTPrCos1oSXEM+5o7/k7e6QybTZO8qWW7EuU9AzJQ3Bu7oTKajP+7htn/t493pBleOORcpK1zETPsZwjbeBRM90/CV1Zm/AfZMEmF5+VAlSuk2LyHj2w6uaECcYcxJ+4vipCRTBcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by PRAPR10MB5422.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:27a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.19; Mon, 17 Apr 2023 14:10:09 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::f5ab:5f59:3b47:fc2e%5]) with mapi id 15.20.6319.019; Mon, 17 Apr 2023 14:10:09 +0000 Message-ID: <7c8c6715-0ecd-35ab-4865-9b549f833ccf@siemens.com> Date: Mon, 17 Apr 2023 16:10:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] meta/conf/bitbake.conf: enable SRCPV support for AUTOREV Content-Language: en-US To: Srinuvasan Arjunan , isar-users@googlegroups.com References: <526d9fd9-a8ab-ba29-d925-6c77afaaf985@siemens.com> <20230417132734.1023825-1-srinuvasan_a@mentor.com> From: Jan Kiszka In-Reply-To: <20230417132734.1023825-1-srinuvasan_a@mentor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::9) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|PRAPR10MB5422:EE_ X-MS-Office365-Filtering-Correlation-Id: d0882d65-93a7-4793-eda8-08db3f4d73a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xxBEJT9AXQjKjsAQWQ6hS0UAQgUNiiMR1YbB6kMhwoxwkAf0EnKBDdFhFnGLY5Swg/0a0KidiNwOmQKOUeVBWTUtdj0bEB3hw7/ET8mdM8x0jiR1r6KZw8ZRZi1A6xuOsBMmrgSGxqNnTFr4V/YKs2EkBAYhyIruMUpHWO6ehUuyHY0rekD4CqVol87pcSTz63zto9njRnMXlpScl+ldFsCepQRQWzgb/cgonsf45P1C2LgIFEZS3iz/iythKBMn8xHm0OPr0TrBmN0ZhOxqb5Pe6M1w5rcB63phkRTjEfNsdpzcr/xpEuNIUP4RfpmUeR0KQClIwRSDrd7VyYpITXkCRmYwnjViy/XwGB2g3qr7C7biVV4fhqdKv7KPxHbrMX8X2jxe8S51XQKwl6soGVRHs1WIxKlhrKGjQ6XEcArkN9bZxtPUK3B8PFzt4fzjCLKqR1Pjkgl8WlaBN1WkMDJWXkHlAnCkoxBVGocc4VaRGjX38546lqYmhKfD5NQSecUEzwz3KtSN/7uW/EQtVm2Q9wfi06iPNav4veLfpWGMwkymRRqRJl7qDM4YOlHRCP3beFY3jDpFMbcIoMT/cYFCAy9qTuoM0Q5uMkY3IybVdujfl87HVxOpTqNU2rVNUu0ANnqBe8yXGlVEq2LJvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(451199021)(6486002)(6666004)(86362001)(478600001)(31696002)(2616005)(36756003)(83380400001)(26005)(6506007)(186003)(53546011)(6512007)(82960400001)(38100700002)(66946007)(66476007)(66556008)(316002)(2906002)(8936002)(8676002)(5660300002)(44832011)(31686004)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUczN2x4UThwSllETldwZC8vc0x3YmtHczJ2L2pkQ3BLWGF1b1lwayszb2pB?= =?utf-8?B?SVJraFJaYTBDV05kVWtVR09OV3JFbTVVUTJ3blczTloyTkJwV1hrb0s2U2Va?= =?utf-8?B?LzMramNxaGN2ZFNYQlhtaVhsQjRuczc5MForSUU5MG8vajE2c2JqbkxMckRS?= =?utf-8?B?elNUNzlkRE1YeWxWeGw3eTZEdld3TXM3R3RTODRCVDNIbWlPNTA4OVRqUjQ4?= =?utf-8?B?aDVpZDJlRFpHNEx0TTVnN1IwaS9iUXpFTlJBZDEralk3emlnUDFQbS9LT2dU?= =?utf-8?B?Qkg4K1FPQXAxd3lnRWpmcE94bEZlY0J2anBnK1kvRm8wLzdmTnlMd1lPTjF5?= =?utf-8?B?V3ViQTZ2VVlOM0YrVVNKNEErQWEweFdES3NzM0REUm1yOFNhV3h0KzNhM1Bz?= =?utf-8?B?UmVIRFpZdmxHM0R0ZThZRHBUK0xqUTk2eE9LUDhZT1VDVm1aRlpYYm5ENk9l?= =?utf-8?B?ZDNIMHFNeWxNZmNTSG10bk9oeGE2VytkN2F2ZUQzZm9XSUZ2ei91RDJ6MXov?= =?utf-8?B?bzFYVytLYWlvWEp2ZnYvTlZLZ0poL2t5eCtRSG1QSXVMcFQzQW5lQ2tGZjMx?= =?utf-8?B?UURUL0xTYndqU1NqcDEzUFNFUUV6RW9FTlVvSjMzclFoSzhMRzEzV0xQYzgv?= =?utf-8?B?UmVMcDRUQUQ0UmF5WThhb2RCU2I3VWNBRzg5bG5CVXAyZW9INkU3em5MM3VC?= =?utf-8?B?NmQ3MEtEVWNYTHFoS0N4Vk5Wb1Z5ME02LzN4Nmp4eSsvWUNVNUxwcC91cWkx?= =?utf-8?B?NU4rTThUeWhyVlA3R1ZHbU01TXhhZE9MQ25LUEx3TGVxMDFzZTRoa0tOY3dS?= =?utf-8?B?ek1UaklGNHhMcG5aZHpUVjl3ZVJhL0FGN0tOWmFyV3BCQzRic084UEZnUWpF?= =?utf-8?B?T0pTY3B2cXVjRHpYd1ZlZGg3MHpVSnZ5VUhEZ0VCMDhuVG5aZ2lPdXVmbC80?= =?utf-8?B?eEV2TU4xSzIvYTUwK25SQUVJZ3g4ZWw0QldraE9Kd3JmeCtySmRKODJSd0gx?= =?utf-8?B?K1RscXZtNzBVRERqZ0F1SmtsYzRGL2Y4MldPeWdBOWFKSklLWXFpSVlUYmww?= =?utf-8?B?alpsYlUxcjJ6UlJjQUo1ZmxUU2x2ZFNnM3dMNlF0Z3ltZzBGeVJEamZFTEVu?= =?utf-8?B?a09wQ2ZmVG5IZ1lZVGNXVnJiby9VeHBubnFsTzFJeEtneGUvZzl4VVpCbklQ?= =?utf-8?B?TkxWWTBaVkYyUWpDbDFqMmhWYlhDYVh0NWZiNVZMVFpMT3dWTmhraG93NVA2?= =?utf-8?B?bHdLT2VVSmhaVG9GNVU2Q0hSdTIzakRZdnNEZjBJaU8wYVZvYmFEZk5zQWVh?= =?utf-8?B?bFhGSTBRNEthcWNqUXpOc0U2dWwxb05ZU0pHckVLaWxZeGhWWitMSnFKeFNK?= =?utf-8?B?dU9pNjhKekxYc2QrV0RwaWZmWGcrbXpMKzd3R01hOE5HdjRzbnZiQjhmSjNo?= =?utf-8?B?cWtSYis4cmJxb2s0V0tucDFkWG83WXdQM1FJMis0dk5JbGU1TGFnbGordTM0?= =?utf-8?B?Z2RBSFZtTWtTYjYzbFllTCs4djI4T1VQRkNJWS9KOFlLWEMrVzdYaENoMzdQ?= =?utf-8?B?N0ZpdjBpL1FaWldpOEZhclRKeWpGZkhEbXhsMTA5VFA0ek9hWHlqNXByckxC?= =?utf-8?B?V3lmVjdxRWpTODlwRTAvRTZHRUNiOVNDWE5NcGRTdEZ0VnA5SGZ5RlptVzRU?= =?utf-8?B?b01kK09oN1NRUDhTaVl1YytzdVRYLzloWkRMRFR3STI1a1FRWHZZTUU2bXl4?= =?utf-8?B?R1A4YStyajBUTVhsRWFaYTJCSUowMmFCMktHTDk2bStVTzBNK090UlcrcDBx?= =?utf-8?B?a01GZE5STkJUc05XTWFVUWdiL3g5NlJtR0FMSXFDcTgxcDEyRDRvc1U0U0x0?= =?utf-8?B?UEFCV09TQ1BzajZMTTdCZDVXM0lSMCtFTTFRUFdTV3VPUXhsZUMrU0xRbjE5?= =?utf-8?B?emJuNzZETWRlTUYxZEl2MWRLN21hcVdTQUpWZFRXZ20zUkNXWVhWZ0ZhelRk?= =?utf-8?B?Rkx4S2UxQmdYK0d2VVRVTVpCWFU5N0s4UEhFOUMwTGdVYi9WMjF6bm9jbjU4?= =?utf-8?B?L0N6bXRiL0FNYUhuanJIV2sxRmh5Tm4vbUZ0UlVVREgwV2o0ZDNIdVFXMHdi?= =?utf-8?Q?U/kycV74ScqhLoKaUuan5kgti?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0882d65-93a7-4793-eda8-08db3f4d73a8 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 14:10:08.9750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSPzKi+C1NOgpY759o3E1oHev/pV5NQzJZvhuRq6rSn1AAZ0rsXuflkK7aEC2MxqdlqlheFypya/u031J2PplQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5422 X-TUID: bZnlb7SjOS7j Make sure to always version your patches! On 17.04.23 15:27, Srinuvasan Arjunan wrote: > From: Srinuvasan A > > One of our downstream project recipe uses `SRCREV = "${AUTOREV}"` to get > the latest changes always, but this not works after bitbake 2 migration, > it throws the below error. > > do_fetch: Fetcher failure: Recipe uses a floating tag/branch without a fixed SRCREV yet doesn't call bb.fetch2.get_srcrev() (use SRCPV in PV for OE). > > Till now we don't have support for SRCPV in ISAR, hence add this support > as like OE. > > Signed-off-by: Srinuvasan A > --- > meta/classes/base.bbclass | 26 ++++++++++++++++++++++++++ > meta/conf/bitbake.conf | 4 ++++ > 2 files changed, 30 insertions(+) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index 53550ae..f631483 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -120,6 +120,32 @@ root_cleandirs() { > python() { > import re > > + needsrcrev = False > + srcuri = d.getVar('SRC_URI') > + for uri_string in srcuri.split(): > + uri = bb.fetch.URI(uri_string) > + # Svn packages should DEPEND on subversion-native The comments is not fully accurate for Isar (we are not building such tools natively). Same below. > + if uri.scheme == "svn": > + needsrcrev = True > + > + # Git packages should DEPEND on git-native > + elif uri.scheme in ("git", "gitsm"): > + needsrcrev = True > + > + # Mercurial packages should DEPEND on mercurial-native > + elif uri.scheme == "hg": > + needsrcrev = True > + > + # Perforce packages support SRCREV = "${AUTOREV}" > + elif uri.scheme == "p4": > + needsrcrev = True > + > + elif uri.scheme == "repo": > + needsrcrev = True > + > + if needsrcrev: > + d.setVar("SRCPV", "${@bb.fetch2.get_srcrev(d)}") > + > for e in d.keys(): > flags = d.getVarFlags(e) > if flags and flags.get('task'): > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index f421050..124bf49 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -36,6 +36,10 @@ PR = "${@bb.parse.vars_from_file(d.getVar('FILE', False),d)[2] or 'r0'}" > PROVIDES = "" > S = "${WORKDIR}/${P}" > AUTOREV = "${@bb.fetch2.get_autorev(d)}" > +AUTOREV[vardepvalue] = "${SRCPV}" > +# Set Dynamically in base.bbclass > +# SRCPV = "${@bb.fetch2.get_srcrev(d)}" > +SRCPV[vardepvalue] = "${SRCPV}" > SRC_URI = "" > STAMPS_DIR ?= "${TMPDIR}/stamps" > STAMP = "${STAMPS_DIR}/${DISTRO}-${DISTRO_ARCH}/${PN}/${PV}-${PR}" Except for the comments, this looks good to me now. Just wondering if we could somehow stress this path in Isar upstream as well - though that should not block this fix for AUTOREV. Jan -- Siemens AG, Technology Competence Center Embedded Linux