* [PATCH] u-boot-custom: Fix parallel build
@ 2018-10-01 22:15 Jan Kiszka
2018-10-02 9:31 ` Henning Schild
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2018-10-01 22:15 UTC (permalink / raw)
To: isar-users
Do to missing "echo", we were running with "-j" so far, and the build
log contained some complains about unknown commands.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/recipes-bsp/u-boot/files/debian/rules | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-bsp/u-boot/files/debian/rules b/meta/recipes-bsp/u-boot/files/debian/rules
index deb7c8e..1d9e645 100755
--- a/meta/recipes-bsp/u-boot/files/debian/rules
+++ b/meta/recipes-bsp/u-boot/files/debian/rules
@@ -12,7 +12,7 @@ export CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
SET_CROSS_BUILD_TOOLS=CROSS_BUILD_TOOLS=y
endif
-PARALLEL_BUILD=-j $(shell $$(($$(nproc) * 2)))
+PARALLEL_BUILD=-j $(shell echo $$(($$(nproc) * 2)))
override_dh_auto_build:
$(MAKE) $(PARALLEL_BUILD) $(U_BOOT_CONFIG)
--
2.16.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] u-boot-custom: Fix parallel build
2018-10-01 22:15 [PATCH] u-boot-custom: Fix parallel build Jan Kiszka
@ 2018-10-02 9:31 ` Henning Schild
2018-10-02 9:34 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Henning Schild @ 2018-10-02 9:31 UTC (permalink / raw)
To: [ext] Jan Kiszka; +Cc: isar-users
Am Tue, 2 Oct 2018 00:15:55 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> Do to missing "echo", we were running with "-j" so far, and the build
> log contained some complains about unknown commands.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/recipes-bsp/u-boot/files/debian/rules | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/files/debian/rules
> b/meta/recipes-bsp/u-boot/files/debian/rules index deb7c8e..1d9e645
> 100755 --- a/meta/recipes-bsp/u-boot/files/debian/rules
> +++ b/meta/recipes-bsp/u-boot/files/debian/rules
> @@ -12,7 +12,7 @@ export CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
> SET_CROSS_BUILD_TOOLS=CROSS_BUILD_TOOLS=y
> endif
>
> -PARALLEL_BUILD=-j $(shell $$(($$(nproc) * 2)))
> +PARALLEL_BUILD=-j $(shell echo $$(($$(nproc) * 2)))
Why the "*2", usually nproc or nproc+1 should be what you want. And in
that case "nproc" is simpler to script.
Henning
> override_dh_auto_build:
> $(MAKE) $(PARALLEL_BUILD) $(U_BOOT_CONFIG)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] u-boot-custom: Fix parallel build
2018-10-02 9:31 ` Henning Schild
@ 2018-10-02 9:34 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2018-10-02 9:34 UTC (permalink / raw)
To: Henning Schild; +Cc: isar-users
On 02.10.18 11:31, Henning Schild wrote:
> Am Tue, 2 Oct 2018 00:15:55 +0200
> schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
>
>> Do to missing "echo", we were running with "-j" so far, and the build
>> log contained some complains about unknown commands.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meta/recipes-bsp/u-boot/files/debian/rules | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-bsp/u-boot/files/debian/rules
>> b/meta/recipes-bsp/u-boot/files/debian/rules index deb7c8e..1d9e645
>> 100755 --- a/meta/recipes-bsp/u-boot/files/debian/rules
>> +++ b/meta/recipes-bsp/u-boot/files/debian/rules
>> @@ -12,7 +12,7 @@ export CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
>> SET_CROSS_BUILD_TOOLS=CROSS_BUILD_TOOLS=y
>> endif
>>
>> -PARALLEL_BUILD=-j $(shell $$(($$(nproc) * 2)))
>> +PARALLEL_BUILD=-j $(shell echo $$(($$(nproc) * 2)))
>
> Why the "*2", usually nproc or nproc+1 should be what you want. And in
> that case "nproc" is simpler to script.
You usually do 2-times overcommitment with such workloads to ensure that no
single CPU is idling because of I/O delays.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-02 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 22:15 [PATCH] u-boot-custom: Fix parallel build Jan Kiszka
2018-10-02 9:31 ` Henning Schild
2018-10-02 9:34 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox