From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 10 Nov 2025 12:53:16 +0100 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f58.google.com (mail-lf1-f58.google.com [209.85.167.58]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 5AABrFPK018926 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Nov 2025 12:53:15 +0100 Received: by mail-lf1-f58.google.com with SMTP id 2adb3069b0e04-5942a78fbccsf1610362e87.2 for ; Mon, 10 Nov 2025 03:53:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1762775590; cv=pass; d=google.com; s=arc-20240605; b=JPmrq95XNdGM9rmRgdMHJovHqxhIzHQ4WmUxg/9BZCAyCTgXI9IRe5oRH0/NC8RYk4 dyuoJI5zdww6sypRQANH9vNVllgyOeFRe/mUn1p1iLqTvmyty+k9lEcxQI+ODPDB2uY/ 0977+UfOoJqtiKTuLvUMIZe+VzLrAS7vb/RVcd6zEJZW4+5259aQZBQeLN8QFe1vk0tS 03Ne7G0B3+vD4lbP4nMfgt/sb/JiQifpuGQLCZ1WbeMcBGgMazOREmXVD7vC/De5wiLm IU++ayh5CIvrGYV/Hjz/8DiVhWMBjiNSAEcFHEjMVR57m0Npe8KSxWBLYNnoDcToQDsT Erxg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=76r8DSYr/01LTTwGryd7uSfmozmCz+utyoaTWZPaoCY=; fh=9+n+E3LYbMl/mvFriRcLAgoXz6gqU4arZCumrYyIQsg=; b=JSPFRMRk5toHlLnUoHA2O9GPgdsZXIIBGJUkbgDozuTma0DJxxJvNrxFb4EwIivkCj IxNO3uTQW3BGNQxrVthe6yZU5xwQehjvIZXMEcxUXU9ETa0t56gBanMlxWlVGVNmG7VJ rBnT3XjfNd/TdLXaXEulQ3Qv+E2ffeIQnRvyyUeKJV2hqx14NrepYlDR9HGSz9CW7ItI WX4S/3lnyP8+J+6AgAHPVGCL+6mMXz1vxzLAiEMv1A3MoQTydRXgDNgHnhcyZuus50vJ gChu8IQ0+wPbIbl89gDvYKHwsDUQRENWz9z/XgBPSstWlvUZM3k2PCb/PitlbVvxqk18 I8YQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1762775590; x=1763380390; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=76r8DSYr/01LTTwGryd7uSfmozmCz+utyoaTWZPaoCY=; b=ki9ENwj0a5tdCVtcvEQxx4UpBYBIb8m2pKcNO1KRlYAYDIE4sXAA+NmVcRfum85alk ZiL2m7tRrUAH9T3rhBlzokqa2fnJzdNxw6zqnTK6EbaVSPOYGBSD/4McXmeJLsOBai3H yqcbHPhWtWdfPZflxqgMZNFC+jvtC5iCO5+MBTX02gvLPesIWV6ccSTOFJj9yTEbB3MX z8llZ2QvVWT54mhfZ7GOvy+daULKdFm1gUcRQZP7Xdad9DokBWembvHABUxYSFGqVWLl lWn6yI/fiSla+eMGZ2sDSar2Xr8bFepBUW3HMPrp5Z1Nn1GfHZnUleIc1tSr4YKF8kq/ CBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762775590; x=1763380390; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=76r8DSYr/01LTTwGryd7uSfmozmCz+utyoaTWZPaoCY=; b=fW+YG2muA7dhLW5ydDoiDnPMujLX3YNFr6cbelJ6ZJrPelba7kuSVW34834J+Czv+C fJo/4RcI4C4PfW96u3bFSVeu46T4Pe8x+d9V4C+7vHyllIVThmBT7X/K60+AZAKKZt6V /LU0fJYw27cwROE9njC0BogQ2jtW70VMa5zmJ9xuTyYcS186chZem2etaemAZLjnkIQs n1nOlAQJket6KinxPWEFGUq6hQuuwWtXYoJSvEVZb7J/1L6l6jOOfJr5o7HF7Y3tB1ht v95YL4b19nRCwe54RZARXnt/WbtAcuAxAWVyiZ8+wcM7NPApGp7ta0vL+vLMS7x+lFwY Qn2A== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCV/txdsV97IEBnDMcJZZjKUPr8A+SmzqwXWrkwSaePQ4DT65melrLeroIuyz4SzdHc8K9FI@ilbers.de X-Gm-Message-State: AOJu0YxKhCK4J1Roz7gERlHAoOYeOEp4Hw0sJTrCxxMcPFqsrwHU4/eX eR1CQicJyNcCusllzFIokREubBNz+VAvxnCBXBuOLRUkpeEBkxa1JdrN X-Google-Smtp-Source: AGHT+IGizIBSwOwWVMqO2LMkTwPU1mJTroEKk/LXY5UeIMl2xnUSeHgLWHkWr0jzQ4x3KDNu3ROTpg== X-Received: by 2002:a05:6512:3b9c:b0:594:48e6:26b8 with SMTP id 2adb3069b0e04-5945f1e52c4mr2068582e87.39.1762775589684; Mon, 10 Nov 2025 03:53:09 -0800 (PST) X-BeenThere: isar-users@googlegroups.com; h="Ae8XA+avAb7/h9XEj1hG0P0DiDzXps4iocs30vdMhpZOZjFu1g==" Received: by 2002:a05:6512:40d6:b0:594:524c:ff40 with SMTP id 2adb3069b0e04-594524d0c66ls981680e87.2.-pod-prod-01-eu; Mon, 10 Nov 2025 03:53:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWZ9iuMi/wSypOrtrMFVWYM7hIk2b9HabWcUu+ym/aINvUq9GBFbBvvx/X1e7LXwnuCvJa01houJVi0@googlegroups.com X-Received: by 2002:a05:6512:3b9c:b0:594:48e6:26b8 with SMTP id 2adb3069b0e04-5945f1e52c4mr2068529e87.39.1762775586733; Mon, 10 Nov 2025 03:53:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1762775586; cv=none; d=google.com; s=arc-20240605; b=hADNWCsk2j132XkEqOqJjDGPNjph4hnNO9NVVLt8iWuHLjgO8foc5z4D9j5dvd8o8r ZWeHu+Y1SRHkoK51uqNntMdULlAz6pWXo7xbh+ALs6Iww+OfNaYwXUCO/6+HtP7lmr4P doJKRN0+ZjfgDsm+p9Y5jwtuSFoAIrJjwHlMqMpBBEjFZfyVVmODSfgIgpqc2dM1PC/h q1Saz9Ry/XgdfYyepOqf7KFRF/sVA+bIOwN+P2+s83Pe0RSEeDGex2uYV+i2wbNscg// VpIu2iLicOCEvcnJnvxD5EcuVHBheWlfBi2GwdMpc+pl+8hVfeA6hCnokyd+u3ehPHll hQPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=bNjbA7fZjUv8pY+BbmThjJs22ZEz0yF7y5sscUtByvM=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=Jff19zhjWGV2wXb/EAmyq2LNR471i1H3Zs9GOrFybgThwPTvxS/yIoovFUhi9q5Z1P izcDKroXR8IH7C/yF7hn39xXsEcjFtL0zY9G7PSEWlLGfwburmkWWY3x9FfJiu0l/DfE r/KHv3BJ+orJSUhQ5pmQCyXpSt9yoFoY8tA/+XQCgX2YadOTW0RkffxAXqExija40zhe rvQF3zgunGT54MQPNj1keeV7WZiuUuxxByhouyVQyV1LPb6r3H0v2t1ooJPy819NyooJ 1s7IynZdUW3XfdfXkQrXBEt2LG0hOqSyLTykexcq8o6ShAVb6mfNskUFaQB/G1Woved2 Znuw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 2adb3069b0e04-5944a0636d9si364828e87.3.2025.11.10.03.53.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Nov 2025 03:53:06 -0800 (PST) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 5AABr5AC018912 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Nov 2025 12:53:05 +0100 Message-ID: <7cc53bda-e512-40a2-b05b-f3569991e857@ilbers.de> Date: Mon, 10 Nov 2025 12:53:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] customizations: defer IMAGE variable expansion in CUSTOMIZATION_VARS To: Cedric Hombourger , isar-users@googlegroups.com References: <20251106151508.3872857-1-cedric.hombourger@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <20251106151508.3872857-1-cedric.hombourger@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: 8jB21aFQONyo Applied to next, thanks. Best regards, Zhihang On 11/6/25 16:15, 'Cedric Hombourger' via isar-users wrote: > The previous logic for conditionally adding the IMAGE variable to > CUSTOMIZATION_VARS suffered from a Bitbake variable expansion > timing issue. > > The original line `CUSTOMIZATION_VARS_IMAGE ?= "${IMAGE}"` would evaluate > the `${IMAGE}` variable too early in the parsing process. If `IMAGE` had > not yet been fully defined or resolved to its final value (e.g., > `isar-image-base`), `CUSTOMIZATION_VARS_IMAGE` would incorrectly store > the literal string `"${IMAGE}"`. > > Consequently, when `CUSTOMIZATION_VARS` was later appended using a > Python expression that retrieved `CUSTOMIZATION_VARS_IMAGE`, it would > receive this unexpanded literal string. This led to build failures and > errors such as: > > ERROR: ... Unable to get checksum for ... ${IMAGE} SRC_URI entry ... > > Introduce a new Bitbake override, `:customization-for-images`, which > is conditionally activated when `CUSTOMIZATION_FOR_IMAGES` is set (to > preserve the initial semantic of 9a2919be). The `IMAGE` variable is > then appended to `CUSTOMIZATION_VARS` specifically within this override > context: > > `CUSTOMIZATION_VARS:append:customization-for-images = " ${IMAGE}"` > > By associating the append operation with an override, the expansion is > deferred and ensures that `${IMAGE}` is properly resolved to its value > before being added to `CUSTOMIZATION_VARS`. > > Fixes: 9a2919be > Signed-off-by: Cedric Hombourger > --- > meta/classes/customization-base.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/customization-base.bbclass b/meta/classes/customization-base.bbclass > index 82cad67e..7603460b 100644 > --- a/meta/classes/customization-base.bbclass > +++ b/meta/classes/customization-base.bbclass > @@ -8,8 +8,8 @@ CUSTOMIZATIONS[doc] = "List of customization packages to be installed in images. > > CUSTOMIZATION_VARS ?= "${DISTRO} ${MACHINE}" > CUSTOMIZATION_VARS[doc] = "List of variables that should be added to customization package names." > -CUSTOMIZATION_VARS_IMAGE ?= "${IMAGE}" > -CUSTOMIZATION_VARS:append = " ${@d.getVar('CUSTOMIZATION_VARS_IMAGE') if d.getVar('CUSTOMIZATION_FOR_IMAGES').strip() else ''}" > +OVERRIDES:append = "${@ ':customization-for-images' if (d.getVar('CUSTOMIZATION_FOR_IMAGES') or '').strip() else '' }" > +CUSTOMIZATION_VARS:append:customization-for-images = " ${IMAGE}" > > CUSTOMIZATION_VARS_PREFIXED ?= "${DISTRO}" > CUSTOMIZATION_VARS_PREFIXED[doc] = "List of variables from CUSTOMIZATION_VARS that should be prefixed rather than suffixed to customization package names." -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/7cc53bda-e512-40a2-b05b-f3569991e857%40ilbers.de.