From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>,
isar-users@googlegroups.com
Subject: Re: [PATCH v4 2/3] meta/u-boot: Include libssl-dev only when building tools
Date: Mon, 22 Nov 2021 07:24:57 +0100 [thread overview]
Message-ID: <7db1e90b-c943-e686-be50-51b0372acec7@siemens.com> (raw)
In-Reply-To: <20211120063921.1588706-3-Vijaikumar_Kanagarajan@mentor.com>
On 20.11.21 07:39, Vijai Kumar K wrote:
> libssl-dev of the host architecture is needed only when you
> cross compile u-boot-tools.
>
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
> meta/recipes-bsp/u-boot/u-boot-custom.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> index 5e8a15b..4001f8c 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> @@ -42,7 +42,8 @@ python() {
> }
>
> DEBIAN_BUILD_DEPENDS ?= "bc, bison, flex, device-tree-compiler, git, libssl-dev:native"
> -DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if d.getVar('ISAR_CROSS_COMPILE') == '1' else ''}"
> +DEBIAN_BUILD_DEPENDS += "${@', libssl-dev' if (d.getVar('ISAR_CROSS_COMPILE') == '1' and \
> + bb.utils.contains('U_BOOT_BUILD_PROFILES', 'tools', 1, 0, d)) else ''}"
>
As written in the other thread: The cross-compile conditional is
practically redundant.
As this patch depends on the 2021.10 update, you should stick all
patches into the same series.
Jan
> TEMPLATE_FILES = "debian/control.tmpl"
> TEMPLATE_VARS += "MACHINE DEBIAN_BUILD_DEPENDS"
>
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-11-22 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 6:39 [PATCH v4 0/3] UBoot refactor Vijai Kumar K
2021-11-20 6:39 ` [PATCH v4 1/3] u-boot: Switch to use DEB_BUILD_PROFILES Vijai Kumar K
2021-11-20 6:39 ` [PATCH v4 2/3] meta/u-boot: Include libssl-dev only when building tools Vijai Kumar K
2021-11-22 6:24 ` Jan Kiszka [this message]
2021-11-22 6:38 ` vijai kumar
2021-11-20 6:39 ` [PATCH v4 3/3] meta-isar: u-boot: Migrate to U_BOOT_BUILD_PROFILES Vijai Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db1e90b-c943-e686-be50-51b0372acec7@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Vijaikumar_Kanagarajan@mentor.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox