public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: isar-users <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH] Adjust do_apt_fetch dependency to crossbuild
Date: Sat, 31 Aug 2019 12:38:22 +0200	[thread overview]
Message-ID: <7dcb4a94-e3fb-71a6-bb9b-4693222f9316@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

So far, do_apt_fetch has a hard-coded dependency on buildchroot-target.
But that is not accurate. In a crossbuild scenario, it rather depends on
buildchroot-host. Adjust that by updating the automatic dependency
setting of buildchroot.bbclass from do_prepare_build to do_apt_fetch.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/buildchroot.bbclass | 2 +-
 meta/classes/dpkg-base.bbclass   | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
index a87e144..64ac450 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -17,7 +17,7 @@ python __anonymous() {
         dep = "buildchroot-host:do_build"
         rootfs = d.getVar('BUILDCHROOT_HOST_DIR', True)

-    d.setVarFlag('do_prepare_build', 'depends', dep)
+    d.setVarFlag('do_apt_fetch', 'depends', dep)
     d.setVar('BUILDCHROOT_DIR', rootfs)
 }

diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index d50d565..4c6e02a 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -22,8 +22,6 @@ addtask patch after do_adjust_git before do_dpkg_build

 SRC_APT ?= ""

-do_apt_fetch[depends] = "buildchroot-target:do_build"
-
 do_apt_fetch() {
 	if [ -z "${@d.getVar("SRC_APT", True).strip()}" ]; then
 		exit
--

2.16.4


             reply	other threads:[~2019-08-31 10:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 10:38 Jan Kiszka [this message]
2019-09-12 13:49 ` Baurzhan Ismagulov
2019-09-13  6:22   ` Jan Kiszka
2019-09-16 20:46     ` Baurzhan Ismagulov
2019-09-16 20:58       ` Jan Kiszka
2019-09-16 21:19         ` Baurzhan Ismagulov
2019-09-16 21:37           ` Jan Kiszka
2019-09-17  8:51   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dcb4a94-e3fb-71a6-bb9b-4693222f9316@web.de \
    --to=jan.kiszka@web.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox