From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520199916203016192 X-Received: by 10.46.17.211 with SMTP id 80mr24439ljr.44.1518510248331; Tue, 13 Feb 2018 00:24:08 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.123.4 with SMTP id w4ls1515157lfc.6.gmail; Tue, 13 Feb 2018 00:24:07 -0800 (PST) X-Google-Smtp-Source: AH8x226XKjkktE5i/0kMGoTkNAAk6+Q28WyT1dQlFuemqm+647EoDPb5brvjyU2MwoNdhypTeOwC X-Received: by 10.25.0.140 with SMTP id 134mr30992lfa.9.1518510247666; Tue, 13 Feb 2018 00:24:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518510247; cv=none; d=google.com; s=arc-20160816; b=X2jIWt/GIfO/buePyFxsMKbBSIYexMU4IMlTtdvnGDZKwQE0kl4U9iDVqjVdROzyKC yK/YMuRsIPPSBFOKJ5Hy0nQchaJJTOQ/RbQ4DyycUpPBSN5fLa8XIiILVWXwJnJ76/Sz Yowv/PwVD8lSsAFi0SfHDVa4wvT6Q71AaksP+fQGY3jKq3/yap9tNixJJPUHOjQeHQgF qxsMHIU49mu6r30fedmlK+g+xBXw0kHJhwNS6VMjcl1MquwwhnB6h7xlDl4MGofrK+50 JwQ9VOX8fHZgSkitXo4S6diTpRyDA8EDAV6iBGX+irnGHbV8ig3TVhpXk/rrUL1O3Hgn Trlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=nSb0Fgf2WnaYPdXIQ5TcT3/h706q4wqkKB47DWJHLSM=; b=ib7+E5dbd/nu2WSUW4TAhKgRVrfd3IWf1Gh7gd2ZFGceOQgFFiUG/Ja20TaZLkzb2w WwlkmfaTEpHv7slBTrdqv+vUsYmcAFyAvHlkubC89gcVdl3W79UiQgTe9zeF+DQOgWSo 2fhI3borY5OiLjBPF3qPGGCdlMBZN3k/zBKaIZCU4WpCi+jENw/BjIzfwX0LYqY2Bch2 cegz7BHCmDaqgb1GrcUg9KSj/3u7+zUwQYIM4DU/nH5hLKTRXm8/RhG44u88uYnU01Hb 98PUtOH9KbaDVZ+CimhS8EO+Hw5gAe9wUWhTKd7cfoZA96bFtgDgD5LQeSPC+Nbm6OnW vF5w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id u10si575956lju.0.2018.02.13.00.24.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 00:24:07 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w1D8O6EP002267 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2018 09:24:06 +0100 Received: from [167.87.35.57] ([167.87.35.57]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w1D8O6VT013965; Tue, 13 Feb 2018 09:24:06 +0100 Subject: Re: [PATCH v4 5/8] Provide class for easy custom kernel builds To: Alexander Smirnov , isar-users References: <10f71292d5c06de6909594c891f2478334106135.1518362719.git.jan.kiszka@siemens.com> <5771c955-dec7-8347-123d-d4b3f08e751a@siemens.com> <946a22d8-1562-4f73-25f0-b36bccba35d7@ilbers.de> From: Jan Kiszka Message-ID: <7dcc235b-4b62-1e3a-74a9-23a252b605c8@siemens.com> Date: Tue, 13 Feb 2018 09:24:06 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <946a22d8-1562-4f73-25f0-b36bccba35d7@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: hhEZj2Hpf04I On 2018-02-13 09:19, Alexander Smirnov wrote: > > > On 02/13/2018 10:03 AM, Jan Kiszka wrote: >> On 2018-02-12 19:56, Alexander Smirnov wrote: >>> On 02/11/2018 06:25 PM, Jan Kiszka wrote: >>>> From: Jan Kiszka >>>> >>>> With this class, it becomes almost trivial to replace the distro kernel >>>> with a custom build. You just need to inherit linux-kernel, specify the >>>> source URI, define via S where the source is unpacked to and provide a >>>> defconfig. To switch to a custom kernel recipe, >>>> PREFERRED_PROVIDER_virtual/kernel has to be adjusted in local.conf or >>>> the distro conf. >>>> >>>> The approach works internally by first running "make deb-pkg" on the >>>> kernel and the repackages the output to make the binary linux-image and >>>> linux-header debs act as replacement of their distro packages. This >>>> results in a suboptimal technical implementation which may >>>> eventually be >>>> replaced by an isar-implemented deb-pkg build process. However, this is >>>> not expected to affect the user-visible interface of this class. >>>> >>>> Signed-off-by: Jan Kiszka >>>> --- >>>>    meta/classes/linux-kernel.bbclass | 98 >>>> +++++++++++++++++++++++++++++++++++++++ >>>>    1 file changed, 98 insertions(+) >>>>    create mode 100644 meta/classes/linux-kernel.bbclass >>>> >>>> diff --git a/meta/classes/linux-kernel.bbclass >>>> b/meta/classes/linux-kernel.bbclass >>>> new file mode 100644 >>>> index 0000000..5f4df3f >>>> --- /dev/null >>>> +++ b/meta/classes/linux-kernel.bbclass >>>> @@ -0,0 +1,98 @@ >>>> +# Custom kernel build >>>> +# >>>> +# This software is a part of ISAR. >>>> +# Copyright (c) Siemens AG, 2018 >>>> +# >>>> +# SPDX-License-Identifier: MIT >>>> + >>>> +DESCRIPTION ?= "Custom kernel" >>>> +PROVIDES = "virtual/kernel" >>>> + >>>> +inherit dpkg-base >>>> + >>>> +KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, >>>> kmod, linux-base (>= 4.3~)" >>>> +KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1, gcc" >>>> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc" >>>> + >>>> +REPACK_DIR = "${PP}/repack" >>>> +REPACK_LINUX_IMAGE_DIR = "${REPACK_DIR}/linux-image" >>>> +REPACK_LINUX_HEADERS_DIR = "${REPACK_DIR}/linux-headers" >>>> + >>>> +dpkg_runbuild() { >>>> +    E="${@ bb.utils.export_proxies(d)}" >>>> +    sudo -E chroot ${BUILDCHROOT_DIR} sh -c ' >>>> +        set -e >>>> + >>>> +        apt-get install -y -o Debug::pkgProblemResolver=yes \ >>>> +            --no-install-recommends ${KBUILD_DEPENDS} >>>> + >>>> +        cd ${PP}/${S} >>>> +        cp ../defconfig .config >>>> +        make olddefconfig >>>> + >>>> +        make -j ${@bb.utils.cpu_count() * 2} deb-pkg >>>> + >>>> +        rm -rf ${REPACK_DIR} >>>> +        mkdir -p ${REPACK_DIR} >>>> +        mkdir -p ${REPACK_LINUX_IMAGE_DIR} >>>> +        mkdir -p ${REPACK_LINUX_HEADERS_DIR} >>>> + >>>> +        cd ${PP} >>>> +        tar xzf linux-${PV}_${PV}-1.debian.tar.gz -C ${REPACK_DIR} >>>> +        dpkg-deb -R linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ >>>> +            ${REPACK_LINUX_IMAGE_DIR} >>>> +        dpkg-deb -R linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb \ >>>> +            ${REPACK_LINUX_HEADERS_DIR} >>>> + >>>> +        dpkg-gencontrol -crepack/debian/control \ >>>> +            -lrepack/debian/changelog \ >>>> +            -frepack/debian/files \ >>>> +            -plinux-image-${PV} \ >>>> +            -P${REPACK_LINUX_IMAGE_DIR} \ >>>> +            -DPackage="linux-image-${KERNEL_ARCH}" \ >>>> +            -DSection=kernel \ >>>> +            -DPriority=required \ >>>> +            -DProvides="${PN}" \ >>>> +            -DDepends="${KERNEL_DEBIAN_DEPENDS}" >>>> + >>>> +        # Add Debian-like link installation to postinst >>>> +        touch >>>> ${REPACK_LINUX_IMAGE_DIR}/lib/modules/${PV}/.fresh-install >>>> +        sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postinst \ >>>> +            -e "/^set -e$/a\\ >>>> +\\ >>>> +if [ -f /lib/modules/${PV}/.fresh-install ]; then\\ >>>> +    change=install\\ >>>> +else\\ >>>> +    change=upgrade\\ >>>> +fi\\ >>>> +linux-update-symlinks \$change ${PV} /boot/vmlinuz-${PV}\\ >>>> +rm -f /lib/modules/${PV}/.fresh-install" >>>> + >>>> +        # Add Debian-like link removal to postrm >>>> +        sed -i ${REPACK_LINUX_IMAGE_DIR}/DEBIAN/postrm \ >>>> +            -e "/^set -e$/a\\ >>>> +\\ >>>> +rm -f /lib/modules/${PV}/.fresh-install\\ >>>> +\\ >>>> +if [ \"\$1\" != upgrade ] && command -v linux-update-symlinks >>>>> /dev/null; then\\ >>>> +    linux-update-symlinks remove ${PV}  /boot/vmlinuz-${PV}\\ >>>> +fi" >>>> + >>>> +        dpkg-gencontrol -crepack/debian/control \ >>>> +            -lrepack/debian/changelog \ >>>> +            -frepack/debian/files \ >>>> +            -plinux-headers-${PV} \ >>>> +            -P${REPACK_LINUX_HEADERS_DIR} \ >>>> +            -Vkernel:debarch="${KERNEL_ARCH}" \ >>>> +            -DPackage="linux-headers-${KERNEL_ARCH}" \ >>>> +            -DSection=kernel \ >>>> +            -DDepends="${KERNEL_HEADERS_DEBIAN_DEPENDS}" >>>> + >>>> +        dpkg-deb -b ${REPACK_LINUX_IMAGE_DIR} \ >>>> +            linux-image-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb >>>> +        rm -f linux-image-${PV}_${PV}-1_${KERNEL_ARCH}.deb >>>> +        dpkg-deb -b ${REPACK_LINUX_HEADERS_DIR} \ >>>> +            linux-headers-${KERNEL_ARCH}_${PV}-1_${KERNEL_ARCH}.deb >>>> +        rm -f linux-headers-${PV}_${PV}-1_${KERNEL_ARCH}.deb >>>> +    ' >>>> +} >>>> >>> >>> What is the benefit of having this script in the class? I see that we >>> have separate files for: >>> >>>   - buildchroot >>>   - kernel modules >>> >>> Why this chroot script should be a part of bitbake class? This makes >>> debugging much more complicated, because I have no possibility to run >>> this script manually from buildchroot (like I could do with build.sh) >> >> I played with it, and it "just" took 6 exports to set up the interface >> to script-based build. That will likely not be convenient for debugging >> as well (and I never had to call things manually that way, I got all >> information from logs), but I can keep that pattern. Will also mean: >> back to an include, rather than using a class (no big issue). >> >>> >>> Also formatting style looks nasty here. >> >> That's not going to change unless you suggest some alternative for the >> sed-based code injection into postinst/postrm. > > Just for sure that I understand the issue, why no sed injections? You > already do this for kernel module by "sedding" control file. The sed code is visually the most ugliest part of my build script. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux