Re: [PATCH v5 18/21] isar-sstate: adopt sstate maintenance script

[Anton Mikanovich <amikan@ilbers.de>]

03.12.2022 07:57, Moessbauer, Felix wrote:
> Hi, I guess we need a similar logic for the analyze subcommand? There,
> I see a lot of these messages (even before the first "checking local
> item" output):
>
> zstd: /*stdin*\: unsupported format
>
> Felix
Hello Felix, as Adriaan already mentioned this logic is implemented inside
bitbake's siggen.py, so we can't add any check and also can't get rid of 
zstd
error. The only change possible is adding some other message for compression
exception, something like:

diff --git a/scripts/isar-sstate b/scripts/isar-sstate
index 53d0541..d459011 100755
--- a/scripts/isar-sstate
+++ b/scripts/isar-sstate
@@ -789,7 +789,9 @@ def sstate_analyze(source, target, **kwargs):
              remote_file = target.download(t.path)
              try:
                  out = compare_sigfiles(remote_file, local_file, 
recursecb, color=True)
-            except:
+            except bb.compress._pipecompress.CompressionError:
+                out = ["Unsupported sstate cache compression."]
+            else:
                  out = ["Failed to compare signatures."]
              source.release(local_file)
              target.release(remote_file)

But this will not give the user any information more then original zstd 
error.

Anyway moving sstate to zstd compression should probably be added to 
changelog.