From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6729358150130991104 X-Received: by 2002:a5d:4284:: with SMTP id k4mr21077608wrq.6.1566808804843; Mon, 26 Aug 2019 01:40:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cc01:: with SMTP id f1ls5983698wmh.4.canary-gmail; Mon, 26 Aug 2019 01:40:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGlhdPPZG3VH584FUa0VPdAvTRJn9Gp7Yv/M2MkCovo2SzwFvyMLbKVRFNpG+GS+2SErI0 X-Received: by 2002:a7b:cd17:: with SMTP id f23mr20744568wmj.177.1566808804376; Mon, 26 Aug 2019 01:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566808804; cv=none; d=google.com; s=arc-20160816; b=vJ8MGlXs2H3+5yccfmsf7b95dahyyQiCzqlTgYHLJRgDd+OFzHloZTLxVU5mpK7+Jp 02R1oxGwkTEkJuyKxlFAh/9dZJfZbuDVUkOeIyRMDndx/MoMSvRL0q1GCuMceBockEvR n33QdC7BII0Vr/7uiOz2XQ2X2qfj3GhGF02q3cEhQnRku+nXRbv6WY5UtJePRgDrbni7 iYeLsL3uS2+aNFnvNjppFgBaC/YOR8hCX3uPMaWqngIqrGAp8YUsjAqOgtzmKinB44IN L/m917jsEhUQUi5DEJkimFk8EG7awKqPSv9aUHjvpDar+ncKYhmn8MG22cS59EL7O3rP s/zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=DvzyK/NXlD71AT10ErdJS5tIzbNTmmfhV2i26Hsyc2s=; b=T/hYkxnKGsNqQGZWdCG/NTInv43EBq7j3te3bBvXR1ht+0GkT47cUUL+apdJIOKXC0 ulIcr8UNISlWSNj/rg09/RPpE3MpLKBwwCR3oe8ihc6Pp/NAm0xjv8bqb3R1ZEJxxH2+ IALtczLmKfkAgRujyXlcxR1ZNgY+XRoC5A7ppnukAQqAuIzLPvQbM/Rh/KDHtj/lAqfM MTnicU0Yn9jOT9l75y9IDziIjzKqD+Zuv3NDWkH3YKAakD+aXG2BIkdhWLvg3/zlI5xH vYVnsLkhLyeHwcDd4veY2XGWQF4GxZ7F0cF0cs4WZtMsMpvfRBzWVraPM7OnE8QpSQJp lkEg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id p67si701549wme.2.2019.08.26.01.40.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 01:40:04 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7Q8e4lx018680 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Aug 2019 10:40:04 +0200 Received: from [139.22.35.99] ([139.22.35.99]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7Q8e2tL024683; Mon, 26 Aug 2019 10:40:03 +0200 Subject: Re: [PATCH 07/26] base: Clean up build task To: Henning Schild Cc: isar-users References: <20190826101816.187e98e5@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <7f241a10-dec3-e75d-bb2a-03d3acace47c@siemens.com> Date: Mon, 26 Aug 2019 10:40:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190826101816.187e98e5@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: RVlldYMqXl7S On 26.08.19 10:30, Henning Schild wrote: > Am Mon, 26 Aug 2019 08:26:08 +0200 > schrieb "[ext] Jan Kiszka" : > >> From: Jan Kiszka >> >> This is now an empty one that should no longer be executed. Align with >> OE in this regard. >> >> Signed-off-by: Jan Kiszka >> --- >> meta/classes/base.bbclass | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index 1d2852a..8c7b021 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -181,14 +181,12 @@ python do_unpack() { >> >> addtask unpack after do_fetch before do_build >> >> -addtask build >> -do_build[dirs] = "${TOPDIR}" >> -python base_do_build () { >> - bb.note("The included, default BB base.bbclass does not define a >> useful default task.") >> - bb.note("Try running the 'listtasks' task against a .bb to see >> what tasks are defined.") +do_build[noexec] = "1" >> +do_build () { >> + : >> } > > This actually once came from bitbake/classes/base.bbclass > > You might want to compare with that. I compared to OE and took its version. The bitbake one is a template that makes no sense here. > > the default does not have noexec but it does have nostamp > >> -EXPORT_FUNCTIONS do_build >> +addtask build > > The default bitbake one has both of these lines. Again, OE is closer to our use case. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux