Re: [PATCH 1/1] build.sh: eliminate user prompts from mk-build-deps

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-01-25 21:36, Cedric_Hombourger@mentor.com wrote:
> From: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> 
> commit 498b128 caused build dependencies to be installed via mk-build-deps.
> 
> The tool may ask the user to confirm installation of the dependencies but
> would fail when called from bitbake (no stdin). Override the default install
> command to add the -y switch to the apt-get command it uses.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/recipes-devtools/buildchroot/files/build.sh | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh b/meta/recipes-devtools/buildchroot/files/build.sh
> index 975252e..760ebc8 100644
> --- a/meta/recipes-devtools/buildchroot/files/build.sh
> +++ b/meta/recipes-devtools/buildchroot/files/build.sh
> @@ -6,8 +6,11 @@
>  # Go to build directory
>  cd $1
>  
> +# Install command to be used by mk-build-deps (use -y for non-interactive)
> +install_cmd="apt-get -o Debug::pkgProblemResolver=yes --no-install-recommends -y"

This sneaks in --no-install-recommends, which has a value, but it should
be separated out or at least mentioned.

Also, Debug::pkgProblemResolver=yes is worth mentioning, even when it
doesn't change the outcome of the installation.

Jan

> +
>  # Install all build deps
> -mk-build-deps -i -r debian/control
> +mk-build-deps -t "${install_cmd}" -i -r debian/control
>  
>  # If autotools files have been created, update their timestamp to
>  # prevent them from being regenerated
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux