From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 07 Oct 2025 16:57:47 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qt1-f191.google.com (mail-qt1-f191.google.com [209.85.160.191]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 597Evj0o002469 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 7 Oct 2025 16:57:46 +0200 Received: by mail-qt1-f191.google.com with SMTP id d75a77b69052e-4e5739a388bsf141379871cf.2 for ; Tue, 07 Oct 2025 07:57:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1759849060; cv=pass; d=google.com; s=arc-20240605; b=FuZwVL0803B5xHKojMkaKRCkhGlg8To/Sb9XUHq3qL6h8b9RI/GvltqM5D6AKAETeb 4hzxbuNSutSfftgsBsSK3I8FFvgl53e+wCCurRvZ1W8M7yLuzoH5Z0dDgSgoAKiNlYDt jrSsza/zMRJRYhzSxwl5YNhW1XLVorpq2el1k/rqsfkTJsw5nfkJ2IY1TOhc2B+2v9Ch LuZoHxoaQA9flMiEXQJgR4cRltUpRv66fIChgTcqOVoL0ZVClnGWftgCGh1rDMjbTScS x1m73AJ/UDcsr4BduqGak2Du4QT3xHape8UJ788Smo+wFeu014SyaSgRoi4gYNWABL6A DAYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=TWtZIrP3gvYm6fJqRIacrk/tqQndOmZxHF3YIvLOz2E=; fh=V3S+YR3eFRJ2EJ7dVbvLT8eZCduu/PNIof2+AA/Wa1o=; b=jtke1jStxJFkb9+WAQ7DDqNE01UW4p/eoj3zuqzSL8xhFH7QhJ44apNdgeDvkvxnyq UBTV8WL8BvbUENlOe7lI7xYXpJL/8/5SXDY20iD6Rwp6aXxeX5IDbP0W1F60PdbO1Ke5 vMlRMHm30eevRKOCA2Rs0gRzl9op10pK2pW9hrvTSgYZ9EvkclUarm9qRWn7H5KwnBAz mAvdKF83hS1TJTQ69dztiNbbtDMvFfVJwMBfbCb3Q33H8oseIcuLkdx23JgxgmSFHJFW rpzbFNYexjoGF4jHF5oO4VZxcsynuJUI5gL4C1mFLvaXG0Cgcqb9TiZqdB4L00GKscOi Kj0w==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=TGf8qmJv; spf=pass (google.com: domain of fm-68982-20251007145727a4dc7e0cae00020726-xoei3n@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-68982-20251007145727a4dc7e0cae00020726-XoeI3n@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1759849060; x=1760453860; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to; bh=TWtZIrP3gvYm6fJqRIacrk/tqQndOmZxHF3YIvLOz2E=; b=FjrCwyEbNtCLKu0hv2fLNRpcVPmWyfnUFbCYDyziABhL2n2oB1EvzcVF6y4qYU2koD 0fXvf7j6jsdZpygBwpRcFYjwqUjFLe2IITSYnH91CweCX2aV47H660Q1M3qmfCAuKlmA 6uHBSUqAKKANuj29S8ECTnEdKVtBqil7BYBATCM+gfv29k4xwHmIIRuPXAIe0jhdLGLy 8EovRZjMa+VK8TONI1bGF1dmoojvToxU7xnpxKh6ZzBPHmxT+KUaRvOx7e4H4KnF48ns tozLW04HeC//3ZhgjkiI2Ehczp8XY2LVvcbU9CEYJlONxjiuYzf82ipnqkOSzKsRICcG FYWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759849060; x=1760453860; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TWtZIrP3gvYm6fJqRIacrk/tqQndOmZxHF3YIvLOz2E=; b=XuOQkaA6eGjskPG6yx7BNhcMX+OvRXIs7XbIWZ//lf90C9yv78mQMGHiml+PpzsbNe sJTM+4tmPuy7Sjk5i0W3W8ZAwHgZdHuDzTT6t18z2/5zbIDdjP+01tTigujvhpqcYas1 w9fUdn0yvY+E4akhXwH8/jUi0t6j8hawNkaprLsE8TVM7U2n64ZNBAykh0NXGrX6OLgn fd2nW4hnCWn7G7mJV2bu44GuRRgNdhy+X4MHTocaDnpIj8IspCHWjbOzO842LvQIBQz8 UjnSOh3kc38zwzGnwO0Z6utFcZOlBiIcuaB36prKNtyam5ato8SH38KqAHfulS04IAgc lKHQ== X-Forwarded-Encrypted: i=2; AJvYcCUTvXleuQ2c6/myICyusv3kDEcWprjJpL3d9Riu2be3o6S5guxYnU33pCZSvXSRnOLQm/0U@ilbers.de X-Gm-Message-State: AOJu0Yy6fQoIJofkKZIAvy9w7h4Ju2D6UZHnopilLGk3//h/7G0Eccfq lXeT8XDuwaTui8pHmIYzqgs77MVKnZkAYKrDZxFtXkq6tOCDNd9elG9k X-Google-Smtp-Source: AGHT+IESgJ/jSOXXhtT6ik5NZtlQKuLgvR/5AyitUjQKorU5Q3BFMAMpVd17NcKZ3Y6TIhlq1/ZCuA== X-Received: by 2002:a05:622a:998:b0:4db:9c75:abad with SMTP id d75a77b69052e-4e576b307c5mr203166371cf.74.1759849059751; Tue, 07 Oct 2025 07:57:39 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ARHlJd5gS1zP3XZqIe+E+06MgPOr8RxOx6dyiu1VEP84oWnE7Q==" Received: by 2002:a05:622a:831a:b0:4b0:889b:5698 with SMTP id d75a77b69052e-4e557dc1ddbls94328311cf.0.-pod-prod-03-us; Tue, 07 Oct 2025 07:57:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU34wYc4Fp834bVqTHIAwOPncPNJDGQxBcPBPnO4/RK4F0xNbWoqfaFg5p7IbT6DD6Pqoo9qfaUb0JQ@googlegroups.com X-Received: by 2002:a05:622a:302:b0:4e0:3486:8873 with SMTP id d75a77b69052e-4e576b3074amr223314161cf.75.1759849058537; Tue, 07 Oct 2025 07:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1759849058; cv=none; d=google.com; s=arc-20240605; b=b81ECq5xCOlMLzbFTooneZgFdlyeQ9mF7jIFja9wghhSXJRbqjWA7xoaygN0xAKJ72 0/MPQTqaG9SbQS4sP5NtzXzFDQmq96TzlI29acwq5hECzJTA9ZvhnrLG/W1vsnszxMDW sUVcsDflqrbuhjxeAkIffTKMHCzYkfO9oedsEdDnxo/eqSn4QkogwArTMcCEEFf3xnXd N+BFD/OrWonkjQXXy1pKAP1UZ72vqXaPqbq3Zavaj9BKyZf1DYtkOWWbsXQO/c7p+kMd Ncm3yC3qlu/T6gpwAS7Th4aZGntrhWMEXZZzVOIKWQFeY7ZLIYb7V8Y1qnylPb43X8a+ svjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=wScNAd9QF3bpcL++q4HG0HnG0DKvRswW9AK6HItiuyM=; fh=DNzOkRTP+VmXigk6tq0c9cfaYR8sXAQWPClhtOCh1pM=; b=ccmMv+ZUnaxWenNGYWNryBE+BB12/lE2TBjzojNJWoHp65H+3WYAzxyjuZkrkwMWuF WlBjqyb9ck7f/mtb9q+KKj9/xwN2e91AKI8NNRGZ5IeotNXZiy2Jsi1UH1PrfqkjziOC AODekwdJ8Fg8q3vWBDLTGyW4w+PvUiLNjt2Tv6oxXUBCYPo2bRruLfqnxDtuyhpJquhn iVfvB/mZkWwg5etTYEGuupJk6JeTNU2FmMBKPBdC6LEVu99nrSZD3VmFJsMw3BCrRbA1 BZFK62E4QE5Cyuk01rzGSdWDZwizg65Px0ceeEcTQ/dffOxDnVK3/wJDJJm08IQjCvmj /5Wg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=TGf8qmJv; spf=pass (google.com: domain of fm-68982-20251007145727a4dc7e0cae00020726-xoei3n@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-68982-20251007145727a4dc7e0cae00020726-XoeI3n@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-65-227.siemens.flowmailer.net (mta-65-227.siemens.flowmailer.net. [185.136.65.227]) by gmr-mx.google.com with ESMTPS id d75a77b69052e-4e6ea6fe487si28801cf.0.2025.10.07.07.57.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Oct 2025 07:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-68982-20251007145727a4dc7e0cae00020726-xoei3n@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) client-ip=185.136.65.227; Received: by mta-65-227.siemens.flowmailer.net with ESMTPSA id 20251007145727a4dc7e0cae00020726 for ; Tue, 07 Oct 2025 16:57:36 +0200 Message-ID: <808530d1119465f195203b70112bf6bc33dc8209.camel@siemens.com> Subject: Re: [PATCH 1/2] fix: lazy expand ISAR_APT_SNAPSHOT_DATE[flag] From: "'Florian Bezdeka' via isar-users" To: "Moessbauer, Felix (FT RPD CED OES-DE)" , "isar-users@googlegroups.com" Cc: "Heinisch, Alexander (FT RPD CED SES-AT)" Date: Tue, 07 Oct 2025 16:57:26 +0200 In-Reply-To: References: <20251006141227.1017941-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-Original-Sender: florian.bezdeka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm2 header.b=TGf8qmJv; spf=pass (google.com: domain of fm-68982-20251007145727a4dc7e0cae00020726-xoei3n@rts-flowmailer.siemens.com designates 185.136.65.227 as permitted sender) smtp.mailfrom=fm-68982-20251007145727a4dc7e0cae00020726-XoeI3n@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Florian Bezdeka Reply-To: Florian Bezdeka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: scRinvHEhA7r On Tue, 2025-10-07 at 14:39 +0000, Moessbauer, Felix (FT RPD CED OES- DE) wrote: > On Tue, 2025-10-07 at 12:39 +0200, Florian Bezdeka wrote: > > On Mon, 2025-10-06 at 16:12 +0200, 'Felix Moessbauer' via isar-users > > wrote: > > > The ISAR_APT_SNAPSHOT_DATE variable controls the timestamp of the > > > sources on the snapshot mirror. This variable further is a shortcut for > > > ISAR_APT_SNAPSHOT_TIMESTAMP that avoids letting the user compute a unix > > > timestamp of the desired date. However, while > > > ISAR_APT_SNAPSHOT_TIMESTAMP is always available via bitbake conf, the > > > _DATE variant is only available after computing it in do_bootstrap. > > > > > > In 394e954, support was added to just set the timestamp / date for the > > > security distribution by extending the _TIMESTAMP and _DATE variables > > ^^^^^^^^^^^^^^^^^^^^ > > Wording: distribution -> repository? > > > > According to https://wiki.debian.org/SourcesList this seems the right > > term here. > > But there they also state: > > Apt downloads and installs packages from one or more software > repositories (sometimes called suites, distributions, versions, or even > sources). Examples: Distribution: Debian Suites: trixie trixie-updates Components: main non-free-firmware Repository: The package feed for one specific combination of the definitions above. Wording is important here as this bug might trigger security implications. We might not have build what the user expected. So we have to clearly communicate what the problem was - by using the right wording. > > As we currently call this dist / distribution in the source code, I > prefer to also use that term in the commit message. > > If a debian policy states the name, I would change it, but just because > it is mentioned in the wiki it not enough to require the change. > > Felix > > > > > > with a flag. However, the logic that evaluates the variable in > > > DISTRO_APT_SNAPSHOT_PREMIRROR is defined in the distro conf, which is > > > parsed earlier than the logic in do_bootstrap. By that, depending on the > > > context the variable might not be set leading to incorrect substitutions > > > of the apt-sources. This has not been observed in actual images, but in > > > the devshell and when printing the variable with bitbake. > > > > > > Anyways, the value of the variable should not depend on the parsing > > > order. To fix this, we now do not expand the variable until using it. > > > > Agree. > > > > > > > > Fixes: 394e9540 ("snapshots: add option to use separate timestamp ...") > > > Signed-off-by: Felix Moessbauer > > > --- > > > meta/conf/distro/debian-common.conf | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf > > > index 8da17d6f..92daddc3 100644 > > > --- a/meta/conf/distro/debian-common.conf > > > +++ b/meta/conf/distro/debian-common.conf > > > @@ -45,6 +45,6 @@ DISTRO_BOOTSTRAP_BASE_PACKAGES:append:bullseye = " usrmerge" > > > > > > # snapshot mirror for reproducible builds > > > DISTRO_APT_SNAPSHOT_PREMIRROR ??= " \ > > > - deb.debian.org/(debian-security)/? snapshot.debian.org/archive/\1/${@d.getVarFlag('ISAR_APT_SNAPSHOT_DATE', 'security')}\n \ > > > + deb.debian.org/(debian-security)/? snapshot.debian.org/archive/\1/${@d.getVarFlag('ISAR_APT_SNAPSHOT_DATE', 'security', expand=False)}\n \ > > > deb.debian.org/(.*)/? snapshot.debian.org/archive/\1/${ISAR_APT_SNAPSHOT_DATE}\n \ > > > " > > > -- > > > 2.51.0 > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "isar-users" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. > > > To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251006141227.1017941-1-felix.moessbauer%40siemens.com. > > -- > Siemens AG > Linux Expert Center > Friedrich-Ludwig-Bauer-Str. 3 > 85748 Garching, Germany -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/808530d1119465f195203b70112bf6bc33dc8209.camel%40siemens.com.