Re: [PATCH] meta: Drop lazy and recursive unmounts

["'Florian Bezdeka' via isar-users" <isar-users@googlegroups.com>]

On Thu, 2024-08-29 at 12:26 +0300, Anton Mikanovich wrote:
> 28/08/2024 16:05, Florian Bezdeka wrote:
> > Hi all,
> > 
> > I'm not 100% sure, but it seems I'm facing some problems with this
> > patch. I know about the situation that we sporadically saw some
> > mounting issues and that patch tries to expose such issues.
> > 
> > At least my issue seems to reproduce to 100%...
> > 
> > See below...
> > 
> > On Wed, 2024-06-19 at 13:41 +0300, Anton Mikanovich wrote:
> > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > > index faf22a50..6bc667e7 100644
> > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> > > @@ -341,7 +341,7 @@ do_bootstrap() {
> > >               echo "deb-src ${line}" >>  "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list"
> > >   
> > >               mkdir -p ${ROOTFSDIR}/base-apt
> > > -            mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt
> > > +            mount -o bind,private "${REPO_BASE_DIR}" "${ROOTFSDIR}/base-apt"
> > >           else
> > >               install -v -m644 "${APTSRCS}" \
> > >                                "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list"
> > > @@ -378,10 +378,10 @@ do_bootstrap() {
> > >   
> > >           # update APT
> > >           mount -o bind,private /dev ${ROOTFSDIR}/dev
> > That means that we mount /dev from "the host" into the rootfs/chroot
> > environment, right? "Submounts included", no?
> > 
> > I'm facing the following error with that. The isar build is executed
> > inside a container / pod running on a k8s cluster.
> > 
> > Inside the container the following steps are executed:
> > 
> > build-bookworm:
> >    script:
> >      - kas build <path-to-kas-file>
> >      - sudo rm -rf build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target
> > 
> > The rm command triggers the following errors:
> > 
> > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/shm': Device or resource busy
> > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/termination-log': Device or resource busy
> > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/mqueue': Device or resource busy
> > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/pts': Device or resource busy
> > 
> > My assumption is that isar is not cleaning up all mounts. I think the
> > interesting part is about /dev/termination-log.
> > That device is mounted into the pod by the k8s infrastructure.
> > 
> > I think we should never mount that into the chroot, or make sure it is
> > properly unmounted again...
> > 
> > Any thoughts on that? Any additional information needed?
> > 
> > Florian
> 
> Hello Florian,
> 
> The line you are pointing to is inside isar-bootstrap preparations, 
> while your
> error is pointing to busy mountpoints in sbuild-chroot, managed by
> rootfs.bbclass.
> Anyway private mount private mount does not forward or receive
> propagations. It means no external submounts will be mounted inside 
> rootfs and
> no Isar mounts will be mounted to external /dev.
> Can you check which mountpoints are left after the build (before rm)?

I think this is the relevant line from "mount":

tmpfs on /builds/<project>/build/tmp/work/debian-bookworm-amd64/sbuild-
chroot-target/1.0-r0/rootfs/dev type tmpfs
(rw,nosuid,size=65536k,mode=755,inode64)

Florian

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/8086840c9b7bcf8dbcd6d3141d493c87f9e6d5c8.camel%40siemens.com.