From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 29 Aug 2024 14:26:50 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-ot1-f61.google.com (mail-ot1-f61.google.com [209.85.210.61]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 47TCQnja002036 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Aug 2024 14:26:50 +0200 Received: by mail-ot1-f61.google.com with SMTP id 46e09a7af769-70f626c6fe3sf399779a34.3 for ; Thu, 29 Aug 2024 05:26:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1724934403; cv=pass; d=google.com; s=arc-20240605; b=QvkJxz0WWded6QiwyO32oSnk8VckR7VToEYOzha8/wVDBXC2hhZduWdykF3WvNsiPf 7SGj839uZnIHywXoVp5XZX/hNKyseWN3ih/aXzZEBw0/BonmNHTvRqnkKq4+5ZW6WW1I ewpccvhF1hxBSDaVKJHmOPj1SxAPDrHVGn4vVsNrGAGRKZveQk+kwUzSVwvsWAJKT40W 9R9vJYnFH11c3bDTff9u6f/A/l7etQ1XCJqMPtS5xRLCFULVVLNaXDeX/cVquWQF9P6H GytuvZSxcuaOHnR/duvtqIRqX9KQU/iozzKfUwDA2Z8Ja2G5wpg8v8dCUHPUq6CDhKdp lGHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:feedback-id:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=6sSdNvWYdxSolhWlvW3ieTgMIVk6hpSmMYqFkVuQg6U=; fh=D0JSOZfdjaMenalwimedhq92ih31hI4mrTwjNqy9qog=; b=ECjJrkGyVdg1dnixcDf+4PK2QwVaehVXL+vMZVlWVK5rPz0UViohU6mDTDPl/RVm5I WPYNPH6RfIQe6SwV3Q9kSLNqOED4M93ejBO70uvq78AlbU4JmyRPDpkDpADsSkHViHT/ T3Oyw5ccv+qBqBunuWaNYz9UgGtqHMeW9mFTqy20obqzuAIDHSam+XD4Ch+zSKiXJCRW EDnGd+q3jPuf5PYtdS8ly77X+WIh2PcBGA8V3HraYQIcD8M3sYRdsDWslFW+ydrpIwN7 22otsRNEpZWXF0dUfLtKSAzeqz6yqxuElvDp/zseukmohIVFtF8FwaT6et5M8NXZmvsN o5Tg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=cFfB55uw; spf=pass (google.com: domain of fm-68982-20240829122640f7036cfec99089273f-kuryl6@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-20240829122640f7036cfec99089273f-KuRYL6@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1724934403; x=1725539203; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to; bh=6sSdNvWYdxSolhWlvW3ieTgMIVk6hpSmMYqFkVuQg6U=; b=pEF934cCQlDAA1FYwT77jyiEH7lc6XUmbq/wJRfm7lwU5IjQF2A8jWlHU5CIFcGMA0 qzrl9RAYPWRIEtKG3WAb1BxX/7Ei0Pr2WaWQbukvLx99sF5Al2oLFH15G9aiFxS8i9HW KivIH/I8strx7tMPTAJVq3YjFEM1IgSfEx4SKAS/TQ44MijzzC0sKirLoCQ7A9WBCRJq qY8lVaG+r01nlCZbOJfRRjGdhbCeicLhVHcqNF0BM8pvRD9yrs9WI839SHhWx0YI/xGw 9EBGHC09NqI31Fsz5nxiAky7mYe28NIZXphlA7pD+oy4eEsJq9SoQfPT7eW9RNpd8ylC JrQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724934403; x=1725539203; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-authentication-results:x-original-sender:feedback-id :mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:x-beenthere:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6sSdNvWYdxSolhWlvW3ieTgMIVk6hpSmMYqFkVuQg6U=; b=gPRdU/x4ybzEodt5KUaWJPxvUll9sSJXHgCfnHDy/rD785oKjF86NzZKufW+06HWq5 bZg6W7S11zmn4kxZfZMHmk5VhOxbxFFlEfu5UadfX8Nut31hPC4TsZ21wo/eKkvvoJJY m0jbvTIz3jxr5oKJwEj0E3tSA1wR7O5QVyoie1joZhC8kfvHf7/+qNkXDSIsFtBOClma kFPjnZ3fwt79J5f6nWEn9En4/6gOG7C5wb/fUIb1lO7p+aXEr2rAZDdSj7NQwwgbwd9R 3bXgbdSo1AzSrCcskYgp5h1d3417qhzptVP9+HlafQnNcNh7CezZkcLBoTxvMLy256MY lBtQ== X-Forwarded-Encrypted: i=2; AJvYcCUllAu9uRz5oOyEBM/e3WRD3UwE0e3VtpVQeghAIBlcV9BWex778w3B95uTAMcUwbVYShiX@ilbers.de X-Gm-Message-State: AOJu0YwmvbqW0EVwnfGiOhS8VXOm7nu7yGmytnvtsigqdNkzFeVxBh3T 0XwbPBcXISHZ+Agq6o8RQZzKxfXQTqw5rSqXNucoNhICM0jR1Cke X-Google-Smtp-Source: AGHT+IFH8SECx0HgXO7jvmjAgfucYeas3cwVv2MCo6fy6oPXxZDNBWIDDUkl2OjgjCUXP81rK7oPRQ== X-Received: by 2002:a05:6830:700d:b0:703:5e45:f991 with SMTP id 46e09a7af769-70f5c487021mr3403636a34.31.1724934403097; Thu, 29 Aug 2024 05:26:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6870:6c07:b0:25e:2748:3ffa with SMTP id 586e51a60fabf-2778f053563ls1134095fac.0.-pod-prod-06-us; Thu, 29 Aug 2024 05:26:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUxq4P/VYeU7nCdV4f1quEvciyXeKD3fxDecPqpA3rO8Z2+2gBZd9AIbwc7XPG0AwrYeL8HgDYiokmH@googlegroups.com X-Received: by 2002:a05:6808:384a:b0:3d6:3050:7caa with SMTP id 5614622812f47-3df05afed36mr3346888b6e.0.1724934402248; Thu, 29 Aug 2024 05:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724934402; cv=none; d=google.com; s=arc-20240605; b=ckSrhtFTGvXjvUysgb0ue2HIWCAOVpOWNu5gDPm3x3bLRcIshb9yoLdoMkmA/fe3fw p3mQhF32+2yHHYHYZj4kjLjGotYA0u7Aa58HmEa+2uRA6GdokEd4iCBZgmSug9niNu5e txAX7CIM5RjFamF9DCUWzp4ZlpKnCtjEViDM88HXzl74XDcCnPoMpDt8qGq3r8KMF6VX aCEA9U49bQqQ3F2+VvKUGTtrW9yjypqeLeGofK0mt4yi/JRwSjyoiNmf13OnNrWYG/Tu Xg8b1jkXDDPS5KtMJ+/3rNuQOSR+BTat3KtYVvcQtgQTzpL+/vISsyybfRlxQZRnyEa9 ojqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=a7G6GYZBtSrpKnVYR4/U2KwvsEUYsm86i97SKYYAnYU=; fh=W8fVyZll+iJLcUEivrbYmyH/LGcInpXpPwqwx/2Cw+s=; b=PHfIUutX95K5WQHqCQ0J2apM0NV81SfkeogJe3v6X1+mQJCL1cTIq5A9FhCNks7exI F6xoI2MC97MQKIIVzHfnkLJhwQGRxVyma1OUbUhIQ0ZQ6TcO31w4YpCZ8EgfHZRadR6p 4KlJT9eeUgqxb0rNSkODhLGThnIIbwQRV6xI/PNdi0xiug+L94fN/y6uz2ZyZ20kpnU3 Kb/3wmS9tbYcej9tTYTihDGGIrcseyPJQW2pih+tPHB6ssAIyQX4MIuzk6bJmkkBx4my FwJglyWqlFpy/KDc7ijZRCUsY58e6+Jug4Y623jj1WM4S0i88+q34hsIyuDjCX8MQtp/ f/Rw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=cFfB55uw; spf=pass (google.com: domain of fm-68982-20240829122640f7036cfec99089273f-kuryl6@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-20240829122640f7036cfec99089273f-KuRYL6@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from mta-64-226.siemens.flowmailer.net (mta-64-226.siemens.flowmailer.net. [185.136.64.226]) by gmr-mx.google.com with ESMTPS id ca18e2360f4ac-82a1a4530e2si5020639f.2.2024.08.29.05.26.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Aug 2024 05:26:41 -0700 (PDT) Received-SPF: pass (google.com: domain of fm-68982-20240829122640f7036cfec99089273f-kuryl6@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) client-ip=185.136.64.226; Received: by mta-64-226.siemens.flowmailer.net with ESMTPSA id 20240829122640f7036cfec99089273f for ; Thu, 29 Aug 2024 14:26:40 +0200 Message-ID: <8086840c9b7bcf8dbcd6d3141d493c87f9e6d5c8.camel@siemens.com> Subject: Re: [PATCH] meta: Drop lazy and recursive unmounts From: "'Florian Bezdeka' via isar-users" To: Anton Mikanovich , isar-users@googlegroups.com Cc: Jan Kiszka , Baurzhan Ismagulov Date: Thu, 29 Aug 2024 14:26:38 +0200 In-Reply-To: <9ecb2ac7-9abd-4782-8498-7c5216fc99ca@ilbers.de> References: <20240619104126.105252-1-amikan@ilbers.de> <9ecb2ac7-9abd-4782-8498-7c5216fc99ca@ilbers.de> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-Original-Sender: florian.bezdeka@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=cFfB55uw; spf=pass (google.com: domain of fm-68982-20240829122640f7036cfec99089273f-kuryl6@rts-flowmailer.siemens.com designates 185.136.64.226 as permitted sender) smtp.mailfrom=fm-68982-20240829122640f7036cfec99089273f-KuRYL6@rts-flowmailer.siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Original-From: Florian Bezdeka Reply-To: Florian Bezdeka Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-2.2 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_PSBL,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: ++KJ5+vp9rkg On Thu, 2024-08-29 at 12:26 +0300, Anton Mikanovich wrote: > 28/08/2024 16:05, Florian Bezdeka wrote: > > Hi all, > > > > I'm not 100% sure, but it seems I'm facing some problems with this > > patch. I know about the situation that we sporadically saw some > > mounting issues and that patch tries to expose such issues. > > > > At least my issue seems to reproduce to 100%... > > > > See below... > > > > On Wed, 2024-06-19 at 13:41 +0300, Anton Mikanovich wrote: > > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > > index faf22a50..6bc667e7 100644 > > > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > > > @@ -341,7 +341,7 @@ do_bootstrap() { > > > echo "deb-src ${line}" >> "${ROOTFSDIR}/etc/apt/sources.list.d/base-apt.list" > > > > > > mkdir -p ${ROOTFSDIR}/base-apt > > > - mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt > > > + mount -o bind,private "${REPO_BASE_DIR}" "${ROOTFSDIR}/base-apt" > > > else > > > install -v -m644 "${APTSRCS}" \ > > > "${ROOTFSDIR}/etc/apt/sources.list.d/bootstrap.list" > > > @@ -378,10 +378,10 @@ do_bootstrap() { > > > > > > # update APT > > > mount -o bind,private /dev ${ROOTFSDIR}/dev > > That means that we mount /dev from "the host" into the rootfs/chroot > > environment, right? "Submounts included", no? > > > > I'm facing the following error with that. The isar build is executed > > inside a container / pod running on a k8s cluster. > > > > Inside the container the following steps are executed: > > > > build-bookworm: > > script: > > - kas build > > - sudo rm -rf build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target > > > > The rm command triggers the following errors: > > > > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/shm': Device or resource busy > > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/termination-log': Device or resource busy > > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/mqueue': Device or resource busy > > rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/pts': Device or resource busy > > > > My assumption is that isar is not cleaning up all mounts. I think the > > interesting part is about /dev/termination-log. > > That device is mounted into the pod by the k8s infrastructure. > > > > I think we should never mount that into the chroot, or make sure it is > > properly unmounted again... > > > > Any thoughts on that? Any additional information needed? > > > > Florian > > Hello Florian, > > The line you are pointing to is inside isar-bootstrap preparations, > while your > error is pointing to busy mountpoints in sbuild-chroot, managed by > rootfs.bbclass. > Anyway private mount private mount does not forward or receive > propagations. It means no external submounts will be mounted inside > rootfs and > no Isar mounts will be mounted to external /dev. > Can you check which mountpoints are left after the build (before rm)? I think this is the relevant line from "mount": tmpfs on /builds//build/tmp/work/debian-bookworm-amd64/sbuild- chroot-target/1.0-r0/rootfs/dev type tmpfs (rw,nosuid,size=65536k,mode=755,inode64) Florian -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/8086840c9b7bcf8dbcd6d3141d493c87f9e6d5c8.camel%40siemens.com.