Re: [PATCH 1/2] rootfs: clean rootfs dir before unpack from sstate

["'Moessbauer, Felix' via isar-users" <isar-users@googlegroups.com>]

On Mon, 2026-10-26 at 14:16 +0300, Aliaksei Karpovich wrote:
> 
>  
> 
> 
> 
>  
> 
> 
> 
> On 10/26/26 12:47, Moessbauer, Felix wrote:
>  
> 
> 
> 
>  
> 
> 
> 
> >  
> > 
> > 
> > 
> > On Fri, 2026-10-23 at 15:33 +0200, Aliaksei Karpovich wrote:
> >  
> > 
> > 
> > 
> > >  
> > > 
> > > 
> > > 
> > > In case when rootfs is restored (unpacked) from sstate, we have to clean
> > > rootfs dir because it can contain files from previous build which should
> > > not be included in current rootfs and will not be deleted during unpack.
> > > ---
> > >  meta/classes-recipe/rootfs.bbclass | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> > > index 4fd627c2..99e701e9 100644
> > > --- a/meta/classes-recipe/rootfs.bbclass
> > > +++ b/meta/classes-recipe/rootfs.bbclass
> > > @@ -776,6 +776,7 @@ rootfs_install_sstate_finalize() {
> > >      # - after restoring from cache, there will be a tar which we unpack and then delete
> > >      if [ -f rootfs.tar ]; then
> > >          run_privileged_heredoc <<'EOF'
> > > +        rm -rf ${ROOTFSDIR}/*
> > >  
> > > 
> > > 
> > > 
> >  
> > 
> > 
> > 
> > Hi, this skips hidden files. Can't we use
> > 
> > rootfs_install_sstate_finalize[root_cleandirs] += "${ROOTFSDIR}"
> > 
> > instead? Then we could also avoid the following mkdir.
> > 
> > Felix
> >  
> > 
> > 
> > 
>  
> 
> 
> 
> Hi, 
>  I thought about it, but in this case logic will be different, the ROOTFS dir will be deleted always.
>  But in current implementation it's deleted only if rootfs.tar exists.

Ah... makes sense.

>  
> 
> 
> 
> 
> 
> 
> 
>  > this skips hidden files
> It will skip hidden files only in root. Is it real case (hidden files in root)? I can change it to 'rm -rf ${ROOTFSDIR}'.

Not a real case yet, but a bug waiting to happen. Let's use rm -rf
${ROOTFSDIR}.

Felix

> 
> Aliaksei
>  
> 
> 
> 
> >  
> > 
> > 
> > 
> >  
> > 
> > 
> > 
> > 
> >  
> > 
> > 
> > 
> > >  
> > > 
> > > 
> > > 
> > >          mkdir -p ${ROOTFSDIR}
> > >          tar -C ${ROOTFSDIR} -xp ${SSTATE_TAR_ATTR_FLAGS} -f rootfs.tar
> > >  EOF
> > > -- 
> > > 2.53.0
> > > 
> > > -- 
> > > You received this message because you are subscribed to the Google Groups "isar-users" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> > > To view this discussion visit https://groups.google.com/d/msgid/isar-users/20261023133338.32200-1-akarpovich%40ilbers.de.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/80b50104d5a3c10a65dd217e26e6f9d2244e3d32.camel%40siemens.com.