Hi Henning,

On Mon, 2018-06-04 at 19:36 +0200, Henning Schild wrote:
> Hi,
> 
> this looks pretty nasty,

Yes it is. But its mostly copied from debian-installer source. I just
added a bit execution environment and parametrized the target path.

> and this is the "old" way of doing something
> like that. I would prefer adding some cgroup support to Isar to deal
> with that and other things. But if it works and did so in Debian for
> years ... why not.
> 
> We could cgreate a temporary cgroup where we cgexec "sudo chroot",
> when
> that returns we destroy the cgroup and autokill everything running in
> there. This might also work for the umounts that we now still do
> explicit.
> 
> I guess cgroups are a feature we can expect from a modern Linux build
> host, question is can we rely on the tools or should we create them
> manually.
> 
> If you are building in docker you get what i described for "free". It
> takes care of cgroups and cleaning up after a finished build, but
> only
> once you end the container.

I could not reproduce this issue. I installed openssh-server to the
image without this patch applied and did not stop the container. (As I
usually don't) But there were still no left over running applications.
I don't know why.

If you like you can implement a better way using cgroups. AFAIK you are
more experienced in those. I would have to test that out first.

Claudius

> 
> Henning
> 
> Am Mon, 4 Jun 2018 13:21:58 +0200
> schrieb "[ext] claudius.heine.ext@siemens.com"
> <claudius.heine.ext@siemens.com>:
> 
> > From: Claudius Heine <ch@denx.de>
> > 
> > Hi,
> > 
> > this patch disables the daemon activation in the chroot
> > environment.
> > 
> > Since I could not reproduce the problem this patch handles, please
> > test if this fixes it, if the code looks fine.
> > 
> > Cheers,
> > Claudius
> > 
> > Claudius Heine (1):
> >   meta/isar-bootstrap: deactivate daemon activation in chroot
> >     environment
> > 
> >  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
> >  .../isar-bootstrap/files/chroot-setup.sh      | 133
> > ++++++++++++++++++ .../isar-bootstrap/isar-bootstrap.bb          |
> > 11 +- 3 files changed, 144 insertions(+), 2 deletions(-)
> >  create mode 100644
> > meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> > 
> 
> 
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

            PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                              Keyserver: hkp://pool.sks-keyservers.net