Re: [PATCH 2/3] dpkg-base: ignore binary packages for "apt-get source"

[Jan Kiszka <jan.kiszka@siemens.com>]

On 19.09.19 19:22, [ext] Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> A buildchroot might already know the new/rebuild version of an upstream
> package as a binary coming from isar-apt. Now apt-get source will try
> to fetch that one instead of the upstream version that we rebuild to
> produce the new one.
> 
> Not that ignoring binaries also means we loose the vague version
> matching, inform users about that.
> 
> This problem can be seen in partial rebuild scenarios and the switch
> solves it, at least until we do not have sources in isar-apt.

"until we have"

> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   RECIPE-API-CHANGELOG.md        | 7 +++++++
>   meta/classes/dpkg-base.bbclass | 3 ++-
>   2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index bbef1a3..1f29eb2 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -149,6 +149,13 @@ default).
>   Changes in v0.8
>   ---------------
>   
> +### `apt://` SRC_URIs where added and briefly changed their version picking way
> +
> +Recipes that use SRC_URIs with `apt://` and choose a version with `=` had a
> +partial matching feature for a short time between 0.7 and 0.8. In 0.8 the
> +version has to be the exact upsteam match.
> +It is probably best to not specify a version if you can.
> +
>   ### `isar-image.bbclass` class will be deprecated in future version of isar
>   
>   The content of `isar-image.bbclass` was moved to the `image.bbclass` file.
> diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
> index 1deccd4..f77eb7b 100644
> --- a/meta/classes/dpkg-base.bbclass
> +++ b/meta/classes/dpkg-base.bbclass
> @@ -34,8 +34,9 @@ do_apt_fetch() {
>   		-o Dir::Etc::SourceList="sources.list.d/isar-apt.list" \
>   		-o Dir::Etc::SourceParts="-" \
>   		-o APT::Get::List-Cleanup="0"
> +
>   	sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} \
> -		sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}'
> +		sh -c 'cd ${PP} && apt-get -y --only-source source ${SRC_APT}'
>   	dpkg_undo_mounts
>   }
>   
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux