public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 2/5] deb-dl-dir: Fix quoting
Date: Thu, 24 Sep 2020 17:49:48 +0200	[thread overview]
Message-ID: <815ce8ec0fadec7ba3a5b8bf49e48c10e7370142.1600962590.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1600962590.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

The outer flock call wraps this in '', so this can't be used inside the
block. The current code failed if some .deb file happened to lie around
in the build folder.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/deb-dl-dir.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl-dir.bbclass
index e9967036..54c29947 100644
--- a/meta/classes/deb-dl-dir.bbclass
+++ b/meta/classes/deb-dl-dir.bbclass
@@ -14,8 +14,8 @@ deb_dl_dir_import() {
         set -e
         printenv | grep -q BB_VERBOSE_LOGS && set -x
 
-        sudo find "${pc}" -type f -iname '*\.deb' -exec \
-            cp -n --no-preserve=owner -t "${rootfs}"/var/cache/apt/archives/ '{}' +
+        sudo find "${pc}" -type f -iname "*\.deb" -exec \
+            cp -n --no-preserve=owner -t "${rootfs}"/var/cache/apt/archives/ {} +
     '
 }
 
-- 
2.26.2


  parent reply	other threads:[~2020-09-24 15:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 15:49 [PATCH 0/5] More fixes and cleanups Jan Kiszka
2020-09-24 15:49 ` [PATCH 1/5] buildchroot-host: Drop unneeded :native for riscv64 setup Jan Kiszka
2020-09-24 15:49 ` Jan Kiszka [this message]
2020-09-24 21:27   ` [PATCH 2/5] deb-dl-dir: Fix quoting Henning Schild
2020-09-24 15:49 ` [PATCH 3/5] Fix dependencies on isar-apt Jan Kiszka
2020-09-24 15:49 ` [PATCH 4/5] dpkg: Account for changes in mk-build-deps in bullseye Jan Kiszka
2020-09-24 21:32   ` Henning Schild
2020-09-25  6:21     ` Jan Kiszka
2020-09-25  7:02       ` Henning Schild
2020-09-24 15:49 ` [PATCH 5/5] isar-bootstrap: Align debootstrap calls Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=815ce8ec0fadec7ba3a5b8bf49e48c10e7370142.1600962590.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox