[PATCH v3] meta: Run depmod after kernel module installation

[PATCH v3] meta: Run depmod after kernel module installation

[Jan Kiszka]

Otherwise the module may not be found if the module package is installed
on its own, i.e. without the kernel package performing the depmod run.

As we now install a postinst baseline with the right mode, the chmod on
AUTOLOAD becomes obsolete.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Changes in v3:
 - remove now obsolete chmod on AUTOLOAD

 meta/recipes-kernel/linux-module/files/debian/postinst | 4 ++++
 meta/recipes-kernel/linux-module/module.inc            | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100755 meta/recipes-kernel/linux-module/files/debian/postinst

diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst b/meta/recipes-kernel/linux-module/files/debian/postinst
new file mode 100755
index 0000000..baabf5d
--- /dev/null
+++ b/meta/recipes-kernel/linux-module/files/debian/postinst
@@ -0,0 +1,4 @@
+#!/bin/sh
+set -e
+
+depmod -a
diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
index 3075f44..76a49f3 100644
--- a/meta/recipes-kernel/linux-module/module.inc
+++ b/meta/recipes-kernel/linux-module/module.inc
@@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
 
     if [ ${AUTOLOAD} = "1" ]; then
         echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
-        chmod +x ${S}/debian/postinst
     fi
 }
-- 
2.16.4

Re: [PATCH v3] meta: Run depmod after kernel module installation

[Jan Kiszka]

On 2018-07-09 11:50, [ext] Jan Kiszka wrote:
> Otherwise the module may not be found if the module package is installed
> on its own, i.e. without the kernel package performing the depmod run.
> 
> As we now install a postinst baseline with the right mode, the chmod on
> AUTOLOAD becomes obsolete.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Changes in v3:
>   - remove now obsolete chmod on AUTOLOAD
> 
>   meta/recipes-kernel/linux-module/files/debian/postinst | 4 ++++
>   meta/recipes-kernel/linux-module/module.inc            | 1 -
>   2 files changed, 4 insertions(+), 1 deletion(-)
>   create mode 100755 meta/recipes-kernel/linux-module/files/debian/postinst
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst b/meta/recipes-kernel/linux-module/files/debian/postinst
> new file mode 100755
> index 0000000..baabf5d
> --- /dev/null
> +++ b/meta/recipes-kernel/linux-module/files/debian/postinst
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +set -e
> +
> +depmod -a
> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
> index 3075f44..76a49f3 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
>   
>       if [ ${AUTOLOAD} = "1" ]; then
>           echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
> -        chmod +x ${S}/debian/postinst
>       fi
>   }
> 

Ping. Seems this fell through the cracks.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH v3] meta: Run depmod after kernel module installation

[Jan Kiszka]

On 2018-08-19 09:23, [ext] Jan Kiszka wrote:
> On 2018-07-09 11:50, [ext] Jan Kiszka wrote:
>> Otherwise the module may not be found if the module package is installed
>> on its own, i.e. without the kernel package performing the depmod run.
>>
>> As we now install a postinst baseline with the right mode, the chmod on
>> AUTOLOAD becomes obsolete.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Changes in v3:
>>   - remove now obsolete chmod on AUTOLOAD
>>
>>   meta/recipes-kernel/linux-module/files/debian/postinst | 4 ++++
>>   meta/recipes-kernel/linux-module/module.inc            | 1 -
>>   2 files changed, 4 insertions(+), 1 deletion(-)
>>   create mode 100755 
>> meta/recipes-kernel/linux-module/files/debian/postinst
>>
>> diff --git a/meta/recipes-kernel/linux-module/files/debian/postinst 
>> b/meta/recipes-kernel/linux-module/files/debian/postinst
>> new file mode 100755
>> index 0000000..baabf5d
>> --- /dev/null
>> +++ b/meta/recipes-kernel/linux-module/files/debian/postinst
>> @@ -0,0 +1,4 @@
>> +#!/bin/sh
>> +set -e
>> +
>> +depmod -a
>> diff --git a/meta/recipes-kernel/linux-module/module.inc 
>> b/meta/recipes-kernel/linux-module/module.inc
>> index 3075f44..76a49f3 100644
>> --- a/meta/recipes-kernel/linux-module/module.inc
>> +++ b/meta/recipes-kernel/linux-module/module.inc
>> @@ -26,6 +26,5 @@ dpkg_runbuild_prepend() {
>>       if [ ${AUTOLOAD} = "1" ]; then
>>           echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst
>> -        chmod +x ${S}/debian/postinst
>>       fi
>>   }
>>
> 
> Ping. Seems this fell through the cracks.
> 
> Jan
> 

OK, this does not yet work, at least when run during image generation: 
depmod will pick of the host kernel version, not that of the target, and 
will fail if the differ (quite likely). That "set -e" needs to go, just 
like in [1]. Will send v4.

Jan

[1] 
https://github.com/siemens/jailhouse-images/commit/2a66ef8e7f86496ae919ed84cd95370a2ddb7b91#diff-61a459fb1abcb39646b0e3661640ecbf