From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:a17:906:c344:: with SMTP id ci4mr6036144ejb.219.1565681231212; Tue, 13 Aug 2019 00:27:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:ada:: with SMTP id z26ls2870829ejf.4.gmail; Tue, 13 Aug 2019 00:27:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqylD4OzvBEFWKO7/Zd7rEUFx1G5vDOB6ksEk76Rcj3ryvuk2mGy8vRyurUBlgmrn4XYFmfD X-Received: by 2002:a17:906:4019:: with SMTP id v25mr8484055ejj.108.1565681230832; Tue, 13 Aug 2019 00:27:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565681230; cv=none; d=google.com; s=arc-20160816; b=TBvBEwoweNHhyODjrLrRtEo2XzVC1fm4Lf3dcZxA/6L3rflWZzb1MTBdt+kGRtU1bm hvkHfKxL5ymIZ5xE8Vv1VkkIjrC10ZdVGof5EbNwQgk1btYn0TXpt3qZutjAwldAIuSM 2ggDKllw006g9ePNGrHlJbnpdHk1WmNmGb9BFlH2sMqZkTUkpYyp5DX8nExDwEYEHggd lkm9giLAQawm5FvIZ43bGw34NSpy3Zz6peBT3ik1kNG0db8OiEVHjjKSG8rzFU4apGon /6LituoTy4/Klejzkio0BHmzeVKsrpB5XTK0nrySmz5sbDkCpOnWKOsjC9RJE4feIv7Y xAyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=NcQwAOGY+JbKOzwXtscOEsXUrbJAYWfn8eh60skjdYs=; b=hFf7JhkACBqMoxzLQEWwJFPZidsrngY+fQM2vCw7+G9LSRHdr9m3DvJpGuNlhhcEe9 8b+2qQ7lhklGaIn6JrmcDioy8NaeH1O2TFw4BG0s4eIDDoXZom/0gNBNKQv/cH3KkeLI 9r3NH9+ya31Hcd2zbVCCHI74YNOaPS7O/IqLC9/tpedFjeJGm8C4GD+LLYJn4xgBFFhp pDmJg5V8ECkgPH4WRD4U1TKsC9Gk0H03lIk3/ztJzcuEAaB326JMCjQqtFGUGIKKsWVm sRO5WNUJ0NxYpR/P2l/aonX8ir30qkRITBf5PvkB7ZFYncePRXvkrGcOx8KGOSsrc2Qi ja1A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id jz14si4700208ejb.0.2019.08.13.00.27.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 00:27:10 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x7D7R9us006308 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Aug 2019 09:27:09 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7D7R9a1028113; Tue, 13 Aug 2019 09:27:09 +0200 Subject: Re: [PATCH v2] Set STAMPCLEAN variable To: "[ext] Jan Kiszka" , isar-users Cc: Claudius Heine References: <4b5f25df-8a9d-fa99-59e0-1a2730f12654@siemens.com> From: Claudius Heine Message-ID: <81fcc2f2-341e-4730-abeb-58b4d8bc06de@siemens.com> Date: Tue, 13 Aug 2019 09:27:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <4b5f25df-8a9d-fa99-59e0-1a2730f12654@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 0DcFQnWCU21J Hi Jan, On 12/08/2019 19.15, [ext] Jan Kiszka wrote: > From: Jan Kiszka > > This ensures that stamp files are cleaned when a task is rebuilt. Not > providing this pattern likely caused a lot of failures when doing > partial rebuilds. > > As we are at it, switch do_clean to STAMPCLEAN as well. > > Signed-off-by: Jan Kiszka > --- > meta/classes/base.bbclass | 4 ++-- > meta/conf/bitbake.conf | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > index ca80bf8..b6638ca 100644 > --- a/meta/classes/base.bbclass > +++ b/meta/classes/base.bbclass > @@ -206,8 +206,8 @@ python do_clean() { > workdir = d.expand("${WORKDIR}") > subprocess.check_call(["sudo", "rm", "-rf", workdir]) > > - stamppath = bb.data.expand(d.getVar('STAMP', False), d) > - stampdirs = glob.glob(stamppath + ".*") > + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d) > + stampdirs = glob.glob(stampclean) > subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) > } > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 3d18223..003fb01 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}" > AUTOREV = "${@bb.fetch2.get_autorev(d)}" > SRC_URI = "file://${FILE}" > STAMP = "${TMPDIR}/stamps/${PF}" > +STAMPCLEAN = "${STAMP}*" I would rather go with "${TMPDIR}/stamps/${PN}-*". OE/YP remove the stamps of other recipe versions as well. This is what OE/YP does: STAMPS_DIR ?= "${TMPDIR}/stamps" STAMP = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}" STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*" regards, Claudius > SVNDIR = "${DL_DIR}/svn" > T = "${WORKDIR}/temp" > TMPDIR = "${TOPDIR}/tmp" > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de