* [PATCH v2] Set STAMPCLEAN variable
@ 2019-08-12 17:15 Jan Kiszka
2019-08-13 7:27 ` Claudius Heine
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2019-08-12 17:15 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Jan Kiszka <jan.kiszka@siemens.com>
This ensures that stamp files are cleaned when a task is rebuilt. Not
providing this pattern likely caused a lot of failures when doing
partial rebuilds.
As we are at it, switch do_clean to STAMPCLEAN as well.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/base.bbclass | 4 ++--
meta/conf/bitbake.conf | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index ca80bf8..b6638ca 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -206,8 +206,8 @@ python do_clean() {
workdir = d.expand("${WORKDIR}")
subprocess.check_call(["sudo", "rm", "-rf", workdir])
- stamppath = bb.data.expand(d.getVar('STAMP', False), d)
- stampdirs = glob.glob(stamppath + ".*")
+ stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
+ stampdirs = glob.glob(stampclean)
subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
}
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 3d18223..003fb01 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
AUTOREV = "${@bb.fetch2.get_autorev(d)}"
SRC_URI = "file://${FILE}"
STAMP = "${TMPDIR}/stamps/${PF}"
+STAMPCLEAN = "${STAMP}*"
SVNDIR = "${DL_DIR}/svn"
T = "${WORKDIR}/temp"
TMPDIR = "${TOPDIR}/tmp"
--
2.16.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-12 17:15 [PATCH v2] Set STAMPCLEAN variable Jan Kiszka
@ 2019-08-13 7:27 ` Claudius Heine
2019-08-13 8:01 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2019-08-13 7:27 UTC (permalink / raw)
To: [ext] Jan Kiszka, isar-users; +Cc: Claudius Heine
Hi Jan,
On 12/08/2019 19.15, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This ensures that stamp files are cleaned when a task is rebuilt. Not
> providing this pattern likely caused a lot of failures when doing
> partial rebuilds.
>
> As we are at it, switch do_clean to STAMPCLEAN as well.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/base.bbclass | 4 ++--
> meta/conf/bitbake.conf | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index ca80bf8..b6638ca 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -206,8 +206,8 @@ python do_clean() {
> workdir = d.expand("${WORKDIR}")
> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>
> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
> - stampdirs = glob.glob(stamppath + ".*")
> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
> + stampdirs = glob.glob(stampclean)
> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
> }
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 3d18223..003fb01 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
> SRC_URI = "file://${FILE}"
> STAMP = "${TMPDIR}/stamps/${PF}"
> +STAMPCLEAN = "${STAMP}*"
I would rather go with "${TMPDIR}/stamps/${PN}-*".
OE/YP remove the stamps of other recipe versions as well.
This is what OE/YP does:
STAMPS_DIR ?= "${TMPDIR}/stamps"
STAMP =
"${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}"
STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*"
regards,
Claudius
> SVNDIR = "${DL_DIR}/svn"
> T = "${WORKDIR}/temp"
> TMPDIR = "${TOPDIR}/tmp"
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-13 7:27 ` Claudius Heine
@ 2019-08-13 8:01 ` Jan Kiszka
2019-08-13 8:17 ` Claudius Heine
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2019-08-13 8:01 UTC (permalink / raw)
To: Claudius Heine, isar-users; +Cc: Claudius Heine
On 13.08.19 09:27, Claudius Heine wrote:
> Hi Jan,
>
> On 12/08/2019 19.15, [ext] Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This ensures that stamp files are cleaned when a task is rebuilt. Not
>> providing this pattern likely caused a lot of failures when doing
>> partial rebuilds.
>>
>> As we are at it, switch do_clean to STAMPCLEAN as well.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meta/classes/base.bbclass | 4 ++--
>> meta/conf/bitbake.conf | 1 +
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index ca80bf8..b6638ca 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -206,8 +206,8 @@ python do_clean() {
>> workdir = d.expand("${WORKDIR}")
>> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
>> - stampdirs = glob.glob(stamppath + ".*")
>> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
>> + stampdirs = glob.glob(stampclean)
>> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
>> }
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 3d18223..003fb01 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
>> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
>> SRC_URI = "file://${FILE}"
>> STAMP = "${TMPDIR}/stamps/${PF}"
>> +STAMPCLEAN = "${STAMP}*"
>
> I would rather go with "${TMPDIR}/stamps/${PN}-*".
>
> OE/YP remove the stamps of other recipe versions as well.
>
> This is what OE/YP does:
>
> STAMPS_DIR ?= "${TMPDIR}/stamps"
> STAMP = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}"
> STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*"
What would be the scenario where this helps? Just trying to understand.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-13 8:01 ` Jan Kiszka
@ 2019-08-13 8:17 ` Claudius Heine
0 siblings, 0 replies; 8+ messages in thread
From: Claudius Heine @ 2019-08-13 8:17 UTC (permalink / raw)
To: Jan Kiszka, isar-users; +Cc: Claudius Heine
On 13/08/2019 10.01, Jan Kiszka wrote:
> On 13.08.19 09:27, Claudius Heine wrote:
>> Hi Jan,
>>
>> On 12/08/2019 19.15, [ext] Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This ensures that stamp files are cleaned when a task is rebuilt. Not
>>> providing this pattern likely caused a lot of failures when doing
>>> partial rebuilds.
>>>
>>> As we are at it, switch do_clean to STAMPCLEAN as well.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> meta/classes/base.bbclass | 4 ++--
>>> meta/conf/bitbake.conf | 1 +
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>>> index ca80bf8..b6638ca 100644
>>> --- a/meta/classes/base.bbclass
>>> +++ b/meta/classes/base.bbclass
>>> @@ -206,8 +206,8 @@ python do_clean() {
>>> workdir = d.expand("${WORKDIR}")
>>> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>>> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
>>> - stampdirs = glob.glob(stamppath + ".*")
>>> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
>>> + stampdirs = glob.glob(stampclean)
>>> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
>>> }
>>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>>> index 3d18223..003fb01 100644
>>> --- a/meta/conf/bitbake.conf
>>> +++ b/meta/conf/bitbake.conf
>>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
>>> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
>>> SRC_URI = "file://${FILE}"
>>> STAMP = "${TMPDIR}/stamps/${PF}"
>>> +STAMPCLEAN = "${STAMP}*"
>>
>> I would rather go with "${TMPDIR}/stamps/${PN}-*".
>>
>> OE/YP remove the stamps of other recipe versions as well.
>>
>> This is what OE/YP does:
>>
>> STAMPS_DIR ?= "${TMPDIR}/stamps"
>> STAMP =
>> "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}"
>> STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*"
>
> What would be the scenario where this helps? Just trying to understand.
Good question, that I don't have an answer for. I looked at the commit
messages, but it seems to be that this part of the STAMPCLEAN variable
goes back to the first commit that introduced it.
It is probably just a general philosophy, should different versions of
the same recipe invalidate the stamps of each other or not.
regards,
Claudius
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] Set STAMPCLEAN variable
@ 2019-08-14 12:39 Jan Kiszka
2019-08-14 14:10 ` Claudius Heine
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2019-08-14 12:39 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
This ensures that stamp files are cleaned when a task is rebuilt. Not
providing this pattern likely caused a lot of failures when doing
partial rebuilds.
As we are at it, switch do_clean to STAMPCLEAN as well.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta/classes/base.bbclass | 4 ++--
meta/conf/bitbake.conf | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index ca80bf8..b6638ca 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -206,8 +206,8 @@ python do_clean() {
workdir = d.expand("${WORKDIR}")
subprocess.check_call(["sudo", "rm", "-rf", workdir])
- stamppath = bb.data.expand(d.getVar('STAMP', False), d)
- stampdirs = glob.glob(stamppath + ".*")
+ stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
+ stampdirs = glob.glob(stampclean)
subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
}
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 3d18223..ee86ee0 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
AUTOREV = "${@bb.fetch2.get_autorev(d)}"
SRC_URI = "file://${FILE}"
STAMP = "${TMPDIR}/stamps/${PF}"
+STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*"
SVNDIR = "${DL_DIR}/svn"
T = "${WORKDIR}/temp"
TMPDIR = "${TOPDIR}/tmp"
--
2.16.4
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-14 12:39 Jan Kiszka
@ 2019-08-14 14:10 ` Claudius Heine
2019-08-14 14:17 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2019-08-14 14:10 UTC (permalink / raw)
To: Jan Kiszka, isar-users
[-- Attachment #1.1: Type: text/plain, Size: 2437 bytes --]
Hi Jan,
you probably mean v3.
On 14/08/2019 14.39, Jan Kiszka wrote:
> This ensures that stamp files are cleaned when a task is rebuilt. Not
> providing this pattern likely caused a lot of failures when doing
> partial rebuilds.
>
> As we are at it, switch do_clean to STAMPCLEAN as well.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/base.bbclass | 4 ++--
> meta/conf/bitbake.conf | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index ca80bf8..b6638ca 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -206,8 +206,8 @@ python do_clean() {
> workdir = d.expand("${WORKDIR}")
> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>
> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
> - stampdirs = glob.glob(stamppath + ".*")
> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
> + stampdirs = glob.glob(stampclean)
> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
> }
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 3d18223..ee86ee0 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
> SRC_URI = "file://${FILE}"
> STAMP = "${TMPDIR}/stamps/${PF}"
> +STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*"
What I did come across when looking at the commit messages of OE was,
that they used to have all stamps in just one directory. They changed
that, because they and problems when a recipe name 'recipe-1.2.3'
removing stamps from a recipe named 'recipe-name-4.5.6'.
Maybe we should really copy what current OE upstream does.
Like this:
STAMPS_DIR ?= "${TMPDIR}/stamps"
STAMP = "${STAMPS_DIR}/${PN}/${PV}-${PR}"
STAMPCLEAN = "${STAMPS_DIR}/${PN}/*-*"
kind regards,
Claudius
> SVNDIR = "${DL_DIR}/svn"
> T = "${WORKDIR}/temp"
> TMPDIR = "${TOPDIR}/tmp"
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
Keyserver: hkp://pool.sks-keyservers.net
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 850 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-14 14:10 ` Claudius Heine
@ 2019-08-14 14:17 ` Jan Kiszka
2019-08-19 19:00 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2019-08-14 14:17 UTC (permalink / raw)
To: Claudius Heine, isar-users
On 14.08.19 16:10, Claudius Heine wrote:
> Hi Jan,
>
> you probably mean v3.
Yes, sorry.
>
> On 14/08/2019 14.39, Jan Kiszka wrote:
>> This ensures that stamp files are cleaned when a task is rebuilt. Not
>> providing this pattern likely caused a lot of failures when doing
>> partial rebuilds.
>>
>> As we are at it, switch do_clean to STAMPCLEAN as well.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> meta/classes/base.bbclass | 4 ++--
>> meta/conf/bitbake.conf | 1 +
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index ca80bf8..b6638ca 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -206,8 +206,8 @@ python do_clean() {
>> workdir = d.expand("${WORKDIR}")
>> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>>
>> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
>> - stampdirs = glob.glob(stamppath + ".*")
>> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
>> + stampdirs = glob.glob(stampclean)
>> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
>> }
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 3d18223..ee86ee0 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
>> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
>> SRC_URI = "file://${FILE}"
>> STAMP = "${TMPDIR}/stamps/${PF}"
>> +STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*"
>
> What I did come across when looking at the commit messages of OE was,
> that they used to have all stamps in just one directory. They changed
> that, because they and problems when a recipe name 'recipe-1.2.3'
> removing stamps from a recipe named 'recipe-name-4.5.6'.
>
> Maybe we should really copy what current OE upstream does.
>
> Like this:
>
> STAMPS_DIR ?= "${TMPDIR}/stamps"
> STAMP = "${STAMPS_DIR}/${PN}/${PV}-${PR}"
> STAMPCLEAN = "${STAMPS_DIR}/${PN}/*-*"
I agree that aligning makes sense, but let's to that on top.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] Set STAMPCLEAN variable
2019-08-14 14:17 ` Jan Kiszka
@ 2019-08-19 19:00 ` Jan Kiszka
0 siblings, 0 replies; 8+ messages in thread
From: Jan Kiszka @ 2019-08-19 19:00 UTC (permalink / raw)
To: Claudius Heine, isar-users
On 14.08.19 16:17, [ext] Jan Kiszka wrote:
> On 14.08.19 16:10, Claudius Heine wrote:
>> Hi Jan,
>>
>> you probably mean v3.
>
> Yes, sorry.
>
>>
>> On 14/08/2019 14.39, Jan Kiszka wrote:
>>> This ensures that stamp files are cleaned when a task is rebuilt. Not
>>> providing this pattern likely caused a lot of failures when doing
>>> partial rebuilds.
>>>
>>> As we are at it, switch do_clean to STAMPCLEAN as well.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>> meta/classes/base.bbclass | 4 ++--
>>> meta/conf/bitbake.conf | 1 +
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>>> index ca80bf8..b6638ca 100644
>>> --- a/meta/classes/base.bbclass
>>> +++ b/meta/classes/base.bbclass
>>> @@ -206,8 +206,8 @@ python do_clean() {
>>> workdir = d.expand("${WORKDIR}")
>>> subprocess.check_call(["sudo", "rm", "-rf", workdir])
>>> - stamppath = bb.data.expand(d.getVar('STAMP', False), d)
>>> - stampdirs = glob.glob(stamppath + ".*")
>>> + stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d)
>>> + stampdirs = glob.glob(stampclean)
>>> subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs)
>>> }
>>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>>> index 3d18223..ee86ee0 100644
>>> --- a/meta/conf/bitbake.conf
>>> +++ b/meta/conf/bitbake.conf
>>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}"
>>> AUTOREV = "${@bb.fetch2.get_autorev(d)}"
>>> SRC_URI = "file://${FILE}"
>>> STAMP = "${TMPDIR}/stamps/${PF}"
>>> +STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*"
>>
>> What I did come across when looking at the commit messages of OE was,
>> that they used to have all stamps in just one directory. They changed
>> that, because they and problems when a recipe name 'recipe-1.2.3'
>> removing stamps from a recipe named 'recipe-name-4.5.6'.
>>
>> Maybe we should really copy what current OE upstream does.
>>
>> Like this:
>>
>> STAMPS_DIR ?= "${TMPDIR}/stamps"
>> STAMP = "${STAMPS_DIR}/${PN}/${PV}-${PR}"
>> STAMPCLEAN = "${STAMPS_DIR}/${PN}/*-*"
>
> I agree that aligning makes sense, but let's to that on top.
>
> Jan
>
This one breaks CI, likely because we over-clean stamps and then race in case of
parallel builds. Will examine.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-08-19 19:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 17:15 [PATCH v2] Set STAMPCLEAN variable Jan Kiszka
2019-08-13 7:27 ` Claudius Heine
2019-08-13 8:01 ` Jan Kiszka
2019-08-13 8:17 ` Claudius Heine
2019-08-14 12:39 Jan Kiszka
2019-08-14 14:10 ` Claudius Heine
2019-08-14 14:17 ` Jan Kiszka
2019-08-19 19:00 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox