Re: [PATCH 1/3] debianize: make changelog date reproducible

[Anton Mikanovich <amikan@ilbers.de>]

06.09.2021 11:34, Henning Schild wrote:
> Deriving the date from the filesystem and git also does not always
> produce the same result.
>
> In case there is a changelog file and our version does not yet exist
> in it, make the new entry 42s later. If there was no changelog use
> "1970-01-01 00:00:00 UTC".
>
> Reported-by: <Venkata.Pyla@toshiba-tsip.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta/classes/debianize.bbclass | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 44867780f7b9..e6a300700a5f 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -14,20 +14,19 @@ MAINTAINER ??= "Unknown maintainer <unknown@example.com>"
>   
>   deb_add_changelog() {
>   	changelog_v="${CHANGELOG_V}"
> +	timestamp=0
>   	if [ -f ${S}/debian/changelog ]; then
>   		if [ ! -f ${WORKDIR}/changelog.orig ]; then
>   			cp ${S}/debian/changelog ${WORKDIR}/changelog.orig
>   		fi
>   		orig_version=$(dpkg-parsechangelog -l ${WORKDIR}/changelog.orig -S Version)
>   		changelog_v=$(echo "${changelog_v}" | sed 's/<orig-version>/'${orig_version}'/')
> +		orig_date=$(dpkg-parsechangelog -l ${WORKDIR}/changelog.orig -S Date)
> +		orig_seconds=$(date --date="${orig_date}" +'%s')
> +		timestamp=$(echo "${orig_seconds}+42" | bc)
>   	fi
>   
> -	timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" -printf "%T@\n"|sort -n -r|head -n 1)
> -	if [ -n "${timestamp}" ]; then
> -		date=$(LANG=C date -R -d @${timestamp})
> -	else
> -		date=$(LANG=C date -R)
> -	fi
> +	date=$(LANG=C date -R -d @${timestamp})
>   	cat <<EOF > ${S}/debian/changelog
>   ${PN} (${changelog_v}) UNRELEASED; urgency=low
>   

I suggest using expr instead of bc to avoid adding new Isar dependencies.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov