Re: [PATCH 2/5] debianize: move variable defaults to the class that needs them

[Jan Kiszka <jan.kiszka@siemens.com>]

On 29.10.19 17:44, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/debianize.bbclass | 3 +++
>  meta/classes/dpkg-raw.bbclass  | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
> index 33ab4f7..fb9c234 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -5,6 +5,9 @@
>  
>  CHANGELOG_V ?= "${PV}"
>  DPKG_ARCH ??= "any"
> +DEBIAN_DEPENDS ?= ""
> +DESCRIPTION ?= "must not be empty"

Then, shouldn't we rather leave it empty here and fail if it remains so?

> +MAINTAINER ?= "Unknown maintainer <unknown@example.com>"
>  
>  deb_add_changelog() {
>  	timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" -printf "%T@\n"|sort -n -r|head -n 1)
> diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
> index 3f19f8e..8c01a46 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -5,9 +5,6 @@
>  
>  inherit dpkg
>  
> -DEBIAN_DEPENDS ?= ""
> -MAINTAINER ?= "Unknown maintainer <unknown@example.com>"
> -
>  D = "${S}"
>  
>  # Populate folder that will be picked up as package
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux