From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6753266853568577536 X-Received: by 2002:a17:906:594f:: with SMTP id g15mr21023327ejr.197.1573057212771; Wed, 06 Nov 2019 08:20:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:4d51:: with SMTP id b17ls720188ejv.5.gmail; Wed, 06 Nov 2019 08:20:12 -0800 (PST) X-Google-Smtp-Source: APXvYqx67AuGg2Q45p5vZmEwcvMaE3tS9Uoln4RPdBuI4KSesznkzU6HpF+oKlg3Xoqs7RtS3vy+ X-Received: by 2002:a17:906:f0c9:: with SMTP id dk9mr8455695ejb.56.1573057212149; Wed, 06 Nov 2019 08:20:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573057212; cv=none; d=google.com; s=arc-20160816; b=XYaC81SKu6fHVgokIQYY5E1OltzARaCU6w5V5eBRbqPEUvUCHMK53ZV2uvgWtOsK3B ypUpmZyZFaQCzKgxVg18DWCk2EpyVMY4ZdUfMMKUNiAcyrAhUyiRkAbXyqIUvNg/2cSP Eu60XIOEKfkzRhHjUz73/YiX0ZQWogo7OwOzlfMc9zpYCEwD0VEqmNGVcgrX/4AGwp0d K9hRwB8awN01mrcRXBPio21z3X0mzNfBTy57h9k1YnVT5oSuCmsZ6GAJuIfWDuC2NW4u X1pokUTlCiE6Y1mB5u00xPcLHBNX114vcj/AvyTsZTr4b/zKPEjaxNvfTQjdu0obaaxP m07g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Ajc5WWEPeMR4YiG+9Usb8rf7R9tUVk+I5WkAaPVc/u8=; b=cmJYuAkMFS+aRRzUZmisyDnQbvYa+Fc8UTdlms5Z5YKVLg1AhDnUmQB6JU6Dr9EI3a cBt01cFnOPsMSZWUZv2F80OWLZWadKWFfk9tX7JFlm44kuiUIqVHtFgWoGwG10rGAGN+ 9dvjx9d1a9cJZtCDfxRQEGvOe7clpybd6zUS6WWxZLcU6qDmQWAKV6WyImAy7u8Ossd/ pnLuJ/mk1Qrj7fQjD06I7b2JOGYUu/VhNLHuI2g7gGIBrH8gEZU3DtQAFvvTlx003rHy 7POE0LRPQmsPRrOV5nVPv49ywGVZuGICi836HpNaxSORS0zZlIg7P6lx0++mZzVq3M1P sdjA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id l26si7560ejr.0.2019.11.06.08.20.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2019 08:20:12 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id xA6GKBSa003513 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 6 Nov 2019 17:20:11 +0100 Received: from [139.22.41.172] ([139.22.41.172]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id xA6GK9DZ031924; Wed, 6 Nov 2019 17:20:10 +0100 Subject: Re: [PATCH 2/5] debianize: move variable defaults to the class that needs them To: Henning Schild , isar-users@googlegroups.com Cc: "Dalamagkidis, Konstantinos" References: <20191029164424.14681-1-henning.schild@siemens.com> <20191029164424.14681-3-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <822ff1c8-77c7-3835-8722-f8b07f026c23@siemens.com> Date: Wed, 6 Nov 2019 17:20:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191029164424.14681-3-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: cMURWKzMUOV2 On 29.10.19 17:44, Henning Schild wrote: > From: Henning Schild > > Signed-off-by: Henning Schild > --- > meta/classes/debianize.bbclass | 3 +++ > meta/classes/dpkg-raw.bbclass | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass > index 33ab4f7..fb9c234 100644 > --- a/meta/classes/debianize.bbclass > +++ b/meta/classes/debianize.bbclass > @@ -5,6 +5,9 @@ > > CHANGELOG_V ?= "${PV}" > DPKG_ARCH ??= "any" > +DEBIAN_DEPENDS ?= "" > +DESCRIPTION ?= "must not be empty" Then, shouldn't we rather leave it empty here and fail if it remains so? > +MAINTAINER ?= "Unknown maintainer " > > deb_add_changelog() { > timestamp=$(find ${S}/ -type f -not -path "${S}/debian/*" -printf "%T@\n"|sort -n -r|head -n 1) > diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass > index 3f19f8e..8c01a46 100644 > --- a/meta/classes/dpkg-raw.bbclass > +++ b/meta/classes/dpkg-raw.bbclass > @@ -5,9 +5,6 @@ > > inherit dpkg > > -DEBIAN_DEPENDS ?= "" > -MAINTAINER ?= "Unknown maintainer " > - > D = "${S}" > > # Populate folder that will be picked up as package > Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux