From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Fri, 27 Sep 2024 18:32:38 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-oi1-f188.google.com (mail-oi1-f188.google.com [209.85.167.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 48RGWb9V025385 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 27 Sep 2024 18:32:38 +0200 Received: by mail-oi1-f188.google.com with SMTP id 5614622812f47-3e05074e733sf2227261b6e.2 for ; Fri, 27 Sep 2024 09:32:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1727454751; cv=pass; d=google.com; s=arc-20240605; b=OFoK/jb48CMj+1Xcu8zpqhCgIL7nhOtEnMwpIZEcwGpReTSkc2j0yOse66CySfqAo2 OVCFkOFPlwR1k4K7jxHfVnc2fSs5QFItOsiacV0VcpNqCRPY+g6nwDo4IXYBhJ233fIO Fo4LFsQlwD/an4PfAd0w0G5HdJCzD8ljdGKdxF0Fp6tZdA7gmP956f7z4V3menbv9WIu uwojhBwAmCGSjL+JmIrCwZM0QUiHdmr+OfykxBN0z55hHyHRvgYlNU99t/tOGPIVuL8f qnVhP/pXYsRKg+L10oNTUWWq/bnGd4Gei1Q+p/jRwg3HmpcGzohrWh+mKD9VL6HL1d8E XviQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:sender:dkim-signature; bh=snC6wyLIIcdqs3bfBj6KprZMS72I8fPFAQwnxqANFuM=; fh=PbctQXH18WKJKTPMrYXm3wW6tgPAdieDemnWL0qSt80=; b=SScZqmJi3/e6iVPIMq066A/z2M8i2j/IvOncRG/EfLrHRHlYh/iOq72Rg4VEHrk0r9 LfDTsxD7bRrRvOQT3Mxh45JOsv61Xm9EG828w7gFbWKAAhteOIuN6A94DCLabaI3nCkk yVSh/BQOm9QnYTgRocqOkRU1qapvZ5NtYClGeCZIHipGWc+CN1PkrM0wcBrdwWY9BArZ Ba5yBHWMMqEtcP6U6HKS8+BgUxsjaacd1P2w0OZwNL+wfQ7reoTlw8FedL5fD1sgOzk8 z38CtFsl9uBYnJzbber/ysgiUJnjrbS5kpmbT7dOiUPTs85S+8VOdiujrO9KpX6SCQWA IzSw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1727454751; x=1728059551; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :references:in-reply-to:date:to:from:subject:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=snC6wyLIIcdqs3bfBj6KprZMS72I8fPFAQwnxqANFuM=; b=l25FR0U/fHWcrn0YmFBr67TYmgckghW+9Oh5zyzxeBplBFpQeyZ8A8zPsKgm0NQ3yl tJtkZICeDt5ZFIZ1C39CcNsq6cQrl5ZRxhhjUCkXYMKLXN9LtUtadpalzxJBrmbXuoiF PFu8MdnT1AZccnVuYWS91OItCyQaJ5eVPTEHe48ufb8HvhjnTewa53oUdq+VTs3N8z+t 2eMdRCjutctUJISYoXT6RCgzWMeAgnaiYPFjUd3wEAJI1dK6bTHsgpdQIX9JasoWn2uw 9klIROlOODGYNoM4BmlTK71Y+DQu/1y6zqxhgfsTkvWY9gslfCVcd7Fs2o0u8zjm6brW QkVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727454751; x=1728059551; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=snC6wyLIIcdqs3bfBj6KprZMS72I8fPFAQwnxqANFuM=; b=fQuiguzefIPH+BKsum84NegjiciyMtX6jd1fNrNjfV9P4UnzjQ+xc3Szfr3xIK0KOq ZwumD8H27M8kixuJyjTmQY5d/r1iLGsleLM2mH9OIUKnDelr0RzaqokRB1SYb4pLkaEO vx1N9aHn2x0c/CfgQGu9v9fQc2MwxU7seVKpvZBcToGhTCFTvQXRRdWYCM/p1izQF+sm 05XU/ys3wrT8nllv9+f/9pCGCvokD/qupo0LOwqICnZT3p4hKEqr6thewa3rvtg4V3GX EMOEf07+CRrqyvbI6pmI2+UBPeYyHV5MpHzVsg0tTaw3a/rvKidF+Qt4YOHj71h3J77V fFPQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCW9A/ym/DnLjLRcDS+bRsuzyTC45alolc4YKs4AC8BgNJs86Hl0vRnAJhoFMUZNpGflRjoe@ilbers.de X-Gm-Message-State: AOJu0Yz+CDiPcA7+vn+qnRIT02dBynjHjpuM7oefYvRk7fUXOh7sX8e2 In6hlwmBqN0+fV8SAy1ukicas1qZV/1zmASBlwqy2gC+omion9uR X-Google-Smtp-Source: AGHT+IEDZTdyOfuacT2vwhZefexEx4j8dke3+kuyHCBi/ChmvKryQziyDkwIquOjSfkX2XCoVgLnkw== X-Received: by 2002:a05:6871:3a22:b0:260:ffaf:8126 with SMTP id 586e51a60fabf-287109c8ee5mr2904705fac.9.1727454751232; Fri, 27 Sep 2024 09:32:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6871:5307:b0:270:5705:a448 with SMTP id 586e51a60fabf-286f9198265ls3126604fac.1.-pod-prod-07-us; Fri, 27 Sep 2024 09:32:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWJBcaljaCtAMtEP2LthMlAFhsN7fYn7wNH1CNl1ZQswAglnzkWkVCWwd2e0HXEjV+//N0BilZoCxLE@googlegroups.com X-Received: by 2002:a05:6870:3281:b0:267:dfce:95eb with SMTP id 586e51a60fabf-287109c0648mr3235855fac.5.1727454750408; Fri, 27 Sep 2024 09:32:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727454750; cv=none; d=google.com; s=arc-20240605; b=fpYNp208+Ju3YHfLf9vPE7GtW9RE0Pq1q+SdW1G/pQXTKr0I/lcq6M02vzF3pSC2EL 01ov9FhOY7f8+/XJhcmovvF/DTA4FYMj8Sx/IrRv11Q0mW8wafd9ySnr08RBTN93RaFE d+9BitxLHS8uBnuecCSTBza7webUDRY88Dq0N/BU7RV5S9mQdKvA4dKpDO7Vzea5MS8B Rd4Ya5rDxBqKN4xnn9dtwyXbWmGi+3bkJa6zEkyEzz1Ut+sVhuWMJK/wiNV1W2TTHcPe opilWwn0RafQVIpau4Dj0TR3yR9/jJZPkB0EhCYSN/ATdMflLKeNKKF95afxXbZi5PJb wB9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=ef/yOsRI6uBd1H1fypbOXqaryC50e9Xm5B8b9Ahzr9I=; fh=O+ZMFUiiuyZKsfz7Fw8hsdknZlxcSFSsLsCydBEGD0o=; b=VEwdjyHsSBxczxZPUSwZhCMG9hQDvriVq69NMlN73XurGKQa6WIrQmFymojv3bLwfe IezmCW75CwWENYN9IzrJPqZ4nCojSjfVpfW7zaDz44hxkys7yLUJXmwwGOkhgMQWvpa7 oNK4dkIGAt/J04RGnaOF36l8Xzm609bXLa0XK1dkixFKBPjZviUqOFIlS2akZcVMyDh9 oZ1oVSDJxYj7mJVUstXr4fEUZ6rjXCNdBGzFxkppWrLACpS4xqFMNqeBki6ndE/mQG2n 3qSa6/FCX51j7wRtR+E9JfhD0hbNcdAcZbxKzmdPHwBSs66Fo96CWEVJ1/eO5PVmgb49 MAIQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 586e51a60fabf-2870fa39bd2si127830fac.5.2024.09.27.09.32.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Sep 2024 09:32:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 48RGWQd8025370 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 18:32:27 +0200 Message-ID: <8241287c797aff79f4cbd359e6d2f72b8f12debd.camel@ilbers.de> Subject: Re: [PATCH] Fix linux build under sid and trixie From: Uladzimir Bely To: Jan Kiszka , isar-users@googlegroups.com Date: Fri, 27 Sep 2024 19:32:25 +0300 In-Reply-To: <4634748f-5979-4142-9aef-f21da941e95a@siemens.com> References: <20240927063647.25660-1-ubely@ilbers.de> <4634748f-5979-4142-9aef-f21da941e95a@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: 3kqVTa7cAoqF On Fri, 2024-09-27 at 15:14 +0200, Jan Kiszka wrote: > On 27.09.24 08:36, Uladzimir Bely wrote: > > The patch for kernel is taken from the upstream where it > > was applied since linux-6.8. >=20 > This does not make any sense. Update the stable version. >=20 > Jan >=20 Hello. Actually, build fails only for starfive target that uses non-mainline custom linux repo not haveing a branch with linux >=3D 6.7. I think, the patch is worth applying at least for linux-starfive_6.6- visionfive2.bb. Other targets are using bookworm at most, so for could leave them as is for now. What do you think? > >=20 > > Signed-off-by: Uladzimir Bely > > --- > > =C2=A0...oc-arguments-order-in-btrfs_ioctl_se.patch | 43 > > +++++++++++++++++++ > > =C2=A0.../linux/linux-mainline_6.6.11.bb=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 + > > =C2=A0.../linux/linux-starfive_6.6-visionfive2.bb=C2=A0=C2=A0 |=C2=A0 1= + > > =C2=A03 files changed, 45 insertions(+) > > =C2=A0create mode 100644 meta-isar/recipes-kernel/linux/files/0001- > > btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > >=20 > > diff --git a/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix- > > kvcalloc-arguments-order-in-btrfs_ioctl_se.patch b/meta- > > isar/recipes-kernel/linux/files/0001-btrfs-fix-kvcalloc-arguments- > > order-in-btrfs_ioctl_se.patch > > new file mode 100644 > > index 00000000..afe09eab > > --- /dev/null > > +++ b/meta-isar/recipes-kernel/linux/files/0001-btrfs-fix-kvcalloc- > > arguments-order-in-btrfs_ioctl_se.patch > > @@ -0,0 +1,43 @@ > > +From 6ff09b6b8c2fb6b3edda4ffaa173153a40653067 Mon Sep 17 00:00:00 > > 2001 > > +From: Dmitry Antipov > > +Date: Thu, 21 Dec 2023 11:47:45 +0300 > > +Subject: [PATCH] btrfs: fix kvcalloc() arguments order in > > btrfs_ioctl_send() > > + > > +When compiling with gcc version 14.0.0 20231220 (experimental) > > +and W=3D1, I've noticed the following warning: > > + > > +fs/btrfs/send.c: In function 'btrfs_ioctl_send': > > +fs/btrfs/send.c:8208:44: warning: 'kvcalloc' sizes specified with > > 'sizeof' > > +in the earlier argument and not in the later argument [-Wcalloc- > > transposed-args] > > + 8208 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sctx->clone_ro= ots =3D kvcalloc(sizeof(*sctx- > > >clone_roots), > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ > > + > > +Since 'n' and 'size' arguments of 'kvcalloc()' are multiplied to > > +calculate the final size, their actual order doesn't affect the > > result > > +and so this is not a bug. But it's still worth to fix it. > > + > > +Signed-off-by: Dmitry Antipov > > +Reviewed-by: David Sterba > > +Signed-off-by: David Sterba > > +--- > > + fs/btrfs/send.c | 4 ++-- > > + 1 file changed, 2 insertions(+), 2 deletions(-) > > + > > +diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c > > +index 4e36550618e5..2d7519a6ce72 100644 > > +--- a/fs/btrfs/send.c > > ++++ b/fs/btrfs/send.c > > +@@ -8205,8 +8205,8 @@ long btrfs_ioctl_send(struct inode *inode, > > struct btrfs_ioctl_send_args *arg) > > +=C2=A0 goto out; > > +=C2=A0 } > > +=20 > > +- sctx->clone_roots =3D kvcalloc(sizeof(*sctx->clone_roots), > > +- =C2=A0=C2=A0=C2=A0=C2=A0 arg->clone_sources_count + 1, > > ++ sctx->clone_roots =3D kvcalloc(arg->clone_sources_count + 1, > > ++ =C2=A0=C2=A0=C2=A0=C2=A0 sizeof(*sctx->clone_roots), > > +=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 GFP_KERNEL); > > +=C2=A0 if (!sctx->clone_roots) { > > +=C2=A0 ret =3D -ENOMEM; > > +--=20 > > +2.45.2 > > + > > diff --git a/meta-isar/recipes-kernel/linux/linux- > > mainline_6.6.11.bb b/meta-isar/recipes-kernel/linux/linux- > > mainline_6.6.11.bb > > index 2287e763..147d05df 100644 > > --- a/meta-isar/recipes-kernel/linux/linux-mainline_6.6.11.bb > > +++ b/meta-isar/recipes-kernel/linux/linux-mainline_6.6.11.bb > > @@ -11,6 +11,7 @@ ARCHIVE_VERSION =3D "${@ d.getVar('PV')[:-2] if > > d.getVar('PV').endswith('.0') else > > =C2=A0 > > =C2=A0SRC_URI +=3D " \ > > =C2=A0=C2=A0=C2=A0=C2=A0 > > https://cdn.kernel.org/pub/linux/kernel/v6.x/linux-${ARCHIVE_VERSION}.t= ar.xz > > =C2=A0\ > > +=C2=A0=C2=A0=C2=A0 > > file://0001-btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > > =C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 file://x86_64_defconfig=C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 file://ftpm-module.cfg=C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 file://subdir/no-ubifs-fs.cfg=C2=A0\ > > diff --git a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > index f4dd5c9a..a267241f 100644 > > --- a/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > +++ b/meta-isar/recipes-kernel/linux/linux-starfive_6.6- > > visionfive2.bb > > @@ -8,6 +8,7 @@ require recipes-kernel/linux/linux-custom.inc > > =C2=A0SRC_URI +=3D " \ > > =C2=A0=C2=A0=C2=A0=C2=A0 > > https://github.com/starfive-tech/linux/archive/${SRCREV}.tar.gz;downloa= dfilename=3Dlinux-starfive-${SRCREV}.tar.gz > > =C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 > > file://0001-riscv-efistub-Ensure-GP-relative-addressing-is-not-u.patch > > =C2=A0\ > > +=C2=A0=C2=A0=C2=A0 > > file://0001-btrfs-fix-kvcalloc-arguments-order-in-btrfs_ioctl_se.patch > > =C2=A0\ > > =C2=A0=C2=A0=C2=A0=C2=A0 file://starfive2_extra.cfg" > > =C2=A0SRCREV =3D "9fe004eaf1aa5b23bd5d03b4cfe9c3858bd884c4" > > =C2=A0SRC_URI[sha256sum] =3D > > "9eaf7659aa57e2c5b399b7b33076f1376ec43ef343680e0a57e0a2a9bef6c0ae" >=20 --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/8241287c797aff79f4cbd359e6d2f72b8f12debd.camel%40ilbers.de.