Re: [PATCH v3] Replace ISARROOT with more relevant variables

[vijai kumar <vijaikumar.kanagarajan@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2354 bytes --]



On Tuesday, May 26, 2020 at 1:21:05 PM UTC+5:30, Baurzhan Ismagulov wrote:
>
> Hello Vijai Kumar, 
>
> On Mon, May 25, 2020 at 07:54:57PM -0700, vijai kumar wrote: 
> > Any review comments on this? 
>
> This looks good to me, sorry for the delay. I had held this because it 
> happens 
> to conflict with the hardlinking series which arrived earlier. However, 
> we've 
> newly discovered that the latter seems to have problems with its test 
> case, so 
> I tend to pick the one that could be applied first. 
>

Thanks for the update Baurzhan. Good to know its in pipeline.

BR,
Vijai Kumar K
 

>
> With kind regards, 
> Baurzhan. 
>
>
> > On Monday, April 27, 2020 at 3:59:07 PM UTC+5:30, vijai kumar wrote: 
> > > 
> > > From: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> 
> > > 
> > > When switching between two ISAR workspaces in the same shell 
> > > session, the ISARROOT setting of the previous workspace would be 
> > > picked up for the new workspace resulting in an incorrect 
> > > configuration. The user had to manually unset ISARROOT to avoid 
> > > any issues. 
> > > 
> > > As like OEROOT in OE, let us unset ISARROOT at the end of the 
> > > initialization script. This helps us to avoid the above issue 
> > > and also preserves support for passing ISARROOT from a caller 
> > > script as in OE. 
> > > 
> > > ISARROOT is used mostly to derive the location of bitbake, scripts, 
> > > testsuite, meta and meta-isar directories. 
> > > 
> > > Layers like meta, meta-isar already have their paths in LAYERDIR_core 
> > > and LAYERDIR_isar which can be used. For other directories introduce 
> > > dedicated variables BITBAKEDIR, SCRIPTSDIR and TESTSUITEDIR. 
> > > 
> > > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com <javascript:>> 
>
> > > --- 
> > > Changes in v3: 
> > >     - Send patch using proper send. 
> > > Changes in v2: 
> > >     - Approach using dedicated variables for each commonly used 
> > > directories. 
> > > 
> > >  isar-init-build-env                      |  1 + 
> > >  meta/classes/image-sdk-extension.bbclass |  2 +- 
> > >  meta/classes/wic-img.bbclass             | 31 
> ++++++++++++------------ 
> > >  scripts/ci_build.sh                      | 12 +++++---- 
> > >  scripts/isar-buildenv-internal           |  7 ++++-- 
> > >  5 files changed, 30 insertions(+), 23 deletions(-) 
>

[-- Attachment #1.2: Type: text/html, Size: 3510 bytes --]