From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6787079713742389248 Date: Wed, 27 May 2020 22:28:02 -0700 (PDT) From: vijai kumar To: isar-users Message-Id: <82870cfb-cacf-4f15-89a2-b0e9b2213ec3@googlegroups.com> In-Reply-To: <20200526075101.4iipq63ke245qrpn@yssyq.m.ilbers.de> References: <20200427102837.1755-1-Vijaikumar_Kanagarajan@mentor.com> <20200526075101.4iipq63ke245qrpn@yssyq.m.ilbers.de> Subject: Re: [PATCH v3] Replace ISARROOT with more relevant variables MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_52_1541685056.1590643682751" X-Google-Token: EOKXvfYFDropWrqsEYQ0 X-Google-IP: 192.94.34.34 X-TUID: MWMar4qgmxqw ------=_Part_52_1541685056.1590643682751 Content-Type: multipart/alternative; boundary="----=_Part_53_1445331310.1590643682751" ------=_Part_53_1445331310.1590643682751 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Tuesday, May 26, 2020 at 1:21:05 PM UTC+5:30, Baurzhan Ismagulov wrote: > > Hello Vijai Kumar, > > On Mon, May 25, 2020 at 07:54:57PM -0700, vijai kumar wrote: > > Any review comments on this? > > This looks good to me, sorry for the delay. I had held this because it > happens > to conflict with the hardlinking series which arrived earlier. However, > we've > newly discovered that the latter seems to have problems with its test > case, so > I tend to pick the one that could be applied first. > Thanks for the update Baurzhan. Good to know its in pipeline. BR, Vijai Kumar K > > With kind regards, > Baurzhan. > > > > On Monday, April 27, 2020 at 3:59:07 PM UTC+5:30, vijai kumar wrote: > > > > > > From: Vijai Kumar K > > > > > > > When switching between two ISAR workspaces in the same shell > > > session, the ISARROOT setting of the previous workspace would be > > > picked up for the new workspace resulting in an incorrect > > > configuration. The user had to manually unset ISARROOT to avoid > > > any issues. > > > > > > As like OEROOT in OE, let us unset ISARROOT at the end of the > > > initialization script. This helps us to avoid the above issue > > > and also preserves support for passing ISARROOT from a caller > > > script as in OE. > > > > > > ISARROOT is used mostly to derive the location of bitbake, scripts, > > > testsuite, meta and meta-isar directories. > > > > > > Layers like meta, meta-isar already have their paths in LAYERDIR_core > > > and LAYERDIR_isar which can be used. For other directories introduce > > > dedicated variables BITBAKEDIR, SCRIPTSDIR and TESTSUITEDIR. > > > > > > Signed-off-by: Vijai Kumar K > > > > > --- > > > Changes in v3: > > > - Send patch using proper send. > > > Changes in v2: > > > - Approach using dedicated variables for each commonly used > > > directories. > > > > > > isar-init-build-env | 1 + > > > meta/classes/image-sdk-extension.bbclass | 2 +- > > > meta/classes/wic-img.bbclass | 31 > ++++++++++++------------ > > > scripts/ci_build.sh | 12 +++++---- > > > scripts/isar-buildenv-internal | 7 ++++-- > > > 5 files changed, 30 insertions(+), 23 deletions(-) > ------=_Part_53_1445331310.1590643682751 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Tuesday, May 26, 2020 at 1:21:05 PM UTC+5:30, B= aurzhan Ismagulov wrote:
Hello = Vijai Kumar,

On Mon, May 25, 2020 at 07:54:57PM -0700, vijai kumar wrote:
> Any review comments on this?

This looks good to me, sorry for the delay. I had held this because it = happens
to conflict with the hardlinking series which arrived earlier. However,= we've
newly discovered that the latter seems to have problems with its test c= ase, so
I tend to pick the one that could be applied first.

Thanks for the update Baurzhan. Good t= o know its in pipeline.

BR,
Vijai Kumar = K
=C2=A0

With kind regards,
Baurzhan.


> On Monday, April 27, 2020 at 3:59:07 PM UTC+5:30, vijai kumar wrot= e:
> >
> > From: Vijai Kumar K <Vijaikumar_...@mentor.com>=20
> >
> > When switching between two ISAR workspaces in the same shell= =20
> > session, the ISARROOT setting of the previous workspace would= be=20
> > picked up for the new workspace resulting in an incorrect=20
> > configuration. The user had to manually unset ISARROOT to avo= id=20
> > any issues.=20
> >
> > As like OEROOT in OE, let us unset ISARROOT at the end of the= =20
> > initialization script. This helps us to avoid the above issue= =20
> > and also preserves support for passing ISARROOT from a caller= =20
> > script as in OE.=20
> >
> > ISARROOT is used mostly to derive the location of bitbake, sc= ripts,=20
> > testsuite, meta and meta-isar directories.=20
> >
> > Layers like meta, meta-isar already have their paths in LAYER= DIR_core=20
> > and LAYERDIR_isar which can be used. For other directories in= troduce=20
> > dedicated variables BITBAKEDIR, SCRIPTSDIR and TESTSUITEDIR.= =20
> >
> > Signed-off-by: Vijai Kumar K <Vijaikumar_...@mentor.com>=20
> > ---=20
> > Changes in v3:=20
> > =C2=A0 =C2=A0 - Send patch using proper send.=20
> > Changes in v2:=20
> > =C2=A0 =C2=A0 - Approach using dedicated variables for each c= ommonly used=20
> > directories.=20
> >
> > =C2=A0isar-init-build-env =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A01 +=20
> > =C2=A0meta/classes/image-sdk-extension.bbclass | =C2=A02= +-=20
> > =C2=A0meta/classes/wic-img.bbclass =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 31 ++++++++++++------------=20
> > =C2=A0scripts/ci_build.sh =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 12 +++++----=20
> > =C2=A0scripts/isar-buildenv-internal =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | =C2=A07 ++++--=20
> > =C2=A05 files changed, 30 insertions(+), 23 deletions(-)=20
------=_Part_53_1445331310.1590643682751-- ------=_Part_52_1541685056.1590643682751--