From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6520143438976909312 X-Received: by 10.223.169.44 with SMTP id u41mr165046wrc.3.1518104832109; Thu, 08 Feb 2018 07:47:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.187.140 with SMTP id q12ls1472079wrg.9.gmail; Thu, 08 Feb 2018 07:47:11 -0800 (PST) X-Google-Smtp-Source: AH8x226WcdM8OZsBAYFnUyXydcohmA4x6uWV8lWEb3j9QyQjQrOEackP5Ilh8T1NJoUteoGhAGEx X-Received: by 10.223.133.198 with SMTP id 6mr164913wru.31.1518104831387; Thu, 08 Feb 2018 07:47:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518104831; cv=none; d=google.com; s=arc-20160816; b=Dvsntp+X0TadDJqXXD1I/b9+jUMySf9Q3JHZLRK6OVrTGWcFcubtaRUP0/EKx6Bvb/ JHFhcyPSLtutAhNgVPL96vgAoT82h1G+B13ZS32SDPEbAdzAjQBw5y2+Kba73M2AyHIz JPSFv3xNe6xJ0iX8pHNoQIRvYrH2duokaPjOBRvXl18JREfEaHIh+le1fYUnHUdy5sFu jD7/6DByZ9Rf7k6O5gcxALDQmpobFw4Dl45aKOMkTovMUupAZ52IcChWI2CTjD2wPrnC qgN8ZM1Oj68qJZkpxPSnDd/kwoBeeWJlYDocPs/T68CBdiwyYqZYftcmWfMXxrHVMaAX +hag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=sekiIRNMlXXeis9pTubjYeqTn7fsrDugqXUmpFo8tkE=; b=o9/4cqijgqjMfhz198dc+6Xio+n7pIwZYpUu5w7quFUfzyff7wCX1QsultIbWvWx0R VRbwwrmUPFvgRVDVxoMNcDr2m4iuuJqrDVQGKA62AEBx0xelckG1MwB4ohbNfz1jDpJc bgO/NCtN3nDbAjF7FZz4xojePWmDoW/CAIhNmj828+NdM+gmuVqrj7tukxFZ2dvwjMaS L0iYoSQx/0B7fu2QdPZu3ukCOV9qKrijYPjiasD8trQqrVIffdBPcBi4ivTSi1fLoAVx FNvpkhMTHnQwL+HAnTYG5RD0Z6JEln2CKUiV5PQU/gGWYmZIgZ+wJzDr3rOcn0SNsPpd WyBQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id f192si9388wmg.1.2018.02.08.07.47.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 07:47:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w18Fl60O001754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 8 Feb 2018 16:47:08 +0100 Subject: Re: [PATCH] meta/classes/base: Fix showdata and liststasks after bitbake update To: "Kiszka, Jan" , isar-users@googlegroups.com Cc: Claudius Heine References: <20180208112622.3373-1-claudius.heine.ext@siemens.com> <26d4eb02-20c1-c6a4-8c7a-f040d4c2d51d@siemens.com> From: Alexander Smirnov Message-ID: <82baf706-82ff-63f2-04bb-a5e3b17b6229@ilbers.de> Date: Thu, 8 Feb 2018 18:47:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <26d4eb02-20c1-c6a4-8c7a-f040d4c2d51d@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: po9jDYyno2Ch On 02/08/2018 06:24 PM, Claudius Heine wrote: > Hi Alex, > > On 02/08/2018 02:55 PM, Alexander Smirnov wrote: >> Hi, >> >> On 02/08/2018 02:26 PM, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> Those tasks were broken, this patchs fixes by implementing them similar >>> to how openembedded-core does it. >>> >> >> I see that this code is identical to OE one, do you know which >> copyright it is? If this code is copied from OE, I think it makes >> sense to mention this explicitly in the code. > > Sure, I got it from [1], and this file does not have an own header, so I > suppose its MIT or GPLv2. I don't know if this falls under 'metadata' or > not. Since Isar uses the same licenses, you might know what exactly is > meant by that. > > How are you proposing to name the authors? I see it something like: # Derived from openembedded-core/meta/classes/utility-tasks.bbclass @Jan: do you think we should keep this reference? Alex > > Cheers, > Claudius > > [1] > http://git.openembedded.org/openembedded-core/tree/meta/classes/utility-tasks.bbclass > > >> >> Alex >> >>> Signed-off-by: Claudius Heine >>> --- >>>   meta/classes/base.bbclass | 28 +++++++++++++++++----------- >>>   1 file changed, 17 insertions(+), 11 deletions(-) >>> >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >>> index 7d44f72..448dd67 100644 >>> --- a/meta/classes/base.bbclass >>> +++ b/meta/classes/base.bbclass >>> @@ -40,22 +40,28 @@ bbfatal() { >>>   addtask showdata >>>   do_showdata[nostamp] = "1" >>>   python do_showdata() { >>> -    import sys >>> -    # emit variables and shell functions >>> -    bb.data.emit_env(sys.__stdout__, d, True) >>> -    # emit the metadata which isnt valid shell >>> -    for e in bb.data.keys(d): >>> -        if bb.data.getVarFlag(e, 'python', d): >>> -            sys.__stdout__.write("\npython %s () {\n%s}\n" % (e, >>> bb.data.getVar(e, d, 1))) >>> +    for e in d.keys(): >>> +        if d.getVarFlag(e, 'python'): >>> +            bb.plain("\npython %s () {\n%s}\n" % (e, d.getVar(e, >>> True))) >>>   } >>>   addtask listtasks >>>   do_listtasks[nostamp] = "1" >>>   python do_listtasks() { >>> -    import sys >>> -    for e in bb.data.keys(d): >>> -        if bb.data.getVarFlag(e, 'task', d): >>> -            sys.__stdout__.write("%s\n" % e) >>> +    taskdescs = {} >>> +    maxlen = 0 >>> +    for e in d.keys(): >>> +        if d.getVarFlag(e, 'task'): >>> +            maxlen = max(maxlen, len(e)) >>> +            if e.endswith('_setscene'): >>> +                desc = "%s (setscene version)" % >>> (d.getVarFlag(e[:-9], 'doc') or '') >>> +            else: >>> +                desc = d.getVarFlag(e, 'doc') or '' >>> +            taskdescs[e] = desc >>> + >>> +    tasks = sorted(taskdescs.keys()) >>> +    for taskname in tasks: >>> +        bb.plain("%s  %s" % (taskname.ljust(maxlen), >>> taskdescs[taskname])) >>>   } >>>   do_fetch[dirs] = "${DL_DIR}" >>> > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov