public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Badrikesh Prusty <badrikesh.prusty@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 1/2] linux-module: use generated changelog instead of debian/changelog.tmpl
Date: Tue, 18 Feb 2025 09:48:30 +0300	[thread overview]
Message-ID: <8337640297b97bc37a51ec398ff14fa672891aae.camel@ilbers.de> (raw)
In-Reply-To: <20250209100017.413168-1-badrikesh.prusty@siemens.com>

On Sun, 2025-02-09 at 15:30 +0530, 'Badrikesh Prusty' via isar-users
wrote:
> The debian/changelog.tmpl file contains hardcoded values for the
> timestamp and
> maintainer fields, resulting in incorrect build info in the generated
> binary.
> Use the generated changelog to ensure accurate build info.
> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  meta/recipes-kernel/linux-module/files/debian/changelog.tmpl | 5 ---
> --
>  meta/recipes-kernel/linux-module/module.inc                  | 3 ++-
>  2 files changed, 2 insertions(+), 6 deletions(-)
>  delete mode 100644 meta/recipes-kernel/linux-
> module/files/debian/changelog.tmpl
> 
> diff --git a/meta/recipes-kernel/linux-
> module/files/debian/changelog.tmpl b/meta/recipes-kernel/linux-
> module/files/debian/changelog.tmpl
> deleted file mode 100644
> index 6e59e062..00000000
> --- a/meta/recipes-kernel/linux-module/files/debian/changelog.tmpl
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -${PN} (${PV}) unstable; urgency=low
> -
> -  * Generated package.
> -
> - -- ISAR project <isar-users@googlegroups.com>  Tue, 6 Feb 2018
> 00:00:00 +0000
> diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc
> index 3e8e5e7a..be3ea3f7 100644
> --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -43,7 +43,6 @@ python() {
>  inherit dpkg
>  
>  TEMPLATE_FILES = "debian/control.tmpl \
> -                  debian/changelog.tmpl \
>                    debian/rules.tmpl"
>  TEMPLATE_VARS += " \
>      KERNEL_NAME \
> @@ -68,6 +67,8 @@ do_prepare_build() {
>      rm -rf ${S}/debian
>      cp -r ${WORKDIR}/debian ${S}/
>  
> +    deb_add_changelog
> +
>      for module in ${AUTOLOAD}; do
>          echo "echo $module >> /etc/modules" >> ${S}/debian/postinst
>      done
> -- 
> 2.39.5
> 

Applied to next, thanks.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/8337640297b97bc37a51ec398ff14fa672891aae.camel%40ilbers.de.

      parent reply	other threads:[~2025-02-18  6:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-09 10:00 'Badrikesh Prusty' via isar-users
2025-02-09 10:00 ` [PATCH 2/2] linux-module: Pass MAINTAINER via TEMPLATE_VAR in debian/control.tmpl 'Badrikesh Prusty' via isar-users
2025-02-18  6:48 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8337640297b97bc37a51ec398ff14fa672891aae.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=badrikesh.prusty@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox