From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6735324566843817984 X-Received: by 2002:a7b:cc13:: with SMTP id f19mr2955912wmh.141.1568190283205; Wed, 11 Sep 2019 01:24:43 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:1a96:: with SMTP id a144ls873563wma.3.gmail; Wed, 11 Sep 2019 01:24:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFgpbfdbKOY8UbN3vzitRJVXFY9yL90ETgAJY9a0uItzAzA/kY9AIqk77JeEZJaD28R3Ep X-Received: by 2002:a7b:cc0a:: with SMTP id f10mr3041931wmh.6.1568190282687; Wed, 11 Sep 2019 01:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568190282; cv=none; d=google.com; s=arc-20160816; b=ora8UOgHvgZEAIgFilKpPWGdkRrQiN2Fj/+hs4pYqC0ZGsLKRjiHGAiVv5zEKazm5O 37AmrFZtXb+tivNgyry5f4p8A2IdRPxCk4suPGT+MICrVxpIYDqCmiLsNomorLcgMEcN kccfLDYYBrLMaOKhhM9ZxLlXVJQXKGP4+XgJSeS3KL9i6E5xlDKocFtOOzyBHI3PIUT7 aTsw9PoYKvGOzghuh/Kl33KwJD2B6Ok9YzSLPL0DC1BzkCySqLMiYm5cEdjKv7oOlJMh QaNgRZwteXh81K1makOSqYax/BIXliCZqjxuoZkY8nPaQe7+XcFL0sxs4f1imCfmjRXL j8aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=3pWNWG2HE2DurGxsGtteuIE/gyEMo0XX36AO4rDd5+s=; b=eu3dqw2XKdBI/MMLJqGPGB4ytKLF7Q3hvu3vvEHW+OkVWbJdp3ZI/+vCp/GAuxAgOs xhQqWTbLH2YeazMEUCf3KNJ5/uJTLHQSX4Uz/kbb1TBX2giKE8OoUTKydNQDiR6TI3cU WByLhbxQYQlr3oDapBjsvLZkbh0wZgSIJiGGsisiy7c8ashUzjq3Z6erXqf6td32WQiE UTsoSmr/n6Yfw+oMHuichFFEtOn9TWePOGScvMEESHqP3wpSOXSkt1VIG+wch/hQHu89 E8uU3fc93uKBuzJ4mPSbUHbk0q+vMyREnoO90XAfWgUHM6Ha+zbTQCSEhzd7GZPnJgqC cJqQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id m6si121672wmc.0.2019.09.11.01.24.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2019 01:24:42 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x8B8Og8H006934 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 11 Sep 2019 10:24:42 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x8B8Odsg011543; Wed, 11 Sep 2019 10:24:39 +0200 Subject: Re: [PATCH] Do not clobber policy-rc.d if it already exists To: "[ext] Dalamagkidis, Konstantinos" , "isar-users@googlegroups.com" References: <20190911081906.16662-1-konstantinos.dalamagkidis@siemens.com> From: Jan Kiszka Message-ID: <8350982c-8551-f65c-537b-cd1b9d945351@siemens.com> Date: Wed, 11 Sep 2019 10:24:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190911081906.16662-1-konstantinos.dalamagkidis@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 9mBqMw/iOXH8 On 11.09.19 10:19, [ext] Dalamagkidis, Konstantinos wrote: > We had the problem that our policy-rc.d was removed by the chroot-setup > script. This proposed patch uses the mechanism used for the > start-stop-daemon. Your signed-off line is missing, to declare https://developercertificate.org. > --- > meta/recipes-core/isar-bootstrap/files/chroot-setup.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh > index f84f63a..4150011 100644 > --- a/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh > +++ b/meta/recipes-core/isar-bootstrap/files/chroot-setup.sh > @@ -78,6 +78,9 @@ chroot_setup() { > # Create a policy-rc.d to stop maintainer scripts using invoke-rc.d > # from running init scripts. In case of maintainer scripts that do not > # use invoke-rc.d, add a dummy start-stop-daemon. > + if [ -e "/${TARGET}/sbin/policy-rc.d" ]; then > + divert "${TARGET}" /sbin/policy-rc.d > + fi > cat > "/${TARGET}/usr/sbin/policy-rc.d" <<-EOF > #!/bin/sh > exit 101 > @@ -114,7 +117,7 @@ chroot_cleanup() { > > check_target "${TARGET}" || return 1 > > - rm -f "/${TARGET}/usr/sbin/policy-rc.d" > + undivert "${TARGET}" /usr/sbin/policy-rc.d > undivert "${TARGET}" /sbin/start-stop-daemon > if [ -x "/${TARGET}/sbin/initctl.REAL" ]; then > undivert "${TARGET}" /sbin/initctl > Seems reasonable to me. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux