From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] claudius.heine.ext@siemens.com"
<claudius.heine.ext@siemens.com>,
isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: Re: [RFC PATCH v2 0/1] Template system
Date: Mon, 4 Feb 2019 12:59:10 +0100 [thread overview]
Message-ID: <8374dd66-ffea-8ea2-f454-80c57f9cd829@siemens.com> (raw)
In-Reply-To: <20190204113737.19784-1-claudius.heine.ext@siemens.com>
On 04.02.19 12:37, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> Hi,
>
> here is an alternative implementation of the template system.
>
> Instead of a shell function, here the templates are processed in one
> additional task. The interface to this task are two variables
> (TEMPLATE_FILES and TEMPLATE_VARS).
>
> The advantage of this additional task compared to the shell function is
> that the template variables are not exported, so only this task will be
> reexecuted if those are changed. Not other independent shell tasks.
>
Looks good to me, both interface and overall implementation.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2019-02-04 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 11:37 claudius.heine.ext
2019-02-04 11:37 ` [RFC PATCH v2 1/1] meta: added do_transform_template task as templating system and switch claudius.heine.ext
2019-02-04 11:59 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8374dd66-ffea-8ea2-f454-80c57f9cd829@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=ch@denx.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox