From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a7b:cd83:: with SMTP id y3mr504359wmj.7.1549281552729; Mon, 04 Feb 2019 03:59:12 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:9d28:: with SMTP id k40ls3321709wre.12.gmail; Mon, 04 Feb 2019 03:59:12 -0800 (PST) X-Google-Smtp-Source: AHgI3IbCSRXT7Csgm9xchTxv965jA/iZj7ULAxPi7kCi0qfWqm5Ofx/w2bHxNHoTchVM047yt42z X-Received: by 2002:adf:b314:: with SMTP id j20mr1912032wrd.4.1549281552226; Mon, 04 Feb 2019 03:59:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549281552; cv=none; d=google.com; s=arc-20160816; b=UygBcCV3unVF7QwLKJ21IcOGHC5Lka+8614UWkl33LmZUIW3uct3IU2WJusUDAjG/H /45/dfShTvpxZ7uAtbXnDSz4ncz6MU8SIa8awwah8rDhGGTbOuIV1f180LSgijiFfVkA MFo0toBo7cjhCKaKNsGikJSPwCY4D0oEbumzbs3oGXC/TJNbhsuDMuJbBXzDr8adGXMD LLBWJ/h63P6uoHS3XV3LCgAiP1j7Ff6Q8J+FB9fVuZD3mmekxRV+aqA7GGKXzYoXqrlm t8mUzpUx5wREZ2lYCn7m23GjcT+j00ooTOzpl88PT7sCStNt+glkO7J7H7Ix8A5Al5Jk 03Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=5shu8Fc/mhD8bxoROPzUncYas1rikXmtRE3w9WUlP3Q=; b=aiNl6egpRyJOZDu/YG4SOm90ZvM3t92xamZy8H5D9NFTPMsQGoUP/nt0HR+eXsBTzX nWqtN2OM+Xuur+5/SWkb7qY8hMP5qaiK2vJbXonCFhKi9Kpn7QdPq6rxf45JzsZdYLAv qZE540RP8hM3msBFy5j0oDzx2E5T5tVH8MHVDXeH5dtWC6NukDHIMhuzBn7/kfDX76a8 o2USuSc62oMJ0qOFkutG7dFR5xlQ5DqmkloKiyrJXFLK9Bsz3kg3Q4A7UFcBoILLJi12 PufAFxyCCv0zcKhY9xFf7CYUIbn/wHaMIm/rk8uCdMkan5dXBZatFBz6FJYoMExZ584d BYkQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id 64si403066wma.1.2019.02.04.03.59.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 03:59:12 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x14BxBAg005995 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Feb 2019 12:59:11 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x14BxBMb011253; Mon, 4 Feb 2019 12:59:11 +0100 Subject: Re: [RFC PATCH v2 0/1] Template system To: "[ext] claudius.heine.ext@siemens.com" , isar-users@googlegroups.com Cc: Claudius Heine References: <20190204113737.19784-1-claudius.heine.ext@siemens.com> From: Jan Kiszka Message-ID: <8374dd66-ffea-8ea2-f454-80c57f9cd829@siemens.com> Date: Mon, 4 Feb 2019 12:59:10 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190204113737.19784-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ey+JrEJYNVNm On 04.02.19 12:37, [ext] claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > Hi, > > here is an alternative implementation of the template system. > > Instead of a shell function, here the templates are processed in one > additional task. The interface to this task are two variables > (TEMPLATE_FILES and TEMPLATE_VARS). > > The advantage of this additional task compared to the shell function is > that the template variables are not exported, so only this task will be > reexecuted if those are changed. Not other independent shell tasks. > Looks good to me, both interface and overall implementation. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux