From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Tue, 27 Aug 2024 18:49:33 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lf1-f59.google.com (mail-lf1-f59.google.com [209.85.167.59]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 47RGnWjR024283 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 27 Aug 2024 18:49:32 +0200 Received: by mail-lf1-f59.google.com with SMTP id 2adb3069b0e04-5334844dcc5sf5463603e87.0 for ; Tue, 27 Aug 2024 09:49:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1724777367; cv=pass; d=google.com; s=arc-20240605; b=jDqEtD7MmjTUSECW2VYEp5Uqf1qLwy7Q70kwUCFCLHYmmf1lKkDnWAbhzSPymlsO4u 5Nh2P1MCanRaqRflZfLAHpcUcIDNDIoAc/vED8N4LT7O/s0oUJolhRtWyvbcIXxpkELj 9LDo5BJNMQ1YJQcAgaCz3djLn9sPQSvgYNlAHKhTQ4v7GysR8yTtBEytYbgmQ+WCnx+T 7yP7p2xZxcV5zGXkRSGywyFihIBz7Nc604KaK4vdLshZQFYq3PeEsS070rI8qIlTdgNp eh0qCcohr72HGyXOuypvnh1vQU1jT5x8Own4bXN1QFCCBX8HtDOj1XeSxpUAigbqobBP uiRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:autocrypt:references:in-reply-to:date:to :from:subject:message-id:sender:dkim-signature; bh=DGBBg/tZ5FsYVMJs0mOrvZMn2WDTRJ3vcOLfW1Q9To0=; fh=xvXv1yu2O5uILqofobT5L2o91B2TBU4jgj2GHD2BIUs=; b=bbPTq/r77ddTJL6VbqSexUYyJuheqfHk2TLZrmyotyRsnhYeWEYCt5PODpUwpBp22y +meuVql5okUIrX8D5bPfhYgEcM+tUDCYjkP1fEPxtgnTprY9aEDPNUoXcRw8hw+cMLlY J/wlKXG1IYeTGzNP7YzNeL6z3Mc2grULIVATO+nGPQIp2E3RLudIkuDpRg+4PoA61MHf Yqel/Y8mIxQMkXrr/CDNwAGv7ba+49I7Z4TljHJc8nJQqw1+6YRJOkKxxkymibd97O5g xr+mCqc4ouuQ9Z8JdWhP+bm/9mhSgQOTmmpo50Sz1i200Xu3vfmr3/GIzyMBbermuVeB 4qzw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1724777367; x=1725382167; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :autocrypt:references:in-reply-to:date:to:from:subject:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=DGBBg/tZ5FsYVMJs0mOrvZMn2WDTRJ3vcOLfW1Q9To0=; b=nubIxCftjXPjIQO04QbXs34E53jZnavMEgpLv981ruZUW4NXzmnPeYd/GYeHGTCxw3 cfpD4H16Xo1iWAJVEOjnVnZ3JosoARqe06GI7MBgzP79S8rTw+IwfPebGt8JJXgs+GAw bXGsqbmBGfLtqzCIPzJplk6KyLNQ2FZSRcxKUV2OC7DqobWAu0gVOzRWjtORQvvBaboe TRDkrkLPDkDHYrFg8aZaFfued9awdGFWUrYLVpT9hbCc3kWCBiCN1VHznx6W2K6sfxpc keLBEW9lceMWaH9szEtF4HNI7E+OEUfmoWF5Q6G4N9OB7Pgo6PqvwDju3L0NZVroLr9T u4Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724777367; x=1725382167; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:x-beenthere :x-gm-message-state:sender:from:to:cc:subject:date:message-id :reply-to; bh=DGBBg/tZ5FsYVMJs0mOrvZMn2WDTRJ3vcOLfW1Q9To0=; b=ODrB1n/eH4jWOzYiSGiY8fudnfc2s9ziuHLkhlnt3GICZ/S0SYWtUYrqfoBcFi+1Dd 4XAiIWkLK7vfSMidG9n7Ur6+ZZheqXXZ/+E1EnWoTTqnuyf1GsiMSKHH0BtzaKXRVxlf qU4LNVR20DQTI0BGHUqieLGNJPuMUbPLQ85rqXuxxH5bJNgo/mWZ9dhb4QNhKhhrY23t wfQgSDcQP8gkKqxXj8T1rUbQYXSLxp7pw3PoFI74xRGqD4nc3xX1xFvzRKhHksk7YUpo UgqQ/xYjxb1/RlPCvX050OC2fS6vqbidzbfac1b73coNnCwjdfOjveyaeWmM5R49HnRg gsJA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVcetEuEcvEL9WAqjPd0LoV5kVfX9H7dRl/At892bGShpsjmhIi8JZEVAdsoW3ih93gsQST@ilbers.de X-Gm-Message-State: AOJu0Yzd0f0M56yohL2DNlIpxfT43OAH0DCrnh5Twb1Hk4TSvsh89AG1 dAVptQ2rAtsc3xIabT3w+mwx6jRH4cOhZffLrDgBO8CCYKTBWJ+j X-Google-Smtp-Source: AGHT+IGC8m/+67nml9q4qTXP0u8ozsF6U1g1+F+oe6tD4VI8NH59pTarxcd7ERJurNTTYN23Iw95tQ== X-Received: by 2002:a05:6512:3989:b0:533:d28:b9d9 with SMTP id 2adb3069b0e04-5343886c176mr9122263e87.58.1724777365042; Tue, 27 Aug 2024 09:49:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3343:b0:533:48c9:7560 with SMTP id 2adb3069b0e04-5334e121d80ls770444e87.2.-pod-prod-04-eu; Tue, 27 Aug 2024 09:49:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUKQCDchwVQ2YoQOD5SNdXchXrrhocxTPO7ZmSoxIFOLwKcVZROwrIapsPGgH0NeH5rDrhmPYhKyIIs@googlegroups.com X-Received: by 2002:a05:6512:693:b0:52c:e07d:229c with SMTP id 2adb3069b0e04-53438832ee0mr12274596e87.22.1724777362111; Tue, 27 Aug 2024 09:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724777362; cv=none; d=google.com; s=arc-20240605; b=VXCi8aIkR/cA9oVcPi0FVnbAMbKMWj0IXiP4A5H66uMtAfEP85oHFdw0HyxgiYS7/I U3pH/HWCWNwQzoBMmJjwRrcerCkIT4c/wPWnqLQQ5WMm+BAHFJFgnxGls8nqQJo5Kwo+ hKZCjx6IlzC4K3FJ2mFxFugHffzeAz/5MH8cAGtPa81TORR0axFL2guiDKrVSuTGJ/gr POLM3qUDSue76Cn6sG6XNBXFkFzyPvBk9pqQ+JBOv+JuSw9r4ut+UHcIYrHlz2jga9j2 aTihS0lGqEkpkegY0I/iiMki4i20FINEdBJ2UMT9YYoYfRdyhoDlvyKbuDzdYQczjHZt bmPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id; bh=JWV+wFWjNXoCOOlRj0gaGkmBmbIxxf75KzQR4VFnBns=; fh=3Dtjg/iS4SfNPhUVI+c16NeSD8+dn6vzWz8U1hmQXDY=; b=HdIIZGEGn2nZ0d7K9TY83AB5voZxV0mry1/QRyDltqKHsPniIgdB71faQhA/qSLhYx uflor0iBX7Mz9AimFxgaDFQXUS1Rn6dFohIfpXFCVfk5itXqlvcerg0nL5PmcNzueAip nREfuhq2nP6Bs5C1weNZVE5U+C3a7C1n1/OZrKyXTkSXgwDRNgfQQzkq6lknH0aNgFr5 HIlpMxJzpEngVxpukXSMusW39ciDc5PZ39KFVDUy+SlM6LVwxtZicOoJA1v8mJWs0gS7 plwWzLyektQFYo14ElMU7Iz3UHpCV8nLsfOuYmZLAn+tbDS3eexZrHrYmer+HvSrUvJv Cd9A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 2adb3069b0e04-5334ea247dfsi249517e87.3.2024.08.27.09.49.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Aug 2024 09:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 47RGnJKQ024273 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Aug 2024 18:49:20 +0200 Message-ID: <83897bff2e447acb0da6d2d5e8e986b9c101e5d9.camel@ilbers.de> Subject: Re: [PATCH] linux-custom: support vendor directories via HEADERS_INSTALL_EXTRA From: Uladzimir Bely To: Jan Kiszka , Cedric Hombourger , isar-users@googlegroups.com Date: Tue, 27 Aug 2024 19:49:19 +0300 In-Reply-To: References: <20240810215838.2098472-1-cedric.hombourger@siemens.com> <639bbafa9073996114e4deb16ac59926b314df28.camel@ilbers.de> Autocrypt: addr=ubely@ilbers.de; prefer-encrypt=mutual; keydata=mQENBGO2eUkBCACtT+T3OrPVSExBmqfgXT3lp9XcdxRzjYp26wezkgYjjBXaf36bxtaAf S471VoQtpar0RVeFfW7WDDdfX9ZclSj36zBQe+RVSJzoNoNQfjOXWuSHb5Z+cpAFtqBY4muxK4+ia IlLJd6CN3ejOsLHATtCeHHq8wi0z2T+KdLQO+wQRgo2hjj0Lp9pGTrKJry50HP/o7Vbdu14dOx2xq r8+wPc6SQbBIrcqaa4MqCQC00vQG7eXvo+k2MOw59FDdpMH0KR9mHgp3u/s4I+4YRBArukt9G9xz/ rsEFmxAIBC6N/a6Hzwg4puc91n7ABDsPg8Vp+X3MDraujN0dvR6OKVNtABEBAAG0IFVsYWR6aW1pc iBCZWx5IDx1YmVseUBpbGJlcnMuZGU+iQFOBBMBCAA4FiEEJqPNVhVGyk12Eh+PAUQYBM/2FkoFAm O2eUkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQAUQYBM/2FkprlAgAmuna8Hm9EyoEtTl DBGDg6Zm4ZLp5ffvZBE946h92jepDrteoxsJ7pSzJVC2HmDLa4iZUao7lLLbDsUj5x45/iLJcqBZK k3YnAxP2r6a+kI+1VVQY1pxdG1nlJAbdNzoojm/qmezNPSrqni61KVMQKsXBCWhIjSXDSM9CsBj21 a+9qaVqfxovJGTn9lgrZO+xzKQNMKZeOouJlscVuFj21P0ww3/YENiU/nMeTSuYypO76mDtAd08Jo nc3yuHa9MJGei5ixN3wT+IrGR2aL2hdw2M6NgH7sYbL2Zi4ugD6RXHJai1Bh2yvFSVqSQ+M6QOInT 4ud7wslm1XRB065dXtA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: hUvZnpbezhdP On Tue, 2024-08-27 at 18:12 +0200, Jan Kiszka wrote: > On 27.08.24 17:48, Uladzimir Bely wrote: > > On Sat, 2024-08-10 at 23:58 +0200, 'Cedric Hombourger' via isar- > > users > > wrote: > > > Some vendor kernels come with additional directories to be > > > included > > > in the > > > linux-headers package in order to support building of their out- > > > of- > > > tree > > > drivers. HEADERS_INSTALL_EXTRA may be set to a list of > > > directories > > > relative > > > to ${S} in any kernel recipes that includes linux-custom.inc > > >=20 > > > Signed-off-by: Cedric Hombourger > > > --- > > > =C2=A0RECIPE-API-CHANGELOG.md=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 12 > > > ++++++++++++ > > > =C2=A0.../linux/files/debian/isar/install.tmpl=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 ++++++ > > > =C2=A0meta/recipes-kernel/linux/linux-custom.inc=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 12 > > > ++++++++++++ > > > =C2=A03 files changed, 30 insertions(+) > > >=20 > > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > > > index 65cd98b3..21c558d2 100644 > > > --- a/RECIPE-API-CHANGELOG.md > > > +++ b/RECIPE-API-CHANGELOG.md > > > @@ -634,3 +634,15 @@ into kernel kbuild package. > > > =C2=A0 > > > =C2=A0When downloading from debian snapshot mirrors, rate limits migh= t > > > apply. > > > =C2=A0To limit the amount of parallel fetching to n kB / s, you can > > > set > > > `ISAR_APT_DL_LIMIT=3D"`. > > > + > > > +### Custom directories in vendor kernels > > > + > > > +Some vendor kernels come with additional directories to be > > > included > > > in the > > > +linux-headers package in order to support building of their out- > > > of- > > > tree > > > +drivers. `HEADERS_INSTALL_EXTRA` may be set to a list of > > > directories > > > relative > > > +to ${S} in any kernel recipes that includes `linux-custom.inc`. > > > A > > > l4t kernel > > > +recipe would use the following setting: > > > + > > > +``` > > > +HEADERS_INSTALL_EXTRA +=3D "nvidia" > > > +``` > > > diff --git a/meta/recipes- > > > kernel/linux/files/debian/isar/install.tmpl > > > b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > index 00011517..0a7bdd66 100644 > > > --- a/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > +++ b/meta/recipes-kernel/linux/files/debian/isar/install.tmpl > > > @@ -193,6 +193,12 @@ kernel_headers() { > > > =C2=A0=C2=A0=C2=A0=C2=A0 (cd ${S}; find arch/${ARCH} -name module.lds= -o -name > > > Kbuild.platforms -o -name Platform) >>${src_hdr_files} > > > =C2=A0=C2=A0=C2=A0=C2=A0 (cd ${S}; find $(find arch/${ARCH} -name inc= lude -o -name > > > scripts -type d) -type f) >>${src_hdr_files} > > > =C2=A0 > > > +=C2=A0=C2=A0=C2=A0 if [ -n "${HEADERS_INSTALL_EXTRA}" ]; then > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for d in ${HEADERS_INSTAL= L_EXTRA}; do > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (= cd ${S}; find ${d} -type f) >>${src_hdr_files} > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 done > > > +=C2=A0=C2=A0=C2=A0 fi > > > + > > > =C2=A0=C2=A0=C2=A0=C2=A0 if [ -n "${CONFIG_MODULES}" ]; then > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo Module.symvers = >> ${obj_hdr_files} > > > =C2=A0=C2=A0=C2=A0=C2=A0 fi > > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > > > b/meta/recipes-kernel/linux/linux-custom.inc > > > index 6aa70fd3..7e312b75 100644 > > > --- a/meta/recipes-kernel/linux/linux-custom.inc > > > +++ b/meta/recipes-kernel/linux/linux-custom.inc > > > @@ -48,6 +48,8 @@ LINUX_VERSION_EXTENSION ?=3D "" > > > =C2=A0 > > > =C2=A0KERNEL_DEFCONFIG ??=3D "" > > > =C2=A0 > > > +HEADERS_INSTALL_EXTRA ??=3D "" > > > + > > > =C2=A0# Add our template meta-data to the sources > > > =C2=A0FILESPATH:append :=3D ":${FILE_DIRNAME}/files" > > > =C2=A0SRC_URI +=3D "file://debian" > > > @@ -84,6 +86,7 @@ TEMPLATE_VARS +=3D "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ > > > =C2=A0=C2=A0=C2=A0=C2=A0 KAFLAGS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 \ > > > =C2=A0=C2=A0=C2=A0=C2=A0 DISTRIBUTOR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= \ > > > =C2=A0=C2=A0=C2=A0=C2=A0 KERNEL_EXTRA_BUILDARGS=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 \ > > > +=C2=A0=C2=A0=C2=A0 HEADERS_INSTALL_EXTRA=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 \ > > > =C2=A0" > > > =C2=A0 > > > =C2=A0inherit dpkg > > > @@ -224,6 +227,15 @@ do_prepare_build:prepend() { > > > =C2=A0 > > > =C2=A0 # produce a changelog for our kernel build > > > =C2=A0 deb_add_changelog > > > + > > > + # make sure user-specified directories do exist in ${S} > > > + if [ -n "${HEADERS_INSTALL_EXTRA}" ]; then > > > + for d in ${HEADERS_INSTALL_EXTRA}; do > > > + [ -d ${S}/${d} ] || { > > > + bbfatal "HEADERS_INSTALL_EXTRA: > > > '${d}' not found in \${S}!" > > > + } > > > + done > > > + fi > > > =C2=A0} > > > =C2=A0 > > > =C2=A0# build directory for our "full" kernel build > > > --=20 > > > 2.39.2 > > >=20 > >=20 > > Hello all. > >=20 > > The patch is checked in CI and it passes OK, but it's still not > > clear > > from a discussion if it's worth applying. Or should this new > > feature > > leave on a downstrem side? > >=20 >=20 > I said in my reply that "we apparently need this", now that we have > two > downstream kernels with this pain. >=20 > We then had some unfinished (IIRC) follow-up discussion around > ccache, > but that should not delay this change. >=20 > Jan >=20 OK, got you. Thanks for the answer. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/= isar-users/83897bff2e447acb0da6d2d5e8e986b9c101e5d9.camel%40ilbers.de.