From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7192631200934002688 X-Received: by 2002:ac2:548f:0:b0:4bb:344c:2948 with SMTP id t15-20020ac2548f000000b004bb344c2948mr582763lfk.55.1675262863246; Wed, 01 Feb 2023 06:47:43 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:1146:b0:4cf:ff9f:bbfd with SMTP id m6-20020a056512114600b004cfff9fbbfdls1277784lfg.1.-pod-prod-gmail; Wed, 01 Feb 2023 06:47:41 -0800 (PST) X-Google-Smtp-Source: AK7set/kj9XZ+GiA0A1QNqz4G3Y9Cby9u439rBelrv7ivJeMIS4DTKSIuUCPNecZgicmhiqJGtaL X-Received: by 2002:ac2:5281:0:b0:4d5:831a:1af8 with SMTP id q1-20020ac25281000000b004d5831a1af8mr592871lfm.40.1675262861408; Wed, 01 Feb 2023 06:47:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1675262861; cv=pass; d=google.com; s=arc-20160816; b=SSY1ctEYNcXkneD0TJ1hBp6YTEqHkNRXlkwVEZpvLlCw00FWsKSPx9bCIgS1QTEe36 Ttele03wIq8Ot/Ag69SxtSaIsvsfsmAVMmU+Y9lPwIQ0Pl5g1Ud9vYHMfnV5Klab0l3W W4XuMTTuyP7MGV6QRSqapno7UiH3cMVxnolJCGed8zX0+OXFHH+LNBZNlvMTTcKQCgSH lbSbBLuifhseysashApD9D31jCFYjY+U5m3nsHF9upzJql+YGeLdJ6+uPStfqRklcvhO e0AfEa87/Dl040Mh7PnzEdADXQXySPjzFGW2mvNOkq8nHMfrJ1PJ9TnfYzBJBK8jNoJK 6fMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=Qzz9TcTN5TlwtrdUEE0ndO2FpSLutiuGxVZPvX2M+ec=; b=wMMlmS8n2n8nYWH0jeQEvWaKdpOA9UWQ1sdcRdtpzlwONBmv9bu6lt3RNtTfpbpVLI GX7Lz+r7JS+2Vi2O37TeJsq0EiOnt3X7xiw0i+jJIZjVD15/ydaWuUCYo9YOsitHSNlo 0bxMBrVU5lLCooqMoUvx7cC+X7HN6rjq6+u1HI+9F0nXm4tcVbOlraz7jmBgnTRk2myL vHUzIG/4fZVhVJEBQ1ruf+ZuujQrTGJPkKjUC8UPiQGJ7rWIwz59vtqkxR8IraM/8HVm WYDe0Q5Yfq3nnuCSkVYbTtDUOds+wJRJSXpUYSC46zRZitGhbcdFvVFbkNwHvJ+XCFxm bm8A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IU8aoAsX; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::608 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20608.outbound.protection.outlook.com. [2a01:111:f400:7e1a::608]) by gmr-mx.google.com with ESMTPS id y5-20020a056512044500b004d579451cc2si1085887lfk.12.2023.02.01.06.47.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2023 06:47:41 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::608 as permitted sender) client-ip=2a01:111:f400:7e1a::608; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IU8aoAsX; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::608 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e6yWsumB8uCbk0X1Jq1qX30ViehyJvpgbD+nKoqqTppeuSEISZFHdOnV6qwCYznZ/T1qpA4K8RV6VqWmT/0/XnWUqRrgoUvdlWYqxF1yxynosePmblacQGRdxAwO7HQs38yK1C4iXRVN1C4GoMZHloGQrfh7hiFeBpUMV6H4ox044eFEylOwei2RV313mNCjquQj7WaWnzkINVRCx0wQOvLLd/XhTfjcl53x+EyFWjm3PcSIgdDOPKw8C8KVkmDr4Zc/LgLVKMtTZ8MJa4MqwbgbxOpPAe1xweF9hayRMHtrMrjZ4S/HS/BQaNF2OBJCS4pEBaHACK6YpExQNYV3Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qzz9TcTN5TlwtrdUEE0ndO2FpSLutiuGxVZPvX2M+ec=; b=EDgoRPltb1dXQyFYUjeSgxjvYkji5afk+jj1h4i+MS7okR3plBSX9Qw7bFeMEtW04gImgMz6VecpzGEF0aBmo30p6gf2AFQGkSbY1e9qpGj29ARpXF/HY5FOtM2DnDuiWYdxUS5lHyXDCZbkHLdVTX4ru3Hdis2t+x8qdz0zRIsVjDvoIUsK6TMM9dAj7rMQ4X751QxDx2g3F1rV9sS5jy2ocQ5h8yZ/WSiEgyEDpbZZFN/bNijpJVQId7LDZPkE/umQBJwwtl9pWUxbdSa8mqo1qMSRMCyjPYS6NNZ7h5XXooDdnncvbnxZjEHJlNObfxH3F7aVbh9VvYOYhjXyaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qzz9TcTN5TlwtrdUEE0ndO2FpSLutiuGxVZPvX2M+ec=; b=IU8aoAsXUPBW5EizF3NCraPbrrGiLG7iO+Nd2RUDNN5buTWg7L0sjOXX7i3rYZlciIgWhAQZ5zJNqfqS7GdoLot82ofWiFsyzBClexZrqH5wZlJLWB94ywSgfiNVxkbMb7Ha9VioczexkStk13J424z9PR867JYApofZwWolxqc8vLAUvBz/NExo4dvbd0yzfhPfLzMymqoBmYD2jyGiiw9JJr3I+b3ZhosTJWNKsiiLsIwY5sRieiFwsWB0Np6XVNFerRlDJ6YmyMT59sVScRKIZ2UvpeRrOF+uM21l8El3g2yK4X0lMACIfeycOG/r8BxgZBDem5/fZLbF+PWJfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DB9PR10MB7595.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3d1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Wed, 1 Feb 2023 14:47:39 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::784b:e95b:b855:dcc5%8]) with mapi id 15.20.6043.030; Wed, 1 Feb 2023 14:47:39 +0000 Message-ID: <845939bb-2968-64ed-13d7-a3e69c08c69e@siemens.com> Date: Wed, 1 Feb 2023 15:47:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3] dpkg: sbuild allows extra arguments via DPKG_SBUILD_EXTRA_ARGS v3 Content-Language: en-US To: roberto.foglietta@linuxteam.org, isar-users@googlegroups.com, Uladzimir Bely References: <20230125164227.1448218-1-roberto.foglietta@linuxteam.org> From: Jan Kiszka In-Reply-To: <20230125164227.1448218-1-roberto.foglietta@linuxteam.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DB9PR10MB7595:EE_ X-MS-Office365-Filtering-Correlation-Id: 20da1b19-2f35-4234-8588-08db0463443c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LOh99R8u19X+N5jkLbjyaOp86Scyes2lVgsnIGU35VdbP08rGsdGi9YvQ2+lgWe8ozB7kCF4rDLswFu6W2bqJWryQlF/2s7s+BRnnjzfsJVSCSxxZTY/a/GgMz6TUlRbBiUxLkTUU6r1fk4QueOAOxFIMR5NCpIacQK8CzlkpdDR6Ner1j+PZH+f2NQh7Kh1/N1SooQCh7VmzUzvzxOHoe+QS7jwoyDWVxBZqwU4tojmqs/O90jJxtjWMmrw46XfYeGHcuVrFlCvtk1xpXiedwrf2EzTUtlWYymp/9ggCnQf3drcZjQik/c/UUeYwnH2RmBXA5piogOLzRdEH4xPkIBFTNqeVwtW7qMJf2tJ6/Kfscu6XQUiS5tylH+b4yJDbv488AngXSjPAWD5GxULu69QyMo//vs/8wCBjmRlaE7RfMpj6KxqMrV1ierM6xoI3x8vs2VACcmjd57VDtJs3jQNkqAhjTzzE92dY8+Bd5PdXqaCDDxROnsZ32eKfYHhEOwLf2XMyZJwovuaYT2225NcQbTEm2+aoCazM7A1IrJ7UGi8jm1JB2m451leOy/wcN0bVtTBR8CEkgazq6FiAzjCDR4eN/vJIajT36I0Ai/qtk4GpascOHGJpJvfNe18KRWTUWSckXr+txsvUrQpf31FTh/MX40wO2PT1HM0HB6rGIXpohbeUHonA+aXMTIgsA8uT2QrKfmgW/X/ff/Z9uY7d0QQCJa2EfD8MJfHKFCW/pN1FucsXaIgBaOEo8hz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199018)(31686004)(36756003)(66556008)(316002)(66946007)(6916009)(66476007)(41300700001)(8936002)(5660300002)(38100700002)(86362001)(31696002)(82960400001)(8676002)(6512007)(186003)(26005)(6506007)(6666004)(44832011)(2906002)(53546011)(2616005)(478600001)(83380400001)(6486002)(45980500001)(43740500002)(360504008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1VOUWRhWTA2WnVNSTM0L1E5bTl2WjZSTjdzcWRyQkZKcUdpVXpyNXlJVnRN?= =?utf-8?B?Qm45VElOci9ocWZtd0JrSlhJOXpSMSs2YzdIRUpQNjN5d3ZvaVhIaWxnTjl1?= =?utf-8?B?WVAvS2V1UHNtdTdmcGRpRUlKcnFibnpDalZwK1VmRUZKMVFab1o4a1paRWI2?= =?utf-8?B?Tzl5K1pmaTFhK3M0dGRIdUxCc0d2SUJDVXM0akZBWW9yejFtY0hhczNrM3k2?= =?utf-8?B?SFQ4K1dtdWhjWXhCVjRzRVRaazZieG9mNG51K2llOStYWVFDdWw0ckcwVTV5?= =?utf-8?B?TjJIN1VSb05icWhvOUNTRDRHdFNEUVg0N2R0TnlncS9wYW9RUThJcFJ0aEZF?= =?utf-8?B?S04xL09xV0kwNWR1WTRNdjNkUTdRQXhSUUZWeHJidlpRZHYxazgxV2tEdGcv?= =?utf-8?B?bk9UaUJBdkUxaG45WGgwbXFnVkpRcG9va3JZTGx2MXlQQXZFUkk4ZVNRemlq?= =?utf-8?B?L3VpOGtlTFRPcmljaDROK2poY0MvR2VxK3FEUWdLbEdyQ1JLWkRveUxTRUIx?= =?utf-8?B?RXdpTldRQ1hpZHBGdUVLME9Fc2V6Mk01Wkkzdi9OeGptazl4MUhqZ0Q1dVlY?= =?utf-8?B?T245M0ZicWx3UlgrSlRSZmpmNmdrYXhrSkJFeXRsM0tuTDhKOE9SWjBBZW5I?= =?utf-8?B?Q3FxVmE5ejZqNUdtQm9PcFh1aU5OTGxNZnc5cm8wSUZmMWh4WGhwYjNOU3lh?= =?utf-8?B?MjBrbm1iRlNKbW05UjIrQ1VHNjdhTFZ5ZWUrclBIZG55Z0gyWVd4MGc0QmRW?= =?utf-8?B?WmxBc2FXc0svVlExNWpCMWhGU1FodjhPcUdXOG8vWGE1SHJDU08xOHhTUHpS?= =?utf-8?B?OUcwallML3hpR3d6UExWcXdZMitQak5IbVBUMHl0SkJpVWxjVkNtT2xGeFZt?= =?utf-8?B?akFiUnBRWXN4eGlBQU9ROWhRcVpHUkFyd3krOGEvRGNKWWdkcDhkZHVYcTBi?= =?utf-8?B?TlNtWml2NktwTitiNHpwaHhWWTdIcFhmd3JKR3ZLWWsyOWpQU2h0Z0ZpL1k5?= =?utf-8?B?ZzJwNnVtUnRiZlpQWWQyb01raTQvNThjYW9aKzVpRFJvMG83RWdhLzlGbFB2?= =?utf-8?B?dUllMnNEWVhrRmhqRGVIamNFNFFDZm5vVXFORFFwdDlBelF6K2hoRS9KSU1o?= =?utf-8?B?YnpFVlZNWTlkU1p6SGZNWmplMXE3aTh2bTcrWm84T1pydGNLbGR0VTJKamJF?= =?utf-8?B?UUVacHVpR0Y5ZG5UU0lVcE9vQk1tRENWUyt5NE4zSDkxci9IOEg0bDVDTmsw?= =?utf-8?B?dFR0VEdHcGdGS1BLVW85blREUzBCTHhOQXgyQVFRVnhDNlk3K28rNFlyMU5o?= =?utf-8?B?VENMOXVNVTQzNEZLNnd1TllQOUdacE1DQlVzTzhQODVPeVZTRWl6c0lXYzZy?= =?utf-8?B?VCsxUSsvWFFyUTh2K0JiSFRJZkwxOXRwMkhNWDVGbTQrMldSNDV4UHVUSjBR?= =?utf-8?B?SlIzSExBWWVaQTJTSFA5RWZIZ0VHNDRXbDhTNGZ6QkZNYmdrcVkyMjZrLyt0?= =?utf-8?B?RlhpN0EvWUgzRSsyMFRtNnMvTFNtbHU3U0FWSzNSSFBDeDNmZ2lqOENUUmtC?= =?utf-8?B?UXRkZFBiMmVwTW9sMEZscGlrMC9WamNaWmZsTXBaRlEwdkZ0OGQzRjVpcnZV?= =?utf-8?B?MVd6ejNBckFkelNxZUsrU0lGdTRoZW83R3hXMmxQUmJsRGZDaHJ6VDRFL0d3?= =?utf-8?B?V2ZFT0dmYlJtenVFVnR4Wno1ckNkK2k3Mmo0a05lcjVXVU9EbEV5WTgzUXB2?= =?utf-8?B?akZzVjNHZHlVY2VUZTlFQThZSDBrR1dsQVpWbExlVHBtVkFJT3BIMUtDM21N?= =?utf-8?B?YVpqMzhTQ3JTOXN5S2lvOEZYYlFwQmxFNXRKV3lOQ1kyK0d4ZHNjWlgzbEda?= =?utf-8?B?SVd3TWhJYkJxSGhzejBrckh2dUVWTkxid3E4bEpvQ0NsOVdnUTVaNFBiOTUv?= =?utf-8?B?ZElQMlcxak1nSVk4SmVXZ1Y3a2ZIdFJwa1NDaUlFcXMzTVVaV3A0LzFjNlNI?= =?utf-8?B?WWF3UE1LckErazVOTVZ5S1hTQXBwMnJ3eFkrZUxtdFNuandTcTR5eTgvUVp3?= =?utf-8?B?YWdRcHFvK1RRWklkb2NRbDlZdzM1U2d3YVlSNXFDdnZFNGRwaXNrQ1BVckpM?= =?utf-8?B?RlBVbkhoMk9lR29ocjREeU9oWWZTNFZnQTQ5emJ3MzU1QzJtRDI0YlFpL2ty?= =?utf-8?B?dFE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20da1b19-2f35-4234-8588-08db0463443c X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 14:47:39.7241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jrhGn1eo8QmCjwG1JlGhjhfj2DmsZYua1M/NaxBFm/Hlw8F7JZczxg0YH0Ksf4iwiXyEJDVPBVMb+dQpENfjCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB7595 X-TUID: YZEa6cI0+WJz On 25.01.23 17:42, roberto.foglietta@linuxteam.org wrote: > From: "Roberto A. Foglietta" > > Sometimes it is necessary to add some extra commands or arguments for > the sbuild process which produces customs packages but creating a class > into an upper layer just for this will create difficulties in managing > the updates from the upstream project. > > So, this patch allows setting extra parameters via this variable: > > DPKG_SBUILD_EXTRA_ARGS > > v.2: just a single variable and not anymore two of them > > v.3: the variable is set in the middle, just in case order matters, it > is the last of 'setup chroot' and the first of 'final build' commands > > Signed-off-by: Roberto A. Foglietta > --- > v.2: just a single variable and not anymore two of them > > v.3: the variable is set in the middle, just in case order matters, it > is the last of 'setup chroot' and the first of 'final build' commands > > meta/classes/dpkg.bbclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 7822b14d..8785237c 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -23,6 +23,8 @@ do_prepare_build_append() { > env > ${DPKG_PREBUILD_ENV_FILE} > } > > +DPKG_SBUILD_EXTRA_ARGS ?= "" > + > # Build package from sources using build script > dpkg_runbuild[vardepsexclude] += "${SBUILD_PASSTHROUGH_ADDITIONS}" > dpkg_runbuild() { > @@ -109,6 +111,7 @@ dpkg_runbuild() { > --chroot-setup-commands="echo \"APT::Get::allow-downgrades 1;\" > /etc/apt/apt.conf.d/50isar-apt" \ > --chroot-setup-commands="rm -f /var/log/dpkg.log" \ > --chroot-setup-commands="cp -n --no-preserve=owner ${ext_deb_dir}/*.deb -t ${deb_dir}/ || :" \ > + ${DPKG_SBUILD_EXTRA_ARGS} \ > --finished-build-commands="rm -f ${deb_dir}/sbuild-build-depends-main-dummy_*.deb" \ > --finished-build-commands="cp -n --no-preserve=owner ${deb_dir}/*.deb -t ${ext_deb_dir}/ || :" \ > --finished-build-commands="cp /var/log/dpkg.log ${ext_root}/dpkg_partial.log" \ I'm seeing this in next, but it seems everyone missed that this should not go in like this: Missing elaborated reasoning. No in-tree use case or at least some explanation why we should open such a low-level interface to recipes. Please clarify or revert. Thanks, Jan -- Siemens AG, Technology Competence Center Embedded Linux