isar-bootstrap

[ydirson@free.fr]

Hello,

While reading the isar-bootstrap recipe to get the gist of it, I
stumbled on what looks like just a typo, but could possibly be more
than that:

I was trying to get a grasp on DISTRO_APT_SOURCES handling, and noticed
a spurious match for "distro_apt_sources" in DISTRO_APT_PREFERENCES handling.
While this possibly was meant to read "distro_apt_preferences" instead,
it raises the question of whether it is useful to add all of this to SRC_URI
if not adding it did not cause any problem (it does not appear to be used
by any conf in isar itself, but I guess it is/has been used in downstream
layers).

This brought me to where this gets used (both _SOURCES and _PREFERENCES in fact),
ie. do_apt_config_prepare: the whole point of SRC_URI is to direct the fetcher
to download/copy source files into $WORKDIR, and then later tasks (unpack/patch
in OE) take files from there.  But here, $WORKDIR is not used, and instead
aggregate_files() uses resolve_file() on them.  At first sight this seems
to break the bitbake abstractions (and seems unnecessarily complicated at
the same time).  Am I missing something, or is it worth for me to try patching ?

On a related note, I assume that aggregate_files() was meant to support distro
versions predating preferences.d/ and sources.list.d/ - would it be correct
to use the latter instead to simply things further ?  Most recent is preferences.d/,
released with 0.7.22 in 2009, and stretch which seems to be the oldest supported
distro has 1.4.


The chroot-setup.sh script there also seems to do things that are already
handled by the debootstrap (policy.d and start-stop-daemon), except for
the upstart support.  Even if someone still uses upstart (which has not been
developped since 2014), probably the rest could be omitted ?


Best regards,
-- 
Yann