From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6750187537661165568 Date: Fri, 15 Nov 2019 08:59:15 -0800 (PST) From: chombourger@gmail.com To: isar-users Message-Id: <8594de25-19a5-44a2-a4c0-cdf3a7b66f21@googlegroups.com> In-Reply-To: <20191114170112.nopfyhugrzc3olqk@yssyq.m.ilbers.de> References: <1572958385-246-1-git-send-email-Cedric_Hombourger@mentor.com> <1573205003-1335-1-git-send-email-Cedric_Hombourger@mentor.com> <9af716d7-f9e4-4745-85b3-cfe4c65ef585@googlegroups.com> <20191114170112.nopfyhugrzc3olqk@yssyq.m.ilbers.de> Subject: Re: [PATCH v4 - misc fixes 0/6] miscellaneous (minor) fixes MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_408_987658679.1573837155565" X-Google-Token: EOOyu-4FuhLBlGT97do0 X-Google-IP: 139.181.48.2 X-TUID: 0oAbm59nfcwU ------=_Part_408_987658679.1573837155565 Content-Type: multipart/alternative; boundary="----=_Part_409_1996989924.1573837155566" ------=_Part_409_1996989924.1573837155566 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Friday, November 15, 2019 at 2:46:53 PM UTC+1, Baurzhan Ismagulov wrote: > > Hello Cedric, > > Hello! > On Tue, Nov 12, 2019 at 11:20:15AM -0800, chomb...@gmail.com > wrote: > > Is this patch series ready for merge or is there anything that needs > fixing? > > Looks good to me. I've applied it to ibr/next. I'll do some more checks > and let > you know (the commid id will change). Please check #3, it failed for some > reason, I had to apply it manually. > Rebased locally (it did apply cleanly for me) - will anyway send v5 > > Regarding #1, it's an upstream feature. Do you know how Yocto deals with > that? > E.g., does clean remove all of them? I found it useful once, when > something was > broken and I could check the previous image. Also, I usually prefer not to > remove intermediate files to be able to debug stuff after the build. In > this > case I agree that it's better to remove them. > I can check what upstream does but to answer the other question, clean unfortunately leaves them behind WICTMP is created with mktemp -d so I wonder if we would have to store it somewhere if we wanted to keep files in the buildchroot but delete them when we run do_clean should we introduce WIC_DEBUG?= "0" and keep them if it was set to "1"? > Regarding #5, this is what many new users complain about: The > configuration is > scattered through many files, it's difficult even to identify which > variables > are available. MACHINE-centric tools with a single config file are much > easier > to learn in this regard. Documenting stuff would be one option. But > providing > few self-explaining locations with all variables is also important. Maybe > we > could introduce meta/conf/arch/machine hierarchy and provide variables > like > KERNEL_FILE there, at the cost of some repetition. > that sounds like a good idea but do we want to expand the scope of this patch series? It would be nice to fix mips builds with our current design. As an aside, do we have a central TODO list where we can record things we really want to get done before we release something like 1.0? I recall seeing e-mails from different people with own lists. Should we have it in the repo so it's easy to find? > With kind regards, > Baurzhan. > ------=_Part_409_1996989924.1573837155566 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On Friday, November 15, 2019 at 2:46:53 PM UTC+1, = Baurzhan Ismagulov wrote:
Hello= Cedric,

Hello!
=C2=A0
On Tue, Nov 12, 2019 at 11:20:15AM -0800, chomb...@gmail.co= m wrote:
> Is this patch series ready for merge or is there anything that nee= ds fixing?

Looks good to me. I've applied it to ibr/next. I'll do some mor= e checks and let
you know (the commid id will change). Please check #3, it failed for so= me
reason, I had to apply it manually.

Rebased locally (it did apply cleanly = for me) - will anyway send v5
=C2=A0

Regarding #1, it's an upstream feature. Do you know how Yocto deals= with that?
E.g., does clean remove all of them? I found it useful once, when somet= hing was
broken and I could check the previous image. Also, I usually prefer not= to
remove intermediate files to be able to debug stuff after the build. In= this
case I agree that it's better to remove them.

I can check what upstream does but to = answer the other question, clean unfortunately leaves them behind
WICTMP is created with mktemp -d so I wonder if we would have to store it = somewhere if we wanted to keep files in the buildchroot
but delet= e them when we run do_clean
=C2=A0
should we introduce = WIC_DEBUG?=3D "0" and keep them if it was set to "1"?


Regarding #5, this is what many new users complain about: The configura= tion is
scattered through many files, it's difficult even to identify which= variables
are available. MACHINE-centric tools with a single config file are much= easier
to learn in this regard. Documenting stuff would be one option. But pro= viding
few self-explaining locations with all variables is also important. May= be we
could introduce meta/conf/arch/machine hierarchy and provide variables = like
KERNEL_FILE there, at the cost of some repetition.

that sounds like a good idea but do we= want to expand the scope of this patch series?
It would be nice = to fix mips builds with our current design.=C2=A0

= As an aside, do we have a central TODO list where we can record things we r= eally want to
get done before we release something like 1.0? I re= call seeing e-mails from different people
with own lists. Should = we have it in the repo so it's easy to find?
=C2=A0=C2=A0
With kind regards,
Baurzhan.
------=_Part_409_1996989924.1573837155566-- ------=_Part_408_987658679.1573837155565--