Re: [PATCH v2] scripts: Avoid adding duplicate entries to PATH

[Jan Kiszka <jan.kiszka@siemens.com>]

On 21.08.19 20:48, vijaikumar.kanagarajan@gmail.com wrote:
> From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> 
> If the setup script is run multiple times in the same shell session,
> PATH variable gets overpopulated with duplicate entries. Remove any
> existing entries before adding.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
> Changes in v2:
> - Unset newpath
> 
>   scripts/isar-buildenv-internal | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal
> index 2186e40..72a91ab 100755
> --- a/scripts/isar-buildenv-internal
> +++ b/scripts/isar-buildenv-internal
> @@ -60,7 +60,15 @@ unset BDIR
>   
>   export BUILDDIR
>   
> -PATH=$ISARROOT/bitbake/bin:$ISARROOT/scripts:$PATH
> +for newpath in "$ISARROOT/bitbake/bin" "$ISARROOT/scripts"; do
> +    # Remove any existences of $newpath from $PATH
> +    PATH=$(echo $PATH | sed -re "s#(^|:)$newpath(:|$)#\2#g;s#^:##")
> +
> +    # Add $newpath to $PATH
> +    PATH="$newpath:$PATH"
> +done
> +unset newpath
> +
>   export PATH
>   
>   BBPATH="${BUILDDIR}"
> 

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux