From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6727677240025284608 X-Received: by 2002:a19:6041:: with SMTP id p1mr19495656lfk.6.1566414031620; Wed, 21 Aug 2019 12:00:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9950:: with SMTP id r16ls404959ljj.7.gmail; Wed, 21 Aug 2019 12:00:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRTXLhomyEqlSZA5iappivWY4xpyJBa9o2mJ6zrs0HsWxhVJ8I1ssuo3XusYF26RPI9X5Y X-Received: by 2002:a2e:958e:: with SMTP id w14mr19504353ljh.126.1566414031017; Wed, 21 Aug 2019 12:00:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566414031; cv=none; d=google.com; s=arc-20160816; b=ef2a5cW+5GmRNB2j8DlDN01G3MOGk2fW+sSyvrv3cag35Tu69nB46ARgN8nzyoyTgs 9B8F5/72Vnq9PjPvGi65JOzKl6gZx5Y5Wx1bluEYA/drTVUp6kXipwSkdYAcZ1X2qZoJ F7z3A/4jKGGZfI0zPxF7OpBrwc5t5FN3S5pDNw4l7vWWy5keYd/VXF6kTVm8zofD+r5B cv8NYLlgF2aP6BGHqEnev50pZJ7K7hkf5MVfR1pgcSj5AvdbmQHoBK++Jcxx8h+my94l NRRWjrILe2TbbTas0riNezLRgM8FzllVprT7g/hzbXd+gM+d6imDJbKpSNDcwSQbN0sF nkdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=RnypLQKcj7tQBq5NeOtZvtHeBS3o3ycGi+0C0z8GkYE=; b=ZHQdbYokFxDz3KZ+edYQo7CcdqGrWoD/Jr/yZVDh4mjJjgiThMUTx4zyLNf+F1jhUk XfDZr1MkDOJxRnZ33iREvDvC0mCw8boEDFglc1HalzbYg9YhG63feo4IWQIygekZDAXG r7mGPuRO66BGcQj4AGM9shk8Wd7AYIuAELmRFoR6vknH7bdg8smoV4BaqBOzc62++Weo HJrTxWj9/Pi2kv3rSqp7L685lL8pjTJjNrL6kcJ4xN0Bi02U6Sa3teuu3D0NfYGaYCgN uL7dKZ58PsH7vBOL/js7VbSEAHFWqhQez7Lpke+Y4sJoolZuQkc5v4kcTYGuy1lrWCZK Xf/g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id c12si827042lji.0.2019.08.21.12.00.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Aug 2019 12:00:30 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x7LJ0TvG011108 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Aug 2019 21:00:29 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7LJ0TMW020250; Wed, 21 Aug 2019 21:00:29 +0200 Subject: Re: [PATCH v2] scripts: Avoid adding duplicate entries to PATH To: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Cc: Vijai Kumar K References: <199abc3d-5887-7011-c4be-b08b909c1a04@siemens.com> <20190821184837.7279-1-Vijaikumar_Kangarajan@mentor.com> From: Jan Kiszka Message-ID: <85a07645-8597-8db5-bd29-a515a0842f0a@siemens.com> Date: Wed, 21 Aug 2019 21:00:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190821184837.7279-1-Vijaikumar_Kangarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: fiMJ5KKL68hU On 21.08.19 20:48, vijaikumar.kanagarajan@gmail.com wrote: > From: Vijai Kumar K > > If the setup script is run multiple times in the same shell session, > PATH variable gets overpopulated with duplicate entries. Remove any > existing entries before adding. > > Signed-off-by: Vijai Kumar K > --- > Changes in v2: > - Unset newpath > > scripts/isar-buildenv-internal | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/scripts/isar-buildenv-internal b/scripts/isar-buildenv-internal > index 2186e40..72a91ab 100755 > --- a/scripts/isar-buildenv-internal > +++ b/scripts/isar-buildenv-internal > @@ -60,7 +60,15 @@ unset BDIR > > export BUILDDIR > > -PATH=$ISARROOT/bitbake/bin:$ISARROOT/scripts:$PATH > +for newpath in "$ISARROOT/bitbake/bin" "$ISARROOT/scripts"; do > + # Remove any existences of $newpath from $PATH > + PATH=$(echo $PATH | sed -re "s#(^|:)$newpath(:|$)#\2#g;s#^:##") > + > + # Add $newpath to $PATH > + PATH="$newpath:$PATH" > +done > +unset newpath > + > export PATH > > BBPATH="${BUILDDIR}" > Reviewed-by: Jan Kiszka Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux