* [PATCH] image.bbclass: Move kernel inclusion code to class
@ 2018-05-07 15:55 Alexander Smirnov
2018-05-11 17:55 ` Alexander Smirnov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Smirnov @ 2018-05-07 15:55 UTC (permalink / raw)
To: isar-users; +Cc: Alexander Smirnov
the code that includes kernel to IMAGE_INSTALL should be generic for
all the images, so it'd be better to move it from image recipe to
class.
Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
---
meta-isar/recipes-core/images/isar-image-base.bb | 2 --
meta/classes/image.bbclass | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index 00e926a..ca76887 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -16,8 +16,6 @@ PV = "1.0"
inherit image
inherit isar-bootstrap-helper
-IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", True)) if d.getVar("KERNEL_NAME", True) else ""}"
-
DEPENDS += "${IMAGE_INSTALL}"
IMAGE_PREINSTALL += "apt \
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index bb2c1e3..3bdcb2f 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -5,6 +5,8 @@ IMAGE_INSTALL ?= ""
IMAGE_TYPE ?= "ext4-img"
IMAGE_ROOTFS = "${WORKDIR}/rootfs"
+IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", True)) if d.getVar("KERNEL_NAME", True) else ""}"
+
# Extra space for rootfs in MB
ROOTFS_EXTRA ?= "64"
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] image.bbclass: Move kernel inclusion code to class
2018-05-07 15:55 [PATCH] image.bbclass: Move kernel inclusion code to class Alexander Smirnov
@ 2018-05-11 17:55 ` Alexander Smirnov
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Smirnov @ 2018-05-11 17:55 UTC (permalink / raw)
To: isar-users
On 05/07/2018 06:55 PM, Alexander Smirnov wrote:
> the code that includes kernel to IMAGE_INSTALL should be generic for
> all the images, so it'd be better to move it from image recipe to
> class.
>
Applied to next.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-11 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 15:55 [PATCH] image.bbclass: Move kernel inclusion code to class Alexander Smirnov
2018-05-11 17:55 ` Alexander Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox