* [PATCH] meta: wic-img: correct variable IMAGE_BASENAME
@ 2018-05-03 16:59 Henning Schild
2018-05-03 17:00 ` Henning Schild
2018-05-03 18:50 ` Alexander Smirnov
0 siblings, 2 replies; 3+ messages in thread
From: Henning Schild @ 2018-05-03 16:59 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine, Alexander Smirnov, Henning Schild
As discovered during review, the variable is set incorrectly. It
contained too much information and used an unusual format. This commit
corrects that.
Reported-by: Claudius Heine <claudius.heine.ext@siemens.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
meta/classes/wic-img.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass
index d1deff3..d2ba36c 100644
--- a/meta/classes/wic-img.bbclass
+++ b/meta/classes/wic-img.bbclass
@@ -10,7 +10,7 @@ ROOTFS_TYPE ?= "ext4"
STAGING_DATADIR ?= "/usr/lib/"
STAGING_LIBDIR ?= "/usr/lib/"
STAGING_DIR ?= "${TMPDIR}"
-IMAGE_BASENAME ?= "multiconfig:${MACHINE}-${DISTRO}:${PN}"
+IMAGE_BASENAME ?= "${PN}-${DISTRO}"
FAKEROOTCMD ?= "${ISARROOT}/scripts/wic_fakeroot"
RECIPE_SYSROOT_NATIVE ?= "/"
--
2.16.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meta: wic-img: correct variable IMAGE_BASENAME
2018-05-03 16:59 [PATCH] meta: wic-img: correct variable IMAGE_BASENAME Henning Schild
@ 2018-05-03 17:00 ` Henning Schild
2018-05-03 18:50 ` Alexander Smirnov
1 sibling, 0 replies; 3+ messages in thread
From: Henning Schild @ 2018-05-03 17:00 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine, Alexander Smirnov
This is the fixup on top of the wic-series, as requested by Alex.
Henning
Am Thu, 3 May 2018 18:59:20 +0200
schrieb Henning Schild <henning.schild@siemens.com>:
> As discovered during review, the variable is set incorrectly. It
> contained too much information and used an unusual format. This commit
> corrects that.
>
> Reported-by: Claudius Heine <claudius.heine.ext@siemens.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> meta/classes/wic-img.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/wic-img.bbclass
> b/meta/classes/wic-img.bbclass index d1deff3..d2ba36c 100644
> --- a/meta/classes/wic-img.bbclass
> +++ b/meta/classes/wic-img.bbclass
> @@ -10,7 +10,7 @@ ROOTFS_TYPE ?= "ext4"
> STAGING_DATADIR ?= "/usr/lib/"
> STAGING_LIBDIR ?= "/usr/lib/"
> STAGING_DIR ?= "${TMPDIR}"
> -IMAGE_BASENAME ?= "multiconfig:${MACHINE}-${DISTRO}:${PN}"
> +IMAGE_BASENAME ?= "${PN}-${DISTRO}"
> FAKEROOTCMD ?= "${ISARROOT}/scripts/wic_fakeroot"
> RECIPE_SYSROOT_NATIVE ?= "/"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] meta: wic-img: correct variable IMAGE_BASENAME
2018-05-03 16:59 [PATCH] meta: wic-img: correct variable IMAGE_BASENAME Henning Schild
2018-05-03 17:00 ` Henning Schild
@ 2018-05-03 18:50 ` Alexander Smirnov
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Smirnov @ 2018-05-03 18:50 UTC (permalink / raw)
To: Henning Schild, isar-users; +Cc: Claudius Heine
On 05/03/2018 07:59 PM, Henning Schild wrote:
> As discovered during review, the variable is set incorrectly. It
> contained too much information and used an unusual format. This commit
> corrects that.
>
Applied to next, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-03 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 16:59 [PATCH] meta: wic-img: correct variable IMAGE_BASENAME Henning Schild
2018-05-03 17:00 ` Henning Schild
2018-05-03 18:50 ` Alexander Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox