From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users@googlegroups.com
Subject: Re: [PATCH 3/5] meta: Implement two stage build
Date: Thu, 12 Oct 2023 16:53:09 +0200 [thread overview]
Message-ID: <86c80ff7-8d33-4a8e-9897-8ddd9162e304@siemens.com> (raw)
In-Reply-To: <ZSgFEDUfBP0CJmUi@ilbers.de>
On 12.10.23 16:39, Baurzhan Ismagulov wrote:
> On 2023-10-12 13:12, 'Jan Kiszka' via isar-users wrote:
>> I found the reason: You added -I to dpkg-source, and that filters out
>> some questionable but needed prebuilt .a files in edk2. All fine again
>> when dropping it. I'll send a patch, we should not do that here.
>
> Thanks Jan for the analysis, this explains it.
>
> That said, Debian doesn't want source packages to contain binary libraries or
> .git files for a good reason (we were hit by the latter), so removing -I
> altogether will break other stuff. We will quickly provide an option to drop -I
> per recipe, which will solve this problem without affecting all recipes.
Yes, that's why we need to solve things differently on the long run.
First, this is an Isar regression we need to fix: You changed behavior
in the middle of some harmless refactoring that breaks downstream
subtly. Not a good idea.
Jan
--
Siemens AG, Technology
Linux Expert Center
next prev parent reply other threads:[~2023-10-12 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 18:54 [PATCH 0/5] Separate prebuild activities Anton Mikanovich
2023-09-15 18:54 ` [PATCH 1/5] repository: Add source package remove function Anton Mikanovich
2023-09-15 18:54 ` [PATCH 2/5] dpkg: Limit dsc searching by workdir Anton Mikanovich
2023-09-15 18:54 ` [PATCH 3/5] meta: Implement two stage build Anton Mikanovich
2023-10-12 8:48 ` Jan Kiszka
2023-10-12 9:07 ` Anton Mikanovich
2023-10-12 11:12 ` Jan Kiszka
2023-10-12 14:39 ` Baurzhan Ismagulov
2023-10-12 14:53 ` Jan Kiszka [this message]
2023-10-12 15:20 ` Baurzhan Ismagulov
2023-10-12 9:15 ` Jan Kiszka
2023-09-15 18:54 ` [PATCH 4/5] dpkg-base: Copy isar_apt to workdir in separate task Anton Mikanovich
2023-09-15 18:54 ` [PATCH 5/5] RECIPE-API-CHANGELOG.md: Note tasks separation Anton Mikanovich
2023-09-21 13:45 ` [PATCH 0/5] Separate prebuild activities Anton Mikanovich
2023-09-29 6:43 ` Uladzimir Bely
2023-10-30 4:44 ` MOESSBAUER, Felix
2023-10-30 8:00 ` Schmidt, Adriaan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c80ff7-8d33-4a8e-9897-8ddd9162e304@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox