public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] isar-installer: enable bmap usage in unattended installations
@ 2025-12-13 13:11 'Badrikesh Prusty' via isar-users
  2025-12-17 12:56 ` Anton Mikanovich
  0 siblings, 1 reply; 2+ messages in thread
From: 'Badrikesh Prusty' via isar-users @ 2025-12-13 13:11 UTC (permalink / raw)
  To: isar-users; +Cc: Badrikesh Prusty

The installer previously searched for the bmap file only during interactive
installations (inside `if ! installer_unattended`). This caused bmap files
to be ignored during unattended installs.

The bmap path is now derived directly from the installer image outside the
interactive block. If the file does not exist, bmap usage is disabled.

This ensures correct bmap usage in both interactive and unattended modes.

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 .../deploy-image/files/usr/bin/deploy-image-wic.sh    | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
index a4e38876..55d5df6f 100755
--- a/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
+++ b/meta-isar/recipes-installer/deploy-image/files/usr/bin/deploy-image-wic.sh
@@ -31,7 +31,6 @@ if ! $installer_unattended; then
         dialog --msgbox "Could not find an image to install. Installation aborted." 6 60
         exit 1
     fi
-    DISK_BMAP=$(find "$installdata" -type f -iname "${installer_image_uri%.wic*}.wic.bmap")
 
     # inspired by poky/meta/recipes-core/initrdscripts/files/install-efi.sh
     target_device_list=""
@@ -167,10 +166,6 @@ if ! $installer_unattended; then
 
     # set absolute paths to be compatible with unattended mode
     installer_image_uri="$installdata/$installer_image_uri"
-
-    if [ -z "$DISK_BMAP" ]; then
-        DISK_BMAP="$installdata/$DISK_BMAP"
-    fi
 fi
 
 if ! cmp /dev/zero "$installer_target_dev" -n 1M; then
@@ -190,7 +185,11 @@ if ! cmp /dev/zero "$installer_target_dev" -n 1M; then
 fi
 
 bmap_options=""
-if [ -z "$DISK_BMAP" ]; then
+
+# bmap file is expected to be next to the installer image
+DISK_BMAP="${installer_image_uri%.wic*}.wic.bmap"
+
+if [ ! -f "$DISK_BMAP" ]; then
     bmap_options="--nobmap"
 fi
 
-- 
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251213131150.1110465-1-badrikesh.prusty%40siemens.com.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] isar-installer: enable bmap usage in unattended installations
  2025-12-13 13:11 [PATCH] isar-installer: enable bmap usage in unattended installations 'Badrikesh Prusty' via isar-users
@ 2025-12-17 12:56 ` Anton Mikanovich
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Mikanovich @ 2025-12-17 12:56 UTC (permalink / raw)
  To: isar-users

13/12/2025 15:11, 'Badrikesh Prusty' via isar-users wrote:
> The installer previously searched for the bmap file only during interactive
> installations (inside `if ! installer_unattended`). This caused bmap files
> to be ignored during unattended installs.
>
> The bmap path is now derived directly from the installer image outside the
> interactive block. If the file does not exist, bmap usage is disabled.
>
> This ensures correct bmap usage in both interactive and unattended modes.
>
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
Applied to next, thanks.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/86ea0f36-9c97-4c16-8f76-b7d7666fe4c5%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-17 12:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-13 13:11 [PATCH] isar-installer: enable bmap usage in unattended installations 'Badrikesh Prusty' via isar-users
2025-12-17 12:56 ` Anton Mikanovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox