From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7257948820735000576 X-Received: by 2002:aa7:c393:0:b0:51e:1a51:d414 with SMTP id k19-20020aa7c393000000b0051e1a51d414mr1064314edq.32.1690534714200; Fri, 28 Jul 2023 01:58:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:1051:b0:51b:d432:a176 with SMTP id e17-20020a056402105100b0051bd432a176ls300695edu.2.-pod-prod-00-eu; Fri, 28 Jul 2023 01:58:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlFBIW3nzk8ST6FTjihnP++owR4RCqoTErY9lWIx5hPjphkgjJ2RotzMtK+uCK9Q4URg6O6p X-Received: by 2002:a05:6402:1e94:b0:51d:b184:efd with SMTP id f20-20020a0564021e9400b0051db1840efdmr5642228edf.20.1690534712114; Fri, 28 Jul 2023 01:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690534712; cv=none; d=google.com; s=arc-20160816; b=BKJGfmFZxAkDVRaZw18ECzsXQdnNZwSD1x17hlY3sB/+b7IWEyI8sQ1WVI3f/czjwg Zfjd9eaPHzSaXdD73fsJHcAVd5lH8oXEmdG+rglHFgCNWbmZ7ld134abCQcLg8QECM2Q rJ1XYQ0pr6JuXMyU8okp2enjA9mN6m01d9Z2gkjZO3Y/psKIoViyX9JoUd83rhd/hHev qYcxL3x5ITjTTzthtA1XmFOLxGEyr3Kk+rWk2z3Xw7xCxoxytBqQ0Ekq3COVgQlKfGap S1Pm5gS0PiTRUZ8ezO9n+xDazg0mdLchCwMUtwnrQE+280Sy5RgGe6uxtfvBSEM6X1a8 Tvcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id; bh=lmC0NdjL61P94Vv9NHOO8C8gb82yMvka8NndVofAO5A=; fh=cKvjJ6xJKKxzqNmByKioDbfvZ2R7fwpj+P1eo0hVFPU=; b=Plst1wsiAzZwBY3OhcIESUvG15eZ2CVteR5YPuPgZ/35YDeXAKx4+1PkfyQiNEUXu3 Hc72fi0bMdSbpofRMd+KYOk3gde6UCB/Byt+rhb5LOmoAyBAdIxtePHh0wmPGeyRKZUV /sJhV7EAa6HMDybCVk92DcUTgC7Bmut0wj81TkfAmCF3lOcasH5W8ABzpEnbUqjDAzTA W7W/4YzWpJQ/HUO3CoMWSAb+YEDWVtjDbtIiSUuCdPCU4WE1OjeNjJrr6SvxWEOnBvPs dZe1A1wIBUjjtyCfHKXb1LgK1+wbG85Mg8hgy53BSW2aV2p5CjQ3ULXILuz5kM1Ij7jg fRXQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id i39-20020a0564020f2700b0051e5da60f04si277705eda.4.2023.07.28.01.58.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Jul 2023 01:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [IPv6:::1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 36S8wUbe031578 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Jul 2023 10:58:30 +0200 Message-ID: <87bbd28858624e7f8afec2470ae586140de31734.camel@ilbers.de> Subject: Re: [PATCH v3 11/11] optee-ftpm-stm32mp15x: Add patch to fix parallel build issues From: Uladzimir Bely To: Jan Kiszka , isar-users Cc: Bao Cheng Su Date: Fri, 28 Jul 2023 11:58:31 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 3iiaXf9Ipmo7 On Thu, 2023-07-20 at 19:08 +0200, 'Jan Kiszka' via isar-users wrote: > From: Jan Kiszka >=20 > Signed-off-by: Jan Kiszka > --- > =C2=A0.../0001-Fix-parallel-build-of-optee_ta.patch | 45 > +++++++++++++++++++ > =C2=A0.../optee-ftpm-stm32mp15x_0~230316+git.bb=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 1 + > =C2=A02 files changed, 46 insertions(+) > =C2=A0create mode 100644 meta-isar/recipes-bsp/optee-ftpm/files/0001-Fix- > parallel-build-of-optee_ta.patch >=20 > diff --git a/meta-isar/recipes-bsp/optee-ftpm/files/0001-Fix- > parallel-build-of-optee_ta.patch b/meta-isar/recipes-bsp/optee- > ftpm/files/0001-Fix-parallel-build-of-optee_ta.patch > new file mode 100644 > index 00000000..4ee20f41 > --- /dev/null > +++ b/meta-isar/recipes-bsp/optee-ftpm/files/0001-Fix-parallel-build- > of-optee_ta.patch > @@ -0,0 +1,45 @@ > +From ff34f1a64bd5dbc83df26cfc8e74478f854a0acf Mon Sep 17 00:00:00 > 2001 > +From: Jan Kiszka > +Date: Thu, 20 Jul 2023 16:32:26 +0200 > +Subject: [PATCH] Fix parallel build of optee_ta > + > +The symlink must be established prio to building any of the source > files > +of WolfSSL, or things will fail: > + > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0TA_CROSS_COMPILE=3D \ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0TA_CPU=3Dcortex-a7 \ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0TA_DEV_KIT_DIR=3D/usr/lib/opte= e-os/stm32mp15x/export-ta_arm32 \ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CFG_TEE_TA_LOG_LEVEL=3D2 \ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0CFG_FTPM_USE_WOLF=3Dy \ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/usr/bin/make -j 24 > +make[2]: Entering directory '/<>/Samples/ARM32- > FirmwareTPM/optee_ta' > +/usr/bin/make -C fTPM CROSS_COMPILE=3D > +make[3]: Entering directory '/<>/Samples/ARM32- > FirmwareTPM/optee_ta/fTPM' > +Checking symlink to the TPM folder: /<> > +Checking symlink to the WolfSSL folder: > /<>/external/wolfssl > +Establishing symlink. > +=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ../out/fTPM/platform/Cancel.o > +Establishing symlink. > +=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ../out/fTPM/platform/AdminPPI.o > +=C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ../out/fTPM/platform/Entropy.o > +make[3]: *** No rule to make target > 'lib/wolf/wolf_symlink/wolfcrypt/src/aes.c', needed by > '../out/fTPM/./lib/wolf/wolf_symlink/wolfcrypt/src/aes.o'.=C2=A0 Stop. > +make[3]: *** Waiting for unfinished jobs.... > + > +Signed-off-by: Jan Kiszka > +--- > + Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk | 2 ++ > + 1 file changed, 2 insertions(+) > + > +diff --git a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk > b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk > +index 0a43f46..eb239e3 100644 > +--- a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk > ++++ b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk > +@@ -56,3 +56,5 @@ srcs-y +=3D wolf_symlink/wolfcrypt/src/tfm.c > + srcs-y +=3D wolf_symlink/wolfcrypt/src/wolfmath.c > + srcs-y +=3D wolf_symlink/wolfcrypt/src/des3.c > + srcs-y +=3D wolf_symlink/wolfcrypt/src/random.c > ++ > ++$(srcs-y): wolf_symlink > +--=20 > +2.35.3 > + > diff --git a/meta-isar/recipes-bsp/optee-ftpm/optee-ftpm- > stm32mp15x_0~230316+git.bb b/meta-isar/recipes-bsp/optee-ftpm/optee- > ftpm-stm32mp15x_0~230316+git.bb > index 441bc4ac..c92620e1 100644 > --- a/meta-isar/recipes-bsp/optee-ftpm/optee-ftpm- > stm32mp15x_0~230316+git.bb > +++ b/meta-isar/recipes-bsp/optee-ftpm/optee-ftpm- > stm32mp15x_0~230316+git.bb > @@ -12,6 +12,7 @@ SRC_URI +=3D " \ > =C2=A0=C2=A0=C2=A0=C2=A0 > https://github.com/Microsoft/ms-tpm-20-ref/archive/${SRCREV}.tar.gz=C2=A0= \ > =C2=A0=C2=A0=C2=A0=C2=A0 > https://github.com/wolfSSL/wolfssl/archive/${SRCREV-wolfssl}.tar.gz;name= =3Dwolfssl > =C2=A0\ > =C2=A0=C2=A0=C2=A0=C2=A0 file://0001-add-enum-to-ta-flags.patch=C2=A0\ > +=C2=A0=C2=A0=C2=A0 file://0001-Fix-parallel-build-of-optee_ta.patch=C2= =A0\ > =C2=A0=C2=A0=C2=A0=C2=A0 " > =C2=A0 > =C2=A0SRCREV =3D "f74c0d9686625c02b0fdd5b2bbe792a22aa96cb6" > --=20 > 2.35.3 >=20 Found easy way to reproduce the issue with local build. Need to just add small delay before symlink creation like: diff --git a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/tpm/sub.mk b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/tpm/sub.mk index 68bdfe2..a3ddade 100644 --- a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/tpm/sub.mk +++ b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/tpm/sub.mk @@ -45,7 +45,8 @@ endif then \ echo Symlink already established ; \ else \ - echo Establishing symlink. ; \ + echo Establishing symlink $@. ; \ + sleep 1 ; \ ln -s ../../$(TPM_ROOT) ./lib/tpm/tpm_symlink; \ fi =20 diff --git a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk index 0a43f46..44deafd 100644 --- a/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk +++ b/Samples/ARM32-FirmwareTPM/optee_ta/fTPM/lib/wolf/sub.mk @@ -30,7 +30,8 @@ cflags-y +=3D $(WOLF_SSL_FLAGS) $(WOLF_WARNING_SUPPRESS) then \ echo Symlink already established ; \ else \ - echo Establishing symlink. ; \ + echo Establishing symlink $@. ; \ + sleep 1 ; \ ln -s ../../$(WOLF_ROOT) ./lib/wolf/wolf_symlink; \ fi =20 If makefile dependencies were OK, it would not lead to the issue. But it is... And, things like adding `+$(srcs-y): wolf_symlink` don't work.