From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026321669488640000 X-Received: by 2002:a05:6402:270c:: with SMTP id y12mr67119138edd.258.1637594917386; Mon, 22 Nov 2021 07:28:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:5941:: with SMTP id g1ls2936429ejr.10.gmail; Mon, 22 Nov 2021 07:28:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDreauI0JoIUEY/DOpkVuSjnsrMbwqJz9vEJf1DxG3Pyzj66ueLigZwRAon5QitjZ5meau X-Received: by 2002:a17:907:2da2:: with SMTP id gt34mr39414489ejc.372.1637594916391; Mon, 22 Nov 2021 07:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637594916; cv=none; d=google.com; s=arc-20160816; b=YrPOnjkArNeEq4jToYrsJhvOQN4w/oUfi1HIoBFIT8cFHvxr1uJpPK+JWCzSsgb1OX UEjZ93L8sEE2MCz8I4/THauW1AqM/TABrEN3NW53/3P3sNPZNz0S7P/Y7Iqe0DAQmdJr Z7OtSUhS7h+n+9kdeQJQL4hEaCI8MFDHsmniog5FbnL8jWXnXKKf4fOIYCJ+V2e7smgO +B69h8Z69cmwUAQNL3Ro5b700o9Pp5rLV2ogwFLeC6LCP8KpWctC91OM16Wu7vjd5+J5 dwQGhq+Acdrf3e+uq2pQ4raVbixGi7xdkxAJa9uNVxbXWc6r/816iUBu0raXhuuL1Q3w XW5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=SmuI4RgltrQ6oGxumyKJUB7mXHCXw1ynkL3f7vakMKA=; b=A1cujhuLyH6UOB2AZic4nhqqWzYOsaiLYHpt2NdJrDOV8vEeVyfPm7iGPRpC54JEkT xmZydI7b23NV07xmf0wHzrnQYAgXUGDoyY3NPufPm9AcA3s/neIEtcXobS0/B1LLSiTr vtHmCChLDxe5Of/6loMavBTugPBAowWvwsazhs20fL8Z+WlfNJy8falHmYCrxfGUDYrM oxghmHWHL6pSAhjaB8odKocbE/8/Gfs+2AN7wfPXAFKhRIjeFSDUJWZ3aNudyg2P50/h c0XTrIKTLBBVnrWPNwh/y8yRDMmiAiaEK0QFwPi0gpIu6Emy/VeUw7yJifymUJXnokle NZCw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id o19si474684edz.5.2021.11.22.07.28.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Nov 2021 07:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-237-77-214-37.mgts.dynamic.pppoe.byfly.by [37.214.77.237] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1AMFSY9d005236 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Nov 2021 16:28:35 +0100 Subject: Re: [PATCH v4 0/2] Improve handling of ISAR_RELEASE_CMD To: "Moessbauer, Felix" Cc: "isar-users@googlegroups.com" , "henning.schild@siemens.com" , "Schmidt, Adriaan" , Baurzhan Ismagulov References: <20211104110507.2358692-1-felix.moessbauer@siemens.com> <4bf7b75d-f431-9a07-96f0-a1168af073d3@ilbers.de> From: Anton Mikanovich Message-ID: <8836f60a-e1f6-59e6-1343-cdb5902dbf96@ilbers.de> Date: Mon, 22 Nov 2021 18:28:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: NEKd9UbbgS9l 17.11.2021 18:57, Moessbauer, Felix wrote: >> -----Original Message----- >> From: Anton Mikanovich >> Sent: Wednesday, November 17, 2021 2:06 PM >> To: Moessbauer, Felix (T RDA IOT SES-DE) >> Cc: isar-users@googlegroups.com >> Subject: Re: [PATCH v4 0/2] Improve handling of ISAR_RELEASE_CMD >> >> 17.11.2021 13:45, Moessbauer, Felix wrote: >>> Hi Anton, >>> >>> Unfortunately I cannot reproduce this, but this is very likely related to a not >> idempotent ISAR_RELEASE_CMD. >>> As stated in the API changelog, the ISAR_RELEASE_CMD shall be idempotent >> (and technically must be for MC targets). >>> By that, no things like timestamps must be included. >>> >>> If you point me to the location where the ISAR_RELEASE_CMD is set for CI >> builds, I can have a look. >>> Another issue could be that changes to the git happen during build (e.g. adding >> a tag, making the repo dirty, etc...). >>> In that case (starting with a clean build, ending up with a dirty one), the CI >> generated files have to be added to the .gitignore. >>> In Yocto there is a lengthy discussion about the idempotence sanity check [1] >> and why recipes have to be written in this way. >>> Best regards, >>> Felix >>> >>> [1] >>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >>> >> hwork.openembedded.org%2Fpatch%2F133517%2F&data=04%7C01%7Cfe >> lix.mo >> essbauer%40siemens.com%7C8e3a031610c74e6dd76c08d9a9caf3f5%7C38ae3 >> bcd95 >> 794fd4addab42e1495d55a%7C1%7C0%7C637727511405820881%7CUnknown% >> 7CTWFpbG >> Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn >> 0% >> 3D%7C3000&sdata=od2HCs8VUwZqOzifBdItzcjb5a7j85g33J44%2BiMMjCM >> %3D&a >>> mp;reserved=0 >>> >> Default ISAR_RELEASE_CMD can be found in meta/classes/image.bbclass as: >> ISAR_RELEASE_CMD_DEFAULT = "git -C ${LAYERDIR_core} describe --tags -- >> dirty --match 'v[0-9].[0-9]*'" >> which results in something like `v0.7-534-g6752a45` This issue is reproduced >> inside Jenkins only, but not locally or in gitlab/kas. > Then it's likely that Jenkins modifies files in the source tree. > One thing you could try is to explicitly make the git "dirty", or simply try a static ISAR_RELEASE_CMD. > > Anyways, how should we proceed here? > > Felix >> -- >> Anton Mikanovich >> Promwad Ltd. >> External service provider of ilbers GmbH Maria-Merian-Str. 8 >> 85521 Ottobrunn, Germany >> +49 (89) 122 67 24-0 >> Commercial register Munich, HRB 214197 >> General Manager: Baurzhan Ismagulov We've reproduced the issue even locally without CI by manually setting username, clone and build: $ sudo chroot --userspec= /bin/bash -c "cd /tmp && git clone -b https://github.com/ilbers/isar/ isar-repo && cd isar-repo && source isar-init-build-env && bitbake mc:qemuamd64-bullseye:isar-image-base" So the issue is related to chroot build but not only Jenkins. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov