public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>
Subject: [PATCH 2/4] sbuild-chroot: Skip initramfs generation while installing build dependencies
Date: Mon, 15 Sep 2025 12:07:11 +0200	[thread overview]
Message-ID: <88ca507a0d71bcd597761b24f1862c9dc01b6cd1.1757930833.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1757930833.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

We have no need for an initramfs while building packages. Therefore,
keep the update-initramfs stub inside the sbuild-chroots so that they
are working also while build dependencies are installed.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/rootfs.bbclass                        | 14 ++++++++++----
 .../sbuild-chroot/sbuild-chroot.inc                |  2 ++
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index d91fecb0..de8077e6 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -187,6 +187,10 @@ rootfs_disable_initrd_generation() {
 
     mkdir -p "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
     ln -s /usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/update-initramfs
+
+    mkdir -p '${ROOTFSDIR}/etc/apt/apt.conf.d'
+    echo 'DPkg::Path ${ROOTFS_STUBS_DIR}:/usr/sbin:/usr/bin:/sbin:/bin;' \
+        > '${ROOTFSDIR}/etc/apt/apt.conf.d/50isar-stubs'
 EOSUDO
 }
 
@@ -251,15 +255,17 @@ rootfs_install_pkgs_install[progress] = "custom:rootfs_progress.PkgsInstallProgr
 rootfs_install_pkgs_install[network] = "${TASK_USE_SUDO}"
 rootfs_install_pkgs_install() {
     sudo -E chroot "${ROOTFSDIR}" \
-        /usr/bin/apt-get ${ROOTFS_APT_ARGS} \
-            -o DPkg::Path='${ROOTFS_STUBS_DIR}:/usr/sbin:/usr/bin:/sbin:/bin' \
-            ${ROOTFS_PACKAGES}
+        /usr/bin/apt-get ${ROOTFS_APT_ARGS} ${ROOTFS_PACKAGES}
 }
 
 ROOTFS_INSTALL_COMMAND += "rootfs_restore_initrd_tooling"
 rootfs_restore_initrd_tooling[weight] = "1"
 rootfs_restore_initrd_tooling() {
-    sudo rm -rf "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
+    sudo -s <<'EOSUDO'
+    set -e
+    rm -f "${ROOTFSDIR}/etc/apt/apt.conf.d/50isar-stubs"
+    rm -rf "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
+EOSUDO
 }
 
 ROOTFS_INSTALL_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'no-generate-initrd', 'rootfs_clear_initrd_symlinks', '', d)}"
diff --git a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
index 98e427e5..479aa91d 100644
--- a/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
+++ b/meta/recipes-devtools/sbuild-chroot/sbuild-chroot.inc
@@ -57,6 +57,8 @@ ROOTFSDIR = "${SBUILD_CHROOT_DIR}"
 ROOTFS_PACKAGES = "${SBUILD_CHROOT_PREINSTALL}"
 ROOTFS_FEATURES += "no-generate-initrd"
 
+ROOTFS_INSTALL_COMMAND:remove = "rootfs_restore_initrd_tooling"
+
 ROOTFS_POSTPROCESS_COMMAND:remove = "rootfs_cleanup_isar_apt"
 
 # Do not cleanup base-apt
-- 
2.51.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/88ca507a0d71bcd597761b24f1862c9dc01b6cd1.1757930833.git.jan.kiszka%40siemens.com.

  parent reply	other threads:[~2025-09-15 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 10:07 [PATCH 0/4] Several micro-optimizations 'Jan Kiszka' via isar-users
2025-09-15 10:07 ` [PATCH 1/4] rootfs: Implement update-initramfs stubs via symlink 'Jan Kiszka' via isar-users
2025-09-15 10:32   ` 'MOESSBAUER, Felix' via isar-users
2025-09-15 10:07 ` 'Jan Kiszka' via isar-users [this message]
2025-09-15 10:33   ` [PATCH 2/4] sbuild-chroot: Skip initramfs generation while installing build dependencies 'MOESSBAUER, Felix' via isar-users
2025-09-15 10:07 ` [PATCH 3/4] rootfs: Avoid unneeded commands inside chroot 'Jan Kiszka' via isar-users
2025-09-15 10:07 ` [PATCH 4/4] image-locales-extension: Optimize package removal 'Jan Kiszka' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88ca507a0d71bcd597761b24f1862c9dc01b6cd1.1757930833.git.jan.kiszka@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox