Re: [PATCH v6 0/7] vm-img improvements and fixes

[Anton Mikanovich <amikan@ilbers.de>]

17.12.2021 17:48, Anton Mikanovich wrote:
> changes since v5:
>   - base on v4, not v3 as previous version
>
> changes since v4:
>   - format commit messages
>
> changes since v3:
>   - change the way we play with the SRC_URI path in p1
>   - adding cover letter again
>
> changes since v2:
>   - change avocado code and move renamed bullseye test into another test
>
> changes since v1:
>   - rebase on next/avocado
>
>
> The vm-img support we currently have is a bit broken in various aspects.
> Most prominently the resulting ova files are accepted by vmware only
> with warnings. And UEFI booting did not really work in virtualbox or
> vmware.
>
> This series makes the template for the appliance a file one can override
> with a custom template. Which should allow close to any special
> configuration that the VMMs can express in their respective ovf
> dialects. It further makes changes to the templates we ship with isar to
> hopefully give people a decent baseline so they will not even need
> custom templates. And there is some code cleanup to the vm-img class.
>
> Henning Schild (7):
>    vm-img: move template out of package into SRC_URI file
>    vm-img: use two different ovf templates for vmware/virtualbox
>    vm-img: shorten code by using variables we have
>    vm-img: drop not used variables
>    vm-img: set vmware machine type to 64bit in our template
>    vm-img: make use of isars template class for most of the tmpl
>      variables
>    meta-isar: switch virtualbox test from buster to bullseye
>
>   meta-isar/conf/local.conf.sample              |   2 +-
>   meta-isar/conf/machine/vmware.conf            |   2 +
>   ...a-buster.conf => virtualbox-bullseye.conf} |   2 +-
>   meta/classes/vm-img.bbclass                   |  35 ++---
>   .../vm-img/vm-img-virtualbox.ovf.tmpl}        | 132 +++++++-----------
>   meta/classes/vm-img/vm-img-vmware.ovf.tmpl    | 127 +++++++++++++++++
>   .../vm-template/vm-template_0.1.bb            |  16 ---
>   testsuite/build_test/build_test.py            |   6 +-
>   8 files changed, 199 insertions(+), 123 deletions(-)
>   rename meta-isar/conf/multiconfig/{virtualbox-ova-buster.conf => virtualbox-bullseye.conf} (77%)
>   rename meta/{recipes-devtools/vm-template/files/vm-template.ovf.tmpl => classes/vm-img/vm-img-virtualbox.ovf.tmpl} (54%)
>   create mode 100644 meta/classes/vm-img/vm-img-vmware.ovf.tmpl
>   delete mode 100644 meta/recipes-devtools/vm-template/vm-template_0.1.bb
>
Applied to next, thanks.

-- 
Anton Mikanovich
Promwad Ltd.
External service provider of ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn, Germany
+49 (89) 122 67 24-0
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov