Re: [PATCH 2/2] Warn if systemd-firstboot misses configurations

[Florian Bezdeka <florian.bezdeka@siemens.com>]

On Tue, 2022-11-22 at 13:04 +0300, Anton Mikanovich wrote:
> 19.11.2022 21:20, T. Schaffner wrote
> > From: Tobias Schaffner <tobias.schaffner@siemens.com>
> > 
> > systemd-firstboot checks the existence of different system configurations
> > like locale or hostname. Debian packages may trust that these configurations
> > are in the location that systemd-firstboot enforced.
> > 
> > Warn the user in the image postproc step if systemd-firstboot misses any
> > configurations in the image.
> > 
> > Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> 
> If we have a warning here, do we really need to mask the service in p1?
> User should fix the reason but not hide it, and masking can be optional just
> in case there are no other ways.

I didn't have the time to review the patches in detail yet, so I might
be wrong. But: If systemd-firstboot is enabled (not masked) and we miss
one of the config settings that it checks the image won't boot up.

It will enter a interactive mode and ask you questions on how to
configure your system (locale, keyboard layout, ...). Especially for CI
and embedded systems that's a real issue.

So I guess the idea was to simply mask systemd-firstboot (we don't like
interactive mode) and warn the user that the system might not be fully
configured.

Tobias, please correct me if need to.

Florian

>