From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7167793861521047552 X-Received: by 2002:a5d:5a92:0:b0:241:cc91:4166 with SMTP id bp18-20020a5d5a92000000b00241cc914166mr7904944wrb.544.1669112700905; Tue, 22 Nov 2022 02:25:00 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:1f9a:b0:225:6559:3374 with SMTP id bw26-20020a0560001f9a00b0022565593374ls774337wrb.2.-pod-prod-gmail; Tue, 22 Nov 2022 02:24:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf6IuiuvzJ9H+mMk5VYzAuS5H6U1c0AtGFSV78MkHzNBkgZW2p3P0mGVnjKn2MTsNtKKxP2O X-Received: by 2002:a5d:4c91:0:b0:236:6d6b:fb56 with SMTP id z17-20020a5d4c91000000b002366d6bfb56mr13961118wrs.198.1669112699718; Tue, 22 Nov 2022 02:24:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669112699; cv=none; d=google.com; s=arc-20160816; b=gzhGDqBqjDcGtbxPAQxlsIw24pIAqeio1cjh+IEanCjgB3MzEgXiff/o3I4WiklgCI EiosxNoPxm+3tSNRt3J/L0j6aj1w1UE+H1R4/w9C9tuE+bp9098CbNPDV3zIq2AiquyD QLjVAWJUUpfRgcm3CVoFkZgddRznGBOsYE71PntY9ljLD+KxhMXfi55EfZ8E7XJxpQvW EfbXi95ona9tgXxIx3XVeruaauuLm0Gdd92i6wKOjwWKBDEaEjcKmXSTxrvmPiADdZ+9 SdYqfhfCc5vpnpbMQeQNNVgso0V+iQfHiqOzEF+TXgv7HFwV7qzn05O4fmfuHiRsOYdN vNtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=qpGlgMG+6FdlFk1VfaafJ/sDtsc2UtOcOSD0+0PS/HY=; b=eCvilyTA3CA93/vxhq+vqrMBybP7s1f1WFO2rLDx5FHVHQ8MmWukzzxSEngRRUUhKB EjE8vd7rVeZ0g+QSVZJMiRoTTRTJlFaIholQ6ayyXM8MAn3e3dfA6t1KIeqRemB3YWOW Ibo+mVTPxeTpbqNd1ZuzQwOyqANtwH1fFnihwlrvjzK96z9kW+Ke+OYk6vuwGLEEMf1C RjRz0MyK7VnWO6X8TTEU/IZwi+YUf9Ed1bEAsBTrkOdPFfUYIx75MRcZcssZOyZhyA9i ijjl4fn8w7ssntl+SqPTR8LjU03aNA8SCQWveAr3ErjiPgqxGPrIoNdUukqK2qoTyzIg a2wQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=RTsG6HcR; spf=pass (google.com: domain of fm-68982-2022112210245427cdfd25d76c3d8755-wl2jwb@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-68982-2022112210245427cdfd25d76c3d8755-Wl2Jwb@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net. [185.136.64.227]) by gmr-mx.google.com with ESMTPS id e5-20020a05600c4e4500b003c6c0197f3dsi672026wmq.2.2022.11.22.02.24.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 02:24:59 -0800 (PST) Received-SPF: pass (google.com: domain of fm-68982-2022112210245427cdfd25d76c3d8755-wl2jwb@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) client-ip=185.136.64.227; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=RTsG6HcR; spf=pass (google.com: domain of fm-68982-2022112210245427cdfd25d76c3d8755-wl2jwb@rts-flowmailer.siemens.com designates 185.136.64.227 as permitted sender) smtp.mailfrom=fm-68982-2022112210245427cdfd25d76c3d8755-Wl2Jwb@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 2022112210245427cdfd25d76c3d8755 for ; Tue, 22 Nov 2022 11:24:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=florian.bezdeka@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=qpGlgMG+6FdlFk1VfaafJ/sDtsc2UtOcOSD0+0PS/HY=; b=RTsG6HcRz1sDQAOztQungMG7GjPbPOEOGRv8pNyx6WdfTngfowwCWAftbndpXmt/gONc8B q0ukDj5IUuS4MHBsVDqXYyY9axERGqp+ZAdC4hjqfCimDoO51Xjiy562dR1n4NXtVV1PiluV 5I8RMGXpmLNcxd/Dl+JhWT8DZxVfo=; Message-ID: <892fe496354a967054e63a67fbba59268f372548.camel@siemens.com> Subject: Re: [PATCH 2/2] Warn if systemd-firstboot misses configurations From: Florian Bezdeka To: Anton Mikanovich , "T. Schaffner" , isar-users@googlegroups.com Cc: quirin.gylstorff@siemens.com Date: Tue, 22 Nov 2022 11:24:53 +0100 In-Reply-To: <08d391d5-cb8c-4a49-826d-51b69cd7ef07@ilbers.de> References: <20221119182031.2005807-1-tobias.schaffner@siemens.com> <20221119182031.2005807-3-tobias.schaffner@siemens.com> <08d391d5-cb8c-4a49-826d-51b69cd7ef07@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-TUID: DDPQrMWbn5+G On Tue, 2022-11-22 at 13:04 +0300, Anton Mikanovich wrote: > 19.11.2022 21:20, T. Schaffner wrote > > From: Tobias Schaffner > >=20 > > systemd-firstboot checks the existence of different system configuratio= ns > > like locale or hostname. Debian packages may trust that these configura= tions > > are in the location that systemd-firstboot enforced. > >=20 > > Warn the user in the image postproc step if systemd-firstboot misses an= y > > configurations in the image. > >=20 > > Signed-off-by: Tobias Schaffner >=20 > If we have a warning here, do we really need to mask the service in p1? > User should fix the reason but not hide it, and masking can be optional j= ust > in case there are no other ways. I didn't have the time to review the patches in detail yet, so I might be wrong. But: If systemd-firstboot is enabled (not masked) and we miss one of the config settings that it checks the image won't boot up. It will enter a interactive mode and ask you questions on how to configure your system (locale, keyboard layout, ...). Especially for CI and embedded systems that's a real issue. So I guess the idea was to simply mask systemd-firstboot (we don't like interactive mode) and warn the user that the system might not be fully configured. Tobias, please correct me if need to. Florian >=20