public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Zhihang Wei <wzh@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH v2 1/1] refactor: drop useless sudo from do_generate_keyrings
Date: Tue, 24 Feb 2026 09:40:43 +0100	[thread overview]
Message-ID: <8950f29d-806b-4fc7-a5f1-09806fcc0c6e@ilbers.de> (raw)
In-Reply-To: <20260218122051.3978253-1-felix.moessbauer@siemens.com>

Applied to next, thanks.

Zhihang

On 2/18/26 13:20, 'Felix Moessbauer' via isar-users wrote:
> This task does not execute sudo, so we don't need to set the
> corresponding bitbake hint. It further does not do networking, so it is
> safe to remove the hint.
>
> Fixes: 9ae41e03 ("mmdebstrap: Move preparations to hooks")
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> index c90bc59c..7330bc51 100644
> --- a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> +++ b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
> @@ -51,7 +51,6 @@ def get_apt_opts(d, param):
>   do_generate_keyrings[cleandirs] = "${WORKDIR}/trusted.gpg.d"
>   do_generate_keyrings[dirs] = "${DEBDIR}"
>   do_generate_keyrings[vardeps] += "DISTRO_BOOTSTRAP_KEYS THIRD_PARTY_APT_KEYS"
> -do_generate_keyrings[network] = "${TASK_USE_SUDO}"
>   do_generate_keyrings() {
>       export GNUPGHOME="$(mktemp -td gpghomeXXXXXXXXXX)"
>       if [ -n "${@d.getVar("THIRD_PARTY_APT_KEYFILES") or ""}" ]; then

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/8950f29d-806b-4fc7-a5f1-09806fcc0c6e%40ilbers.de.

      reply	other threads:[~2026-02-24  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 12:20 'Felix Moessbauer' via isar-users
2026-02-24  8:40 ` Zhihang Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8950f29d-806b-4fc7-a5f1-09806fcc0c6e@ilbers.de \
    --to=wzh@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox