From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026325955122561024 X-Received: by 2002:a5d:64ad:0:b0:20a:7bc8:d42 with SMTP id m13-20020a5d64ad000000b0020a7bc80d42mr83146wrp.140.1650552171501; Thu, 21 Apr 2022 07:42:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:1d8c:b0:207:aa22:e989 with SMTP id bk12-20020a0560001d8c00b00207aa22e989ls6944979wrb.1.gmail; Thu, 21 Apr 2022 07:42:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVxLVvkjB2f5l7WyTIOB4gVGdLZlGfzPuqpBEiSABYFeHoz18tbye4v8ALlzYyLLFd/iqe X-Received: by 2002:a5d:6da9:0:b0:20a:8688:9657 with SMTP id u9-20020a5d6da9000000b0020a86889657mr54125wrs.700.1650552170327; Thu, 21 Apr 2022 07:42:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1650552170; cv=pass; d=google.com; s=arc-20160816; b=IPdPErEiZzEpOSgzeA/QeZCOThtG9+81EdFTm5K80m69zj8Asnc7rL9XA8HWQLUHUD 1I9WgOpQEWw4H4eM3FJYnTgH0EjE2BNiD6OjGaTsJdll7o0CGLFYyhJFyR0sbtm5gq4T vuSiYE8Rc7EEPSxWzvkH+/44cZx6xc71GrYHZC8wZAhk0dEjJScU8XetyW7uo/5E+aDd k2RB5sTRiZ4CDtC1oWPt87/ZgX1B4bHAlKhyFWYEzid2kppkhpu18QH9fCZMi6oL4A81 jnkGGS6tZEWZa2kz+yxgDPAsraPAKQJTK+VzLq0KepXAg27DXRza3KTKKUAOCLqhdGr8 EHnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=JTMUqMb7WaxhppL3egMovpReBdkOuFXZfHoov5mLVew=; b=JtJYLX4ktCkSMMqWVweIvwO8ClC2CoMV9Gezg9NyGtRRo16/uwHShGVF2t7OnyKznR ZQOI9Fjkpvc2X50WXGTUYd4vY9zO0rfGUR+LuG2EIwiy3y+GpPPKTZyjiOFjd5Ur0fza pHgWKKjRLMGCSxv6rDIU3NMvlwQyrkWdY+fdwuoJIVbuS/NiReRvfuGJzFwEgwuwyYZr T4cYYuCage7w4wQnEJl+ejaYPJ4DYgBWzFHzIZD1Wifg1d/dd05wZ0nUr++J/9/4LuDe poGCnZmEc23n7Miwrx6dJuU7U3lETD5n0EPEtqWVcYWX3QQ3ZJ220CuZdGi+YgyplBxj jTVg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HYaTDPhn; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::628 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0628.outbound.protection.outlook.com. [2a01:111:f400:fe0e::628]) by gmr-mx.google.com with ESMTPS id v3-20020adfe283000000b0020aa8063034si150048wri.5.2022.04.21.07.42.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Apr 2022 07:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::628 as permitted sender) client-ip=2a01:111:f400:fe0e::628; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=HYaTDPhn; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::628 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMGD5G9QT925wdXz3b75EkODequRTs9sP5foiqFzONJcd5F+/X/bI2wofnLZF77bI68tejraTrmd6rFzPStKeE2zNH8ftx2lcUWRhQT+6ssbtDnYMcieJ0VFQABT1rCpSXNtYZfTlCQbz6TWycwT/R4hW4AO3RlO+OC+uFB8ighkHDBuebI+WSlXkJQR6oOC3VklkNJKveX8UyuiiNKo7iN//mf7CaJm2Ee3wd8ghXzisOC7kq3dGr/HYxh1ymvoT9KZ0rS3IKTIDetU8R2JC9+vP0pbOLA3M0H8gP8SpDgIwD7iYxv0MYDfYdHRDwJVTxHlpkLwCT1MfPd+wsSm/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTMUqMb7WaxhppL3egMovpReBdkOuFXZfHoov5mLVew=; b=krBoKU0vpDI06pbPdJuep0qz0Uq3lCaeMFGCXRPWKZTnqkXWTIXK+TNRCBujStuYHuaSbXzdD6OOvBbpP1Bmda1GwQdhcOC7szZbN7yLyI9n6CSxQUukXt0EBZb0AM2Qb8kzzxr4nQCeCEU4b6alF4EMRxpl53AXECg4AslBNJhav+3NKSU4nyiJdBGBKloDuU9SJBKmUxUwd8BcVqcUXu10rRFBeyA9U3Z5N8t/MgHztIjE1NOyXuq9wIaO0oFkQ8Us/jOzsXN5PX8sHoSFxM5VDzy672sOD55RlvWCqGnXYU5v/ooCmA8WOuqZgVfboPncR50LcsqTNu3VyS3vDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTMUqMb7WaxhppL3egMovpReBdkOuFXZfHoov5mLVew=; b=HYaTDPhns30gsmYKEq/8EmpSM/ITtxj6tW83yty7rc77Eq9+vHJK7nvhFCZTWQ9kwlcDiJMCIVn1G2sg89gSOEk/qcev/HCvxxkFPoQm9l/llIqjPrBaUqMvdByoPtDF7hvv/3J1g0NtVQOhZCjjiNB8g4Oh53vG9FmX5/cb1XzWy0RgjD6NFlb36M9ttY+s68+sKTplcTr+gGk9lQiJEyueY4j0nVJrtfEPguWrs4gKRJlU6eZiRey6kC0pGbb+YVR+t5AAvnSVmQ6PkWW44tw9arexgng2FIr73ZpPlvqhGXuk3BS9pxdRvDIVFe7fF4Sr6bE9K9ggvmX9LQcswA== Received: from OL1P279CA0029.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:13::16) by DU0PR10MB6106.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3e2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Thu, 21 Apr 2022 14:42:49 +0000 Received: from HE1EUR01FT012.eop-EUR01.prod.protection.outlook.com (2603:10a6:e10:13:cafe::19) by OL1P279CA0029.outlook.office365.com (2603:10a6:e10:13::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 14:42:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.72) by HE1EUR01FT012.mail.protection.outlook.com (10.152.0.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 14:42:48 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 16:42:48 +0200 Received: from [167.87.32.12] (167.87.32.12) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 16:42:47 +0200 Message-ID: <897a2e79-b473-17e0-8670-0250614eee67@siemens.com> Date: Thu, 21 Apr 2022 16:42:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1 1/1] Fix permissions when splitting rootfs folders across partitions. Content-Language: en-US From: Jan Kiszka To: Felix Moessbauer , CC: , References: <20211103125305.3021016-1-felix.moessbauer@siemens.com> <127b5e2e-617f-5934-e9d6-54a88664bf6c@siemens.com> In-Reply-To: <127b5e2e-617f-5934-e9d6-54a88664bf6c@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.12] X-ClientProxiedBy: DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--19.854900-8.000000 X-TMASE-MatchedRID: 72nS2hokiaQ5QaOxwNGfvo9bHfxDWoibY3OL7ApT7xOuqcLqu7Q6dpGS Fsk3mVu+MiAFcbKYj96Egpd7r2FIki25Nk9Tq7Y7Q3OJUoK6MKVRjX8m+YMufpRpgJ74o180ljg w/8s6b3cHZBaLwEXlKIPcXuILVCbaNijPhbt+TiBBm2HkyXqcNSBC8bIaSspa9Ib/6w+1lWS0P8 vH4t+8S4IXP2KSJplGADkYnZWswCAH7YIJ6ubSlC8cRwTHQ3O6Mu8LwvFHOh327WtDgGBc8n0tC KdnhB58vqq8s2MNhPCy5/tFZu9S3Ku6xVHLhqfxvECLuM+h4RB+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--19.854900-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 1F63F8CA3E75F32718CAE521AA62E34CDFEB9D72F8DEAA98DEFCDEF1AE2E9A3F2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2df4793f-1e1b-4691-83ae-08da23a534c1 X-MS-TrafficTypeDiagnostic: DU0PR10MB6106:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PmFCMJ2GzsGuAJwUhazffqTswiBTd41W469MbOAHZ3vbPHVtxTuwkhq9u5kQVoVb8cdziN66TNQexY+hmDUznthkEanpK2xslafaNO/GINMKeGLMPoj1Nh09C/cwPD59xhSmENOauMQEv3+7YT+VoP/1opRr1SckDvsORU+tAVMWoo89DcUMpfhVV6eFeMlQe0IoxsnDKHaCspYizdhfxNs4N8B0TjLqXJeH+YW7RvbWUaNUeTX+7tSKpq7A1iI6Mftr/eZJItYgVjThSYMC5R0qh3QmCS/nDBG6ZRKiclNNAPqsWzjbGZcsVPSKTP2llt3cHTfOsjVfsgI2t+mUCrCjRbw/SzjYs14b0OYy7GjMuBfo5y9ZOHMAVWbDOwtksP5dbFqn6tdAIiTeAE2xqW5M+4qUywgh0JaedWAG/3Awx+Kbamok2sCU2y4RbFOQRJ3n/RHG9X1OBbGLo09ueXd2mUPHXhJmxMfrEXc+Vw5OflVDnpuqSYLQ1SK/MzN0UWFnbDLDcDfG1DR5IyQlDRNX5P6aCEa2rc8VXXzG1G58qO6mJCA6oqq7w79fTKdB0UKNScJ1Icr4mzTZ1Uf/i6VVgKtjJgPx2RiL9NzKwGjSwTcgnveqwaliyNlGpVQxBCiDs3J3MdoiUXa4RCV+z8iNTr0+/XuI9qu8poDovFTi613OhujINpAgQF+1olz0Peq3+2Bonb8FZfCgkIxUokzeWEFXormHYBPV83Y4cwbC2RwUINLmA7swyKpK+eYy839lktghwAKlwxMASoR1/A== X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(86362001)(31686004)(4326008)(2616005)(107886003)(16526019)(70206006)(186003)(47076005)(508600001)(44832011)(83380400001)(26005)(31696002)(40460700003)(36860700001)(82310400005)(2906002)(956004)(16576012)(36756003)(8936002)(53546011)(336012)(5660300002)(8676002)(81166007)(316002)(82960400001)(54906003)(70586007)(6706004)(356005)(110136005)(3940600001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:42:48.7131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2df4793f-1e1b-4691-83ae-08da23a534c1 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT012.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6106 X-TUID: 7jeAUwgEgMtC On 03.11.21 14:26, Jan Kiszka wrote: > On 03.11.21 13:53, Felix Moessbauer wrote: >> This patches ensures that the file database containing the file and >> folder usernames and permissions is always located relative to the >> source and not to the appended rootfs-dir. >> >> Prior to this patch, the database was not found when using >> -rootfs-dir in the WIC script, leading to erronous file >> permissions and ownership. >> >> Signed-off-by: Felix Moessbauer >> --- >> scripts/lib/wic/plugins/source/rootfs.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py >> index 96d940a..5ab771e 100644 >> --- a/scripts/lib/wic/plugins/source/rootfs.py >> +++ b/scripts/lib/wic/plugins/source/rootfs.py >> @@ -95,7 +95,7 @@ class RootfsPlugin(SourcePlugin): >> >> part.rootfs_dir = cls.__get_rootfs_dir(rootfs_dir) >> part.has_fstab = os.path.exists(os.path.join(part.rootfs_dir, "etc/fstab")) >> - pseudo_dir = os.path.join(part.rootfs_dir, "../pseudo") >> + pseudo_dir = os.path.join(krootfs_dir['ROOTFS_DIR'], "../pseudo") >> if not os.path.lexists(pseudo_dir): >> logger.warn("%s folder does not exist. " >> "Usernames and permissions will be invalid " % pseudo_dir) >> > > Upstream first: first OE, then Isar. At least submit to OE first. If > it's urgent, we can still decide to apply here earlier. > What's the status here? Asking as I see this patch more and more in downstream layers, and it's needed there. Jan -- Siemens AG, Technology Competence Center Embedded Linux