Re: [PATCH] u-boot-custom: Use bitbake variables instead of hardcoded values

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

On 11/20/18 12:48 PM, Henning Schild wrote:
> Make use of PN and P instead of hardcoding these strings.

Applied to the 'next',

Thanks,
Maxim.

> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>   meta-isar/recipes-bsp/u-boot/u-boot_2018.09.bb | 2 +-
>   meta/recipes-bsp/u-boot/files/debian/control   | 6 +++---
>   meta/recipes-bsp/u-boot/u-boot-custom.inc      | 2 +-
>   3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta-isar/recipes-bsp/u-boot/u-boot_2018.09.bb b/meta-isar/recipes-bsp/u-boot/u-boot_2018.09.bb
> index e0f756c..4ac0a5e 100644
> --- a/meta-isar/recipes-bsp/u-boot/u-boot_2018.09.bb
> +++ b/meta-isar/recipes-bsp/u-boot/u-boot_2018.09.bb
> @@ -6,6 +6,6 @@
>   require recipes-bsp/u-boot/u-boot-custom.inc
>   
>   SRC_URI += " \
> -    ftp://ftp.denx.de/pub/u-boot/u-boot-2018.09.tar.bz2 \
> +    ftp://ftp.denx.de/pub/${PN}/${P}.tar.bz2 \
>       "
>   SRC_URI[sha256sum] = "839bf23cfe8ce613a77e583a60375179d0ad324e92c82fbdd07bebf0fd142268"
> diff --git a/meta/recipes-bsp/u-boot/files/debian/control b/meta/recipes-bsp/u-boot/files/debian/control
> index 6b4c839..e0ea3eb 100644
> --- a/meta/recipes-bsp/u-boot/files/debian/control
> +++ b/meta/recipes-bsp/u-boot/files/debian/control
> @@ -5,15 +5,15 @@ Standards-Version: 3.9.6
>   Build-Depends: @BUILD_DEPENDS@
>   Maintainer: ISAR project <isar-users@googlegroups.com>
>   
> -Package: u-boot-@MACHINE@
> +Package: @PN@-@MACHINE@
>   Architecture: @DISTRO_ARCH@
>   Description: @DESCRIPTION@, bootloader binaries
>   
> -Package: u-boot-@MACHINE@-dev
> +Package: @PN@-@MACHINE@-dev
>   Architecture: @DISTRO_ARCH@
>   Description: @DESCRIPTION@, bootloader libraries
>   
> -Package: u-boot-tools
> +Package: @PN@-tools
>   Architecture: linux-any
>   Depends: ${shlibs:Depends}, ${misc:Depends}
>   Description: @DESCRIPTION@, companion tools
> diff --git a/meta/recipes-bsp/u-boot/u-boot-custom.inc b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> index 583cd47..4ec37d0 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-custom.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-custom.inc
> @@ -9,7 +9,7 @@ FILESPATH =. "${LAYERDIR_core}/recipes-bsp/u-boot/files:"
>   
>   DESCRIPTION ?= "Custom U-Boot"
>   
> -PROVIDES += "u-boot-${MACHINE} u-boot-tools"
> +PROVIDES += "${PN}-${MACHINE} ${PN}-${MACHINE}-dev ${PN}-tools"
>   
>   inherit dpkg
>   
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov