From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247988281769984 X-Received: by 10.46.33.86 with SMTP id h83mr2367563ljh.26.1501596004702; Tue, 01 Aug 2017 07:00:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.18.212 with SMTP id 81ls257314lfs.18.gmail; Tue, 01 Aug 2017 07:00:04 -0700 (PDT) X-Received: by 10.25.181.134 with SMTP id g6mr1905486lfk.3.1501596004274; Tue, 01 Aug 2017 07:00:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501596004; cv=none; d=google.com; s=arc-20160816; b=ARLn3+oCSC+1APtkcZUg1JBYQCcVy6Mu7Pjs8uax1zTcoEr5tQKNhBeheH/MrIjlX+ hCBZNfJ4LpYl/LB8rIbD7V36233f3zG49VmkOEJs6Bll5eU+WnMRp72yuMgog8vE9YWN /9n6TAptkKZ9DEerY7Z5qJydRdCDX5QbPilS/EzaYcGu00kpD340FXmaQ6eEybyw3cQk CyKhlqnYoLxyLmszBTIap85w+5PH0BfxiEZOUtwBNhB1+Ew9hWBUASiWAK54oGYcEfGr WFYdo192LPTQV94vnCTcenYUAaQSfGrylkoV7/abL1uCDRoR61muqepMXVDEkM7tK9EX ot1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=4BJriYKDNiquks1aRfmNrPQbEnNZu/GUTXqr0CWAj8o=; b=kXdvVlXBFHUt1N7WaJ4sFlTrS/eCtCkEXTzmHhNcy6Jhi85/4XRS56w6UO9ySZTfOZ GXnQN8krTY4bnsfpWmI15EHHeAyjqN2CzlcUF8GYlyK+1Msz6Bjp6inQzSDOXJKhhU/N ADQ3LGpf8QJnJ8eGoWBrLXG6U6OmNXq4R+ACB6xuKhLkBBqDpwhEzbFr4wekM40zkC94 OMJXbhz2lIQez1TLAMgqm0VWqqKEwIpSh8O4M2dcBO55gHtH5WsJ4qQpSqEu2d9/vtcW kX1iKY31keMR9NrqEikBpby9gCK0kVpqlTVVKSFZ+JSuV6OvtKaIDPeWwuKu5leDLKaF qdNA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id h133si320101wmg.2.2017.08.01.07.00.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 07:00:04 -0700 (PDT) Received-SPF: neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id v71E03Jv028349 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 1 Aug 2017 16:00:03 +0200 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id v71E03CI030649; Tue, 1 Aug 2017 16:00:03 +0200 Subject: Re: [PATCH 13/16] meta: classes: move install_package to isar-base To: "[ext] Henning Schild" , isar-users@googlegroups.com References: <73503162ba0eaa3425468aa1f820c08f0272f261.1501582237.git.henning.schild@siemens.com> From: Claudius Heine Message-ID: <8a72ec15-8fed-e4e3-5dd6-dcdd7252da49@siemens.com> Date: Tue, 1 Aug 2017 16:00:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <73503162ba0eaa3425468aa1f820c08f0272f261.1501582237.git.henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 2aOEqWheYflE On 08/01/2017 12:17 PM, [ext] Henning Schild wrote: > Signed-off-by: Henning Schild > --- > meta/classes/dpkg.bbclass | 9 --------- > meta/classes/isar-base.bbclass | 10 ++++++++++ > 2 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > index 2a1b85c..37b2c8d 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg.bbclass > @@ -20,12 +20,3 @@ do_compile() { > > addtask compile after do_unpack before do_install_package > do_compile[stamp-extra-info] = "${DISTRO}" > - > -# Install package to dedicated deploy directory > -do_install_package() { > - install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ > -} > - > -addtask install_package after do_compile before do_build > -do_install_package[dirs] = "${DEPLOY_DIR_DEB}" > -do_install_package[stamp-extra-info] = "${MACHINE}" > diff --git a/meta/classes/isar-base.bbclass b/meta/classes/isar-base.bbclass > index 3df6572..68e2aed 100644 > --- a/meta/classes/isar-base.bbclass > +++ b/meta/classes/isar-base.bbclass > @@ -32,3 +32,13 @@ python do_unpack() { > addtask unpack after do_fetch before do_build > do_unpack[dirs] = "${WORKDIR}" > do_unpack[stamp-extra-info] = "${DISTRO}" > + > + > +# Install package to dedicated deploy directory > +do_install_package() { > + install -m 755 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ Since I like to use the fetcher tasks for a image recipe, I inherit from this class, but the image recipe does not have any 'deb' files, so building failes here. So it might be more modular if this task moves into an own class. > +} > + > +addtask install_package before do_build > +do_install_package[dirs] = "${DEPLOY_DIR_DEB}" > +do_install_package[stamp-extra-info] = "${MACHINE}" >